From: Matthias Brugger <matthias.bgg@gmail.com>
To: Mars Cheng <mars.cheng@mediatek.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
CC Hwang <cc.hwang@mediatek.com>,
Jades Shih <jades.shih@mediatek.com>,
Loda Chou <loda.chou@mediatek.com>,
Miles Chen <miles.chen@mediatek.com>,
MY Chuang <my.chuang@mediatek.com>,
Scott Shu <scott.shu@mediatek.com>
Subject: Re: [PATCH 2/2] ARM: dts: mediatek: add mt6580 basic support
Date: Wed, 24 Jun 2015 22:25:56 +0200 [thread overview]
Message-ID: <2753320.5M4yQIm8Im@ubix> (raw)
In-Reply-To: <1435147153.3792.9.camel@mtkswgap22>
On Wednesday, June 24, 2015 07:59:13 PM Mars Cheng wrote:
> On Tue, 2015-06-23 at 21:45 +0200, Matthias Brugger wrote:
> > > + soc {
> >
> > Please drop the soc node as well and just add the components directly.
> >
> > Thanks,
> > Matthias
>
> May I know the reason to remove the soc node? I follow other xxxx.dtsi
> to add this node.
The device tree is reflecting the hardware, if you add a soc node like this, it
is seen like a bus, but there is not really a bus.
I think point of view about this has change over time and nowadays it is
preferred not to add a soc node.
Regards,
Matthias
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: dts: mediatek: add mt6580 basic support
Date: Wed, 24 Jun 2015 22:25:56 +0200 [thread overview]
Message-ID: <2753320.5M4yQIm8Im@ubix> (raw)
In-Reply-To: <1435147153.3792.9.camel@mtkswgap22>
On Wednesday, June 24, 2015 07:59:13 PM Mars Cheng wrote:
> On Tue, 2015-06-23 at 21:45 +0200, Matthias Brugger wrote:
> > > + soc {
> >
> > Please drop the soc node as well and just add the components directly.
> >
> > Thanks,
> > Matthias
>
> May I know the reason to remove the soc node? I follow other xxxx.dtsi
> to add this node.
The device tree is reflecting the hardware, if you add a soc node like this, it
is seen like a bus, but there is not really a bus.
I think point of view about this has change over time and nowadays it is
preferred not to add a soc node.
Regards,
Matthias
next prev parent reply other threads:[~2015-06-24 20:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 8:18 [Patch 0/2] Add mt6580 basic chip support Mars Cheng
2015-06-03 8:18 ` Mars Cheng
2015-06-03 8:18 ` [PATCH 1/2] Document: DT: Add bindings for mediatek MT6580 SoC Platform Mars Cheng
2015-06-03 8:18 ` Mars Cheng
2015-06-03 8:18 ` [PATCH 2/2] ARM: dts: mediatek: add mt6580 basic support Mars Cheng
2015-06-03 8:18 ` Mars Cheng
2015-06-23 19:29 ` Matthias Brugger
2015-06-24 11:54 ` Mars Cheng
2015-06-24 11:54 ` Mars Cheng
2015-06-24 11:54 ` Mars Cheng
2015-06-23 19:45 ` Matthias Brugger
2015-06-24 11:59 ` Mars Cheng
2015-06-24 11:59 ` Mars Cheng
2015-06-24 11:59 ` Mars Cheng
2015-06-24 20:25 ` Matthias Brugger [this message]
2015-06-24 20:25 ` Matthias Brugger
2015-06-25 0:15 ` Mars Cheng
2015-06-25 0:15 ` Mars Cheng
2015-06-25 0:15 ` Mars Cheng
2015-07-02 3:29 ` Mars Cheng
2015-07-02 3:29 ` Mars Cheng
2015-07-02 3:29 ` Mars Cheng
2015-07-03 13:30 ` Matthias Brugger
2015-07-03 13:30 ` Matthias Brugger
2015-06-15 3:08 ` [Patch 0/2] Add mt6580 basic chip support Mars Cheng
2015-06-15 3:08 ` Mars Cheng
2015-06-15 3:08 ` Mars Cheng
-- strict thread matches above, loose matches on Subject: below --
2015-07-07 7:56 [PATCH v3 " mars.cheng-NuS5LvNUpcJWk0Htik3J/w
[not found] ` <1436255771-5367-1-git-send-email-mars.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-07-07 7:56 ` [PATCH 2/2] ARM: dts: mediatek: add mt6580 basic support mars.cheng-NuS5LvNUpcJWk0Htik3J/w
2015-07-07 7:56 ` mars.cheng
[not found] ` <1436255771-5367-3-git-send-email-mars.cheng-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-07-07 8:10 ` Mars Cheng
2015-07-07 8:10 ` Mars Cheng
2015-07-10 15:01 ` Matthias Brugger
2015-07-10 15:01 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2753320.5M4yQIm8Im@ubix \
--to=matthias.bgg@gmail.com \
--cc=cc.hwang@mediatek.com \
--cc=jades.shih@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=loda.chou@mediatek.com \
--cc=mars.cheng@mediatek.com \
--cc=miles.chen@mediatek.com \
--cc=my.chuang@mediatek.com \
--cc=scott.shu@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.