All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 03/04] ARM: shmobile: Genmai I2C-over-GPIO support
Date: Wed, 27 Nov 2013 11:15:52 +0000	[thread overview]
Message-ID: <2757102.StIMV2khe5@avalon> (raw)
In-Reply-To: <20131127082805.20015.82680.sendpatchset@w520>

Hi Magnus,

Thank you for the patch.

On Wednesday 27 November 2013 17:28:05 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add support for the Genmai I2C bus hooked up to P1_5 and P1_4 using
> the i2c-gpio driver. On the bus sits a 24c128 EEPRROM.

Is this a temporary workaround until we get a proper I2C controller driver, or 
is the EEPROM really hooked up to pins that are not wired to a hardware I2C 
controller ?

> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  arch/arm/boot/dts/r7s72100-genmai-reference.dts |   18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> --- 0008/arch/arm/boot/dts/r7s72100-genmai-reference.dts
> +++ work/arch/arm/boot/dts/r7s72100-genmai-reference.dts	2013-11-27
> 15:51:31.000000000 +0900 @@ -39,4 +39,22 @@
>  			gpios = <&port4 11 GPIO_ACTIVE_LOW>;
>  		};
>  	};
> +
> +	i2c@0 {
> +		compatible = "i2c-gpio";
> +		gpios = <&port1 5 GPIO_ACTIVE_HIGH /* sda */
> +			 &port1 4 GPIO_ACTIVE_HIGH /* scl */
> +			>;
> +		i2c-gpio,sda-open-drain;
> +		i2c-gpio,scl-open-drain;
> +		i2c-gpio,delay-us = <5>;	/* ~100 kHz */
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		eeprom: 24c128@50 {
> +			compatible = "at,24c128";
> +			reg = <0x50>;
> +		};
> +	};
> +
>  };
-- 
Regards,

Laurent Pinchart


WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 03/04] ARM: shmobile: Genmai I2C-over-GPIO support
Date: Wed, 27 Nov 2013 12:15:52 +0100	[thread overview]
Message-ID: <2757102.StIMV2khe5@avalon> (raw)
In-Reply-To: <20131127082805.20015.82680.sendpatchset@w520>

Hi Magnus,

Thank you for the patch.

On Wednesday 27 November 2013 17:28:05 Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
> 
> Add support for the Genmai I2C bus hooked up to P1_5 and P1_4 using
> the i2c-gpio driver. On the bus sits a 24c128 EEPRROM.

Is this a temporary workaround until we get a proper I2C controller driver, or 
is the EEPROM really hooked up to pins that are not wired to a hardware I2C 
controller ?

> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
> 
>  arch/arm/boot/dts/r7s72100-genmai-reference.dts |   18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> --- 0008/arch/arm/boot/dts/r7s72100-genmai-reference.dts
> +++ work/arch/arm/boot/dts/r7s72100-genmai-reference.dts	2013-11-27
> 15:51:31.000000000 +0900 @@ -39,4 +39,22 @@
>  			gpios = <&port4 11 GPIO_ACTIVE_LOW>;
>  		};
>  	};
> +
> +	i2c at 0 {
> +		compatible = "i2c-gpio";
> +		gpios = <&port1 5 GPIO_ACTIVE_HIGH /* sda */
> +			 &port1 4 GPIO_ACTIVE_HIGH /* scl */
> +			>;
> +		i2c-gpio,sda-open-drain;
> +		i2c-gpio,scl-open-drain;
> +		i2c-gpio,delay-us = <5>;	/* ~100 kHz */
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		eeprom: 24c128 at 50 {
> +			compatible = "at,24c128";
> +			reg = <0x50>;
> +		};
> +	};
> +
>  };
-- 
Regards,

Laurent Pinchart

  parent reply	other threads:[~2013-11-27 11:15 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27  8:27 [PATCH 00/04] ARM: shmobile: r7s72100 and Genmai GPIO / PINCTRL support Magnus Damm
2013-11-27  8:27 ` Magnus Damm
2013-11-27  8:27 ` [PATCH 01/04] ARM: shmobile: r7s72100 GPIO and PINCTRL device nodes Magnus Damm
2013-11-27  8:27   ` Magnus Damm
2013-11-27  8:27 ` [PATCH 02/04] ARM: shmobile: Genmai LED1 and LED2 support Magnus Damm
2013-11-27  8:27   ` Magnus Damm
2013-11-27 11:16   ` Laurent Pinchart
2013-11-27 11:16     ` Laurent Pinchart
2013-11-27  8:28 ` [PATCH 03/04] ARM: shmobile: Genmai I2C-over-GPIO support Magnus Damm
2013-11-27  8:28   ` Magnus Damm
2013-11-27 11:04   ` Wolfram Sang
2013-11-27 11:04     ` Wolfram Sang
2013-11-28 17:11     ` Sergei Shtylyov
2013-11-28 17:11       ` Sergei Shtylyov
2013-11-28 17:14       ` Laurent Pinchart
2013-11-28 17:14         ` Laurent Pinchart
2013-11-28 18:13         ` Sergei Shtylyov
2013-11-28 18:13           ` Sergei Shtylyov
2013-11-27 11:15   ` Laurent Pinchart [this message]
2013-11-27 11:15     ` Laurent Pinchart
2013-11-28  0:44     ` Magnus Damm
2013-11-28  0:44       ` Magnus Damm
2013-11-28  0:46       ` Laurent Pinchart
2013-11-28  0:46         ` Laurent Pinchart
2013-11-27  8:28 ` [PATCH 04/04] ARM: shmobile: Genmai SCIF2 PINCTRL configuration Magnus Damm
2013-11-27  8:28   ` Magnus Damm
2013-11-27 11:16   ` Laurent Pinchart
2013-11-27 11:16     ` Laurent Pinchart
2013-11-27 11:13 ` [PATCH 00/04] ARM: shmobile: r7s72100 and Genmai GPIO / PINCTRL support Laurent Pinchart
2013-11-27 11:13   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2757102.StIMV2khe5@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.