All of lore.kernel.org
 help / color / mirror / Atom feed
* xf86-video-intel-2.20.0: Option 'XvMC' does not work
@ 2012-09-23  5:14 Giacomo Comes
  2012-09-23  8:00 ` Chris Wilson
  0 siblings, 1 reply; 2+ messages in thread
From: Giacomo Comes @ 2012-09-23  5:14 UTC (permalink / raw)
  To: intel-gfx

Hi,
I have a laptop with the Pineview GM chipset.
With the intel driver 2.20.0 I cannot enable anymore XvMC.
Normally I add in the device Section:
  Option "XvMC" "on"
and up to driver ver 2.19.0 in the X log file I find:

 (**) intel(0): Option "XvMC" "on"

 (**) intel(0): Intel XvMC decoder enabled
 (II) intel(0): [XvMC] i915_xvmc driver initialized.

But with driver 2.20.0 in log file I find:

 (==) intel(0): Intel XvMC decoder disabled
 (WW) intel(0): Option "XvMC" is not used

Looking in the source file I have found that in src/intel_option.c
and in src/intel_options.h the are some 
  #ifdef INTEL_XVMC
statements.
When the source file intel_option.c is compiled the symbol INTEL_XVMC
is undefined but it is defined if intel.h is included.

I have added
  #include "intel.h"
before
  #include "intel_options.h"
in src/intel_options.c and recompiled the driver.

With that fix
  Option "XvMC" "on"
is working again.

Giacomo

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: xf86-video-intel-2.20.0: Option 'XvMC' does not work
  2012-09-23  5:14 xf86-video-intel-2.20.0: Option 'XvMC' does not work Giacomo Comes
@ 2012-09-23  8:00 ` Chris Wilson
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2012-09-23  8:00 UTC (permalink / raw)
  To: Giacomo Comes, intel-gfx

On Sun, 23 Sep 2012 01:14:57 -0400, Giacomo Comes <comes@naic.edu> wrote:
> Hi,
> I have a laptop with the Pineview GM chipset.
> With the intel driver 2.20.0 I cannot enable anymore XvMC.
> Normally I add in the device Section:
>   Option "XvMC" "on"
> and up to driver ver 2.19.0 in the X log file I find:
> 
>  (**) intel(0): Option "XvMC" "on"
> 
>  (**) intel(0): Intel XvMC decoder enabled
>  (II) intel(0): [XvMC] i915_xvmc driver initialized.
> 
> But with driver 2.20.0 in log file I find:
> 
>  (==) intel(0): Intel XvMC decoder disabled
>  (WW) intel(0): Option "XvMC" is not used

Thanks, I've jiggled the defines around so that it is now defined before
the option:

commit c2ca1c5abca687adb08d6e137bc3b70bdecb083d
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Sun Sep 23 08:56:50 2012 +0100

    Reorder INTEL_XVMC define so that we pick up Option "XvMC"
    
    Otherwise it will remain disabled.
    
    Reported-by: Giacomo Comes <comes@naic.edu>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-23  8:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-23  5:14 xf86-video-intel-2.20.0: Option 'XvMC' does not work Giacomo Comes
2012-09-23  8:00 ` Chris Wilson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.