All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: pgwipeout@gmail.com, Furkan Kardame <f.kardame@manjaro.org>
Cc: linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Furkan Kardame <f.kardame@manjaro.org>
Subject: Re: [PATCHv2] Follow-up patch rk3566-roc-pc audio nodes
Date: Tue, 10 Jan 2023 23:51:51 +0100	[thread overview]
Message-ID: <2766066.Sgy9Pd6rRy@diego> (raw)
In-Reply-To: <20230110184008.21492-1-f.kardame@manjaro.org>

Hi Furkan,

Am Dienstag, 10. Januar 2023, 19:40:08 CET schrieb Furkan Kardame:
> Enabled hdmi_sound
> i2s1_8ch only uses a single channel
> i2s1m0_sdo{1,2,3} and i2s1m0_sdi{1,2,3} is used by pcie
> 
> Signed-off-by: Furkan Kardame <f.kardame@manjaro.org>

so I've folded the changes from this into the original commit because I
applied the other one just today.


But normally I would expect what is called a "follow up commit" to really
be a regular commit with a correct subject etc.

So the following is moot, because I took in the changes, but normally I
would expect 2 commits from the code below:
- arm64: dts: rockchip: enable hdmi-sound on rk3566-roc-pc
- arm64: dts: rockchip: change i2s1-8ch to single-channel on rk3566-roc-pc


Heiko

> ---
>  arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
> index e60643581..42889c590 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
> @@ -216,6 +216,10 @@ hdmi_out_con: endpoint {
>  	};
>  };
>  
> +&hdmi_sound {
> +	status = "okay";
> +};
> +
>  &i2c0 {
>  	status = "okay";
>  
> @@ -481,6 +485,9 @@ &i2s0_8ch {
>  };
>  
>  &i2s1_8ch {
> +	pinctrl-0 = <&i2s1m0_sclktx &i2s1m0_sclkrx
> +			&i2s1m0_lrcktx &i2s1m0_lrckrx
> +			&i2s1m0_sdi0   &i2s1m0_sdo0>;
>  	rockchip,trcm-sync-tx-only;
>  	status = "okay";
>  };
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: pgwipeout@gmail.com, Furkan Kardame <f.kardame@manjaro.org>
Cc: linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	Furkan Kardame <f.kardame@manjaro.org>
Subject: Re: [PATCHv2] Follow-up patch rk3566-roc-pc audio nodes
Date: Tue, 10 Jan 2023 23:51:51 +0100	[thread overview]
Message-ID: <2766066.Sgy9Pd6rRy@diego> (raw)
In-Reply-To: <20230110184008.21492-1-f.kardame@manjaro.org>

Hi Furkan,

Am Dienstag, 10. Januar 2023, 19:40:08 CET schrieb Furkan Kardame:
> Enabled hdmi_sound
> i2s1_8ch only uses a single channel
> i2s1m0_sdo{1,2,3} and i2s1m0_sdi{1,2,3} is used by pcie
> 
> Signed-off-by: Furkan Kardame <f.kardame@manjaro.org>

so I've folded the changes from this into the original commit because I
applied the other one just today.


But normally I would expect what is called a "follow up commit" to really
be a regular commit with a correct subject etc.

So the following is moot, because I took in the changes, but normally I
would expect 2 commits from the code below:
- arm64: dts: rockchip: enable hdmi-sound on rk3566-roc-pc
- arm64: dts: rockchip: change i2s1-8ch to single-channel on rk3566-roc-pc


Heiko

> ---
>  arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
> index e60643581..42889c590 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-roc-pc.dts
> @@ -216,6 +216,10 @@ hdmi_out_con: endpoint {
>  	};
>  };
>  
> +&hdmi_sound {
> +	status = "okay";
> +};
> +
>  &i2c0 {
>  	status = "okay";
>  
> @@ -481,6 +485,9 @@ &i2s0_8ch {
>  };
>  
>  &i2s1_8ch {
> +	pinctrl-0 = <&i2s1m0_sclktx &i2s1m0_sclkrx
> +			&i2s1m0_lrcktx &i2s1m0_lrckrx
> +			&i2s1m0_sdi0   &i2s1m0_sdo0>;
>  	rockchip,trcm-sync-tx-only;
>  	status = "okay";
>  };
> 





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-01-10 22:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-10 18:40 [PATCHv2] Follow-up patch rk3566-roc-pc audio nodes Furkan Kardame
2023-01-10 18:40 ` Furkan Kardame
2023-01-10 22:51 ` Heiko Stübner [this message]
2023-01-10 22:51   ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2766066.Sgy9Pd6rRy@diego \
    --to=heiko@sntech.de \
    --cc=f.kardame@manjaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=pgwipeout@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.