From: Thomas Monjalon <thomas@monjalon.net>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: stable@dpdk.org, "Wu, Jingjing" <jingjing.wu@intel.com>,
dev@dpdk.org, "Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-stable] [PATCH 1/2] app/testpmd: fix crash at mbuf pool creation
Date: Mon, 01 May 2017 15:18:11 +0200 [thread overview]
Message-ID: <2767337.ChMh6S42Js@xps> (raw)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810D5A14D@SHSMSX103.ccr.corp.intel.com>
28/04/2017 10:51, Wu, Jingjing:
> From: Olivier Matz [mailto:olivier.matz@6wind.com]
> > Since
> > commit 999b2ee0fe45 ("app/testpmd: enable NUMA support by default"),
> > testpmd is started with numa enabled by default. This highlights a floating point
> > exception when started with --total-num-mbufs without any port (division by 0).
> > This bug was already triggered before this commit if the --no-numa option was
> > given.
> >
> > This commit adds a check of the nb_ports value before doing the division. By
> > looking at this code, it appears that the creation of the mbuf pool is not
> > consistent for the number of mbufs depending on the configuration. This is fixed
> > in the next commit.
> >
> > Fixes: b6ea6408fbc7 ("ethdev: store numa_node per device")
> >
> > CC: stable@dpdk.org
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
Series applied, thanks
prev parent reply other threads:[~2017-05-01 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 12:33 [PATCH 1/2] app/testpmd: fix crash at mbuf pool creation Olivier Matz
2017-04-24 12:33 ` [PATCH 2/2] app/testpmd: fix number of mbufs in pool Olivier Matz
2017-04-28 9:04 ` Wu, Jingjing
2017-04-28 8:51 ` [PATCH 1/2] app/testpmd: fix crash at mbuf pool creation Wu, Jingjing
2017-05-01 13:18 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2767337.ChMh6S42Js@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.