All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Felipe Franciosi <felipe@nutanix.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_ring: fix description of virtqueue_get_buf
Date: Tue, 15 Nov 2016 11:21:48 +0800	[thread overview]
Message-ID: <276972d5-ee01-9c4a-d3cc-0db4d0dd2b7b@redhat.com> (raw)
In-Reply-To: <1479132975-8517-1-git-send-email-felipe@nutanix.com>



On 2016年11月14日 22:16, Felipe Franciosi wrote:
> The device (not the driver) populates the used ring and includes the len
> of how much data was written.
>
> Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
> ---
>   drivers/virtio/virtio_ring.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 489bfc6..8a0d6a9 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -649,7 +649,7 @@ static inline bool more_used(const struct vring_virtqueue *vq)
>    * @vq: the struct virtqueue we're talking about.
>    * @len: the length written into the buffer
>    *
> - * If the driver wrote data into the buffer, @len will be set to the
> + * If the device wrote data into the buffer, @len will be set to the
>    * amount written.  This means you don't need to clear the buffer
>    * beforehand to ensure there's no data leakage in the case of short
>    * writes.

Reviewed-by: Jason Wang <jasowang@redhat.com>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com>
To: Felipe Franciosi <felipe@nutanix.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_ring: fix description of virtqueue_get_buf
Date: Tue, 15 Nov 2016 11:21:48 +0800	[thread overview]
Message-ID: <276972d5-ee01-9c4a-d3cc-0db4d0dd2b7b@redhat.com> (raw)
In-Reply-To: <1479132975-8517-1-git-send-email-felipe@nutanix.com>



On 2016年11月14日 22:16, Felipe Franciosi wrote:
> The device (not the driver) populates the used ring and includes the len
> of how much data was written.
>
> Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
> ---
>   drivers/virtio/virtio_ring.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 489bfc6..8a0d6a9 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -649,7 +649,7 @@ static inline bool more_used(const struct vring_virtqueue *vq)
>    * @vq: the struct virtqueue we're talking about.
>    * @len: the length written into the buffer
>    *
> - * If the driver wrote data into the buffer, @len will be set to the
> + * If the device wrote data into the buffer, @len will be set to the
>    * amount written.  This means you don't need to clear the buffer
>    * beforehand to ensure there's no data leakage in the case of short
>    * writes.

Reviewed-by: Jason Wang <jasowang@redhat.com>

  reply	other threads:[~2016-11-15  3:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 14:16 [PATCH] virtio_ring: fix description of virtqueue_get_buf Felipe Franciosi
2016-11-14 14:16 ` Felipe Franciosi
2016-11-15  3:21 ` Jason Wang [this message]
2016-11-15  3:21   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=276972d5-ee01-9c4a-d3cc-0db4d0dd2b7b@redhat.com \
    --to=jasowang@redhat.com \
    --cc=felipe@nutanix.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.