All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carsten Schiers <carsten@schiers.de>
To: Jan Beulich <JBeulich@novell.com>,
	Ian Campbell <Ian.Campbell@citrix.com>
Cc: Ky Srinivasan <KSrinivasan@novell.com>, xen-devel@lists.xensource.com
Subject: AW: Problem compiling Kernel 2.6.18 - netfront.c
Date: Tue, 12 Oct 2010 12:34:36 +0200	[thread overview]
Message-ID: <27710945.71286879676308.JavaMail.root@uhura> (raw)
In-Reply-To: <4CB44C8B020000780001C6EA@vpn.id2.novell.com>

Sorry, my machine is pretty slow and I wanted to do a fresh compile...

Yes, solves the issue. Just saw that the patch is already in the repo.

Thanks,
Carsten.


----- Originalnachricht -----
Von: Jan Beulich <JBeulich@novell.com>
Gesendet: Die, 12.10.2010 11:54
An: Ian Campbell <Ian.Campbell@citrix.com> ; Carsten Schiers <carsten@schiers.de>
Cc: xen-devel@lists.xensource.com ; Ky Srinivasan <KSrinivasan@novell.com>
Betreff: Re: [Xen-devel] Problem compiling Kernel 2.6.18 - netfront.c

>>> On 12.10.10 at 11:20, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> Looks like 2.6.18 sysfs differs from whichever kernel the patch was
> originally written against.

Yes, I'm sorry for that, I didn't notice that the corresponding code in
netback changed twice (in .21 and .30).

> Untested patch based on the netback get_drvinfo method from 2.6.18
> below, does it work for you?

Looks exactly like what's needed.

Acked-by: Jan Beulich <jbeulich@novell.com>

> diff -r 578f036ec7dd drivers/xen/netfront/netfront.c
> --- a/drivers/xen/netfront/netfront.c    Mon Oct 11 10:25:55 2010 +0100
> +++ b/drivers/xen/netfront/netfront.c    Tue Oct 12 10:19:15 2010 +0100
> @@ -1776,7 +1776,7 @@ static void netfront_get_drvinfo(struct 
>                   struct ethtool_drvinfo *info)
>  {
>      strcpy(info->driver, "netfront");
> -    strcpy(info->bus_info, dev_name(dev->dev.parent));
> +    strcpy(info->bus_info, dev->class_dev.dev->bus_id);
>  }
>  
>  static int network_connect(struct net_device *dev)
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com 
> http://lists.xensource.com/xen-devel 

      reply	other threads:[~2010-10-12 10:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-12  8:56 Problem compiling Kernel 2.6.18 - netfront.c Carsten Schiers
2010-10-12  9:20 ` Ian Campbell
2010-10-12  9:54   ` Jan Beulich
2010-10-12 10:34     ` Carsten Schiers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27710945.71286879676308.JavaMail.root@uhura \
    --to=carsten@schiers.de \
    --cc=Ian.Campbell@citrix.com \
    --cc=JBeulich@novell.com \
    --cc=KSrinivasan@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.