From: "Heiko Stübner" <heiko@sntech.de>
To: FUKAUMI Naoki <naoki@radxa.com>
Cc: linux-rockchip@lists.infradead.org, FUKAUMI Naoki <naoki@radxa.com>
Subject: Re: [PATCH] arm64: dts: rockchip: fix pinctrl for pcie2x1l2 for Radxa ROCK 5A
Date: Mon, 30 Sep 2024 09:54:47 +0200 [thread overview]
Message-ID: <2772744.mvXUDI8C0e@diego> (raw)
In-Reply-To: <20240930022837.885-1-naoki@radxa.com>
Hi,
Am Montag, 30. September 2024, 04:28:37 CEST schrieb FUKAUMI Naoki:
> for pcie2x1l2, only pcie20x1_2_perstn_m0 is required.
> fix pinctrl definitions for pcie2x1l2.
I guess the other pins are used for something different?
Not criticizing the change itself, but for a "fixes", I do expect some
explanation, why the previous setting is _wrong_ .
Thanks
Heiko
> Fixes: b728d4c51f0c ("arm64: dts: rockchip: enable PCIe on M.2 E key for Radxa ROCK 5A")
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> index 435355433bbd..1d7adece42a5 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5a.dts
> @@ -310,7 +310,7 @@ rgmii_phy1: ethernet-phy@1 {
> };
>
> &pcie2x1l2 {
> - pinctrl-0 = <&pcie20x1m0_pins>;
> + pinctrl-0 = <&pcie20x1_2_perstn_m0>;
> pinctrl-names = "default";
> reset-gpios = <&gpio3 RK_PD1 GPIO_ACTIVE_HIGH>;
> vpcie3v3-supply = <&vcc3v3_wf>;
> @@ -325,6 +325,10 @@ io_led: io-led {
> };
>
> pcie {
> + pcie20x1_2_perstn_m0: pcie20x1-2-perstn-m0 {
> + rockchip,pins = <3 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>;
> + };
> +
> pow_en: pow-en {
> rockchip,pins = <0 RK_PC5 RK_FUNC_GPIO &pcfg_pull_none>;
> };
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-09-30 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 2:28 [PATCH] arm64: dts: rockchip: fix pinctrl for pcie2x1l2 for Radxa ROCK 5A FUKAUMI Naoki
2024-09-30 7:54 ` Heiko Stübner [this message]
2024-09-30 9:34 ` FUKAUMI Naoki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2772744.mvXUDI8C0e@diego \
--to=heiko@sntech.de \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.