* No invalid histogram error
@ 2019-06-20 12:17 Masami Hiramatsu
2019-06-20 14:47 ` Zanussi, Tom
0 siblings, 1 reply; 2+ messages in thread
From: Masami Hiramatsu @ 2019-06-20 12:17 UTC (permalink / raw)
To: Tom Zanussi; +Cc: linux-kernel, Steven Rostedt
Hi Tom,
I'm trying to use histogram on a synthetic event, but faced an odd situation.
There is a synthetic event, which has foo and bar.
/sys/kernel/debug/tracing # cat synthetic_events
testevent int foo; int bar
And when I tried to add hist on trigger, both foo and bar can be used as below.
/sys/kernel/debug/tracing # echo "hist:keys=bar" > events/synthetic/testevent/trigger
/sys/kernel/debug/tracing # echo "hist:keys=foo" > events/synthetic/testevent/trigger
And, when I missed to specify the sort key, it failed
/sys/kernel/debug/tracing # echo "hist:keys=foo:sort=bar" > events/synthetic/testevent/trigger
sh: write error: Invalid argument
But no error on error_log file.
/sys/kernel/debug/tracing # cat error_log
/sys/kernel/debug/tracing #
Could you add some error message? What about below?
[ 5422.134656] hist:synthetic:testevent: error: Sort key must be one of keys.
Command: keys=foo;sort=bar
^
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: No invalid histogram error
2019-06-20 12:17 No invalid histogram error Masami Hiramatsu
@ 2019-06-20 14:47 ` Zanussi, Tom
0 siblings, 0 replies; 2+ messages in thread
From: Zanussi, Tom @ 2019-06-20 14:47 UTC (permalink / raw)
To: Masami Hiramatsu; +Cc: linux-kernel, Steven Rostedt
Hi Masami,
On 6/20/2019 7:17 AM, Masami Hiramatsu wrote:
> Hi Tom,
>
> I'm trying to use histogram on a synthetic event, but faced an odd situation.
>
> There is a synthetic event, which has foo and bar.
>
> /sys/kernel/debug/tracing # cat synthetic_events
> testevent int foo; int bar
>
> And when I tried to add hist on trigger, both foo and bar can be used as below.
>
> /sys/kernel/debug/tracing # echo "hist:keys=bar" > events/synthetic/testevent/trigger
> /sys/kernel/debug/tracing # echo "hist:keys=foo" > events/synthetic/testevent/trigger
>
> And, when I missed to specify the sort key, it failed
>
> /sys/kernel/debug/tracing # echo "hist:keys=foo:sort=bar" > events/synthetic/testevent/trigger
> sh: write error: Invalid argument
>
> But no error on error_log file.
>
> /sys/kernel/debug/tracing # cat error_log
> /sys/kernel/debug/tracing #
>
> Could you add some error message? What about below?
>
> [ 5422.134656] hist:synthetic:testevent: error: Sort key must be one of keys.
> Command: keys=foo;sort=bar
> ^
Sure, I'll submit a fix for this. Thanks for pointing it out.
Tom
> Thank you,
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-20 14:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-20 12:17 No invalid histogram error Masami Hiramatsu
2019-06-20 14:47 ` Zanussi, Tom
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.