Re: [PATCH v1 4/4] spi: Drop duplicate device_set_node() call

From: "Benoît Monin" <benoit.monin@bootlin.com>
To: "Mark Brown" <broonie@kernel.org>,
	"Varshini Rajendran" <varshini.rajendran@microchip.com>,
	"Mikhail Kshevetskiy" <mikhail.kshevetskiy@iopsys.eu>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Sunny Luo" <sunny.luo@amlogic.com>,
	"Janne Grunau" <j@jannau.net>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Chin-Ting Kuo" <chin-ting_kuo@aspeedtech.com>,
	"CL Wang" <cl634@andestech.com>,
	"Manikandan Muralidharan" <manikandan.m@microchip.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Hang Zhou" <929513338@qq.com>, "Jun Guo" <jun.guo@cixtech.com>,
	"Philipp Stanner" <phasta@kernel.org>,
	"Charles Keepax" <ckeepax@opensource.cirrus.com>,
	"Bartosz Golaszewski" <brgl@kernel.org>,
	"Shiji Yang" <yangshiji66@outlook.com>,
	"James Clark" <james.clark@linaro.org>,
	"Jonathan Marek" <jonathan@marek.ca>,
	"Carlos Song" <carlos.song@nxp.com>,
	"Sakari Ailus" <sakari.ailus@linux.intel.com>,
	"Huacai Chen" <chenhuacai@kernel.org>,
	"Xianwei Zhao" <xianwei.zhao@amlogic.com>,
	"Prajna Rajendra Kumar" <prajna.rajendrakumar@microchip.com>,
	"Sergio Perez Gonzalez" <sperezglz@gmail.com>,
	"Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Qianfeng Rong" <rongqianfeng@vivo.com>,
	"Haibo Chen" <haibo.chen@nxp.com>,
	"Gabor Juhos" <j4g8y7@gmail.com>,
	"Md Sadre Alam" <quic_mdalam@quicinc.com>,
	"Rosen Penev" <rosenp@gmail.com>,
	"Luis de Arquer" <luis.dearquer@inertim.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Cosmin Tanislav" <cosmin-gabriel.tanislav.xa@renesas.com>,
	"Tudor Ambarus" <tudor.ambarus@linaro.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Longbin Li" <looong.bin@gmail.com>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Clément Le Goffic" <clement.legoffic@foss.st.com>,
	"Alessandro Grassi" <alessandro.grassi@mailbox.org>,
	"Chen-Yu Tsai" <wens@kernel.org>,
	"Darshan R" <rathod.darshan.0896@gmail.com>,
	"Aaron Kling" <webgeek1234@gmail.com>,
	"Vishwaroop A" <va@nvidia.com>,
	"Haixu Cui" <quic_haixcui@quicinc.com>,
	"Darshan Rathod" <darshanrathod475@gmail.com>,
	linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
	asahi@lists.linux.dev, linux-aspeed@lists.ozlabs.org,
	openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org,
	linux-sound@vger.kernel.org, patches@opensource.cirrus.com,
	imx@lists.linux.dev, linux-arm-msm@vger.kernel.org,
	linux-riscv@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	linux-renesas-soc@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org,
	virtualization@lists.linux.dev,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: "Nicolas Ferre" <nicolas.ferre@microchip.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
	"Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Ray Liu" <ray.liu@airoha.com>, "Sven Peter" <sven@kernel.org>,
	"Neal Gompa" <neal@gompa.dev>, "Cédric Le Goater" <clg@kaod.org>,
	"Joel Stanley" <joel@jms.id.au>,
	"Andrew Jeffery" <andrew@codeconstruct.com.au>,
	"Ryan Wanner" <ryan.wanner@microchip.com>,
	"Michael Hennerich" <michael.hennerich@analog.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Kamal Dasu" <kamal.dasu@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Ray Jui" <rjui@broadcom.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	"William Zhang" <william.zhang@broadcom.com>,
	"Kursad Oney" <kursad.oney@broadcom.com>,
	"Anand Gore" <anand.gore@broadcom.com>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"David Rhodes" <david.rhodes@cirrus.com>,
	"Richard Fitzgerald" <rf@opensource.cirrus.com>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Jean-Marie Verdun" <verdun@hpe.com>,
	"Nick Hawkins" <nick.hawkins@hpe.com>,
	"Yang Shen" <shenyang39@huawei.com>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Lixu Zhang" <lixu.zhang@intel.com>,
	"Yinbo Zhu" <zhuyinbo@loongson.cn>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Jerome Brunet" <jbrunet@baylibre.com>,
	"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Daire McNamara" <daire.mcnamara@microchip.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"Avi Fishman" <avifishman70@gmail.com>,
	"Tomer Maimon" <tmaimon77@gmail.com>,
	"Tali Perry" <tali.perry1@gmail.com>,
	"Patrick Venture" <venture@google.com>,
	"Nancy Yuen" <yuenn@google.com>,
	"Benjamin Fair" <benjaminfair@google.com>,
	"Han Xu" <han.xu@nxp.com>,
	"Yogesh Gaur" <yogeshgaur.83@gmail.com>,
	"Linus Walleij" <linusw@kernel.org>,
	"Daniel Mack" <daniel@zonque.org>,
	"Haojian Zhuang" <haojian.zhuang@gmail.com>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>,
	"Chris Packham" <chris.packham@alliedtelesis.co.nz>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Fabrizio Castro" <fabrizio.castro.jz@renesas.com>,
	"Andi Shyti" <andi.shyti@kernel.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	"Orson Zhai" <orsonzhai@gmail.com>,
	"Baolin Wang" <baolin.wang@linux.alibaba.com>,
	"Chunyan Zhang" <zhang.lyra@gmail.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Alain Volmat" <alain.volmat@foss.st.com>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Li-hao Kuo" <lhjeff911@gmail.com>,
	"Masahisa Kojima" <masahisa.kojima@linaro.org>,
	"Jassi Brar" <jaswinder.singh@linaro.org>,
	"Laxman Dewangan" <ldewangan@nvidia.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Sowjanya Komatineni" <skomatineni@nvidia.com>,
	"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Michal Simek" <michal.simek@amd.com>,
	"Max Filippov" <jcmvbkbc@gmail.com>
Subject: Re: [PATCH v1 4/4] spi: Drop duplicate device_set_node() call
Date: Mon, 12 Jan 2026 15:10:36 +0100	[thread overview]
Message-ID: <2776743.vuYhMxLoTh@benoit.monin> (raw)
In-Reply-To: <20260108203004.3538449-5-andriy.shevchenko@linux.intel.com>

On Thursday, 8 January 2026 at 21:23:41 CET, Andy Shevchenko wrote:
> The SPI core provides the default fwnode for the controller,
> assigned by device_set_node(). No need to repeat it in the driver.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

>  drivers/spi/spi-dw-core.c           | 2 --
> 
Works fine on Mobileye EyeQ6Lplus SoC in both host and target mode.

Tested-by: Benoît Monin <benoit.monin@bootlin.com> # dw mobileye

Thanks,
-- 
Benoît Monin, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com