* [PATCH 4/7] Char: isicom, remove unneeded memset
@ 2006-10-19 20:26 Jiri Slaby
2006-10-19 21:52 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2006-10-19 20:26 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
isicom, remove unneeded memset
Memsetting of global static variables is not needed in the init code.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
commit a2d2f722e0d805a57d7835e715c520ca7a7580a7
tree 5bf84122a37ff113797c54f122f0144b3a302237
parent a11b72a2838aa7dfee930168faeebf25a23c70d4
author Jiri Slaby <jirislaby@gmail.com> Thu, 19 Oct 2006 19:28:14 +0200
committer Jiri Slaby <jirislaby@gmail.com> Thu, 19 Oct 2006 19:28:14 +0200
drivers/char/isicom.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/char/isicom.c b/drivers/char/isicom.c
index 8cd6cc2..1b9ef44 100644
--- a/drivers/char/isicom.c
+++ b/drivers/char/isicom.c
@@ -1835,7 +1835,6 @@ static int __init isicom_init(void)
struct isi_port *port;
card = 0;
- memset(isi_ports, 0, sizeof(isi_ports));
for(idx = 0; idx < BOARD_COUNT; idx++) {
port = &isi_ports[idx * 16];
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/7] Char: isicom, remove unneeded memset
2006-10-19 20:26 [PATCH 4/7] Char: isicom, remove unneeded memset Jiri Slaby
@ 2006-10-19 21:52 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2006-10-19 21:52 UTC (permalink / raw)
To: Jiri Slaby; +Cc: Andrew Morton, linux-kernel
Ar Iau, 2006-10-19 am 22:26 +0200, ysgrifennodd Jiri Slaby:
> isicom, remove unneeded memset
>
> Memsetting of global static variables is not needed in the init code.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-19 21:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-19 20:26 [PATCH 4/7] Char: isicom, remove unneeded memset Jiri Slaby
2006-10-19 21:52 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.