From: Heiko Stuebner <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>
Cc: "Huang, Tao" <huangtao@rock-chips.com>,
Russell King <linux@arm.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Chris Zhong <zyw@rock-chips.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Tony Xie <tony.xie@rock-chips.com>
Subject: Re: [PATCH] ARM: rockchip: restore dapswjdp after suspend
Date: Thu, 21 May 2015 19:59:13 +0200 [thread overview]
Message-ID: <2799695.KoAD3Q19Xm@phil> (raw)
In-Reply-To: <CAD=FV=XARAYzLWy+i9f1XuTZTa4RiA5Yb9aJoAuh9uJmgs-ZOQ@mail.gmail.com>
Hi Doug,
Am Donnerstag, 21. Mai 2015, 08:40:55 schrieb Doug Anderson:
> On Wed, May 20, 2015 at 7:02 PM, Huang, Tao <huangtao@rock-chips.com> wrote:
> >> It turns out that's not a safe assumption. In some cases (pending
> >> interrupts) it's possible that the WFI might act as a no-op and the
> >> MaskROM will never run.
> > Anyway, restore the value is okay, which make the code more symmetrically
>
> OK. Heiko: applying this won't hurt, but it will only be useful if we
> find a way to return from the WFI successfully...
As it looks sane but doesn't fix an immediate problem I have applied this to my
soc-branch for 4.2 .
Thanks
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: rockchip: restore dapswjdp after suspend
Date: Thu, 21 May 2015 19:59:13 +0200 [thread overview]
Message-ID: <2799695.KoAD3Q19Xm@phil> (raw)
In-Reply-To: <CAD=FV=XARAYzLWy+i9f1XuTZTa4RiA5Yb9aJoAuh9uJmgs-ZOQ@mail.gmail.com>
Hi Doug,
Am Donnerstag, 21. Mai 2015, 08:40:55 schrieb Doug Anderson:
> On Wed, May 20, 2015 at 7:02 PM, Huang, Tao <huangtao@rock-chips.com> wrote:
> >> It turns out that's not a safe assumption. In some cases (pending
> >> interrupts) it's possible that the WFI might act as a no-op and the
> >> MaskROM will never run.
> > Anyway, restore the value is okay, which make the code more symmetrically
>
> OK. Heiko: applying this won't hurt, but it will only be useful if we
> find a way to return from the WFI successfully...
As it looks sane but doesn't fix an immediate problem I have applied this to my
soc-branch for 4.2 .
Thanks
Heiko
next prev parent reply other threads:[~2015-05-21 17:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 20:34 [PATCH] ARM: rockchip: restore dapswjdp after suspend Doug Anderson
2015-05-20 20:34 ` Doug Anderson
2015-05-21 0:45 ` Chris Zhong
2015-05-21 0:45 ` Chris Zhong
2015-05-21 2:02 ` Huang, Tao
2015-05-21 2:02 ` Huang, Tao
2015-05-21 15:40 ` Doug Anderson
2015-05-21 15:40 ` Doug Anderson
2015-05-21 15:40 ` Doug Anderson
2015-05-21 17:59 ` Heiko Stuebner [this message]
2015-05-21 17:59 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2799695.KoAD3Q19Xm@phil \
--to=heiko@sntech.de \
--cc=dianders@chromium.org \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=tony.xie@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.