[GIT PULL v2] Intel Image Processing Unit 6 firmware

[GIT PULL v2] Intel Image Processing Unit 6 firmware

[Sakari Ailus]

Hi folks,

This PR moves Intel IPU firmware files under ipu subdirectory for easier
packaging. WHENCE is updated for IPU3 ImgU firmware links.

since v1:

- Rebase on the Gitlab repository main branch. The one in git.kernel.org
  was not up to date. :-(

Please pull.


The following changes since commit 8acf0a98dbe1606cf696b0ee61bcce7eed5db80f:

  Merge branch 'robot/patch-10-1707787255' into 'main' (2024-02-13 01:31:56 +0000)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/sailus/linux-firmware.git tags/ipu6-2024-02-14-2

for you to fetch changes up to 08ab13d5d079c90dc21145710a2cc42326562aee:

  Intel IPU3 ImgU: Move firmware file under intel/ipu (2024-02-14 10:37:57 +0200)

----------------------------------------------------------------
Move IPU firmware under ipu

----------------------------------------------------------------
Sakari Ailus (2):
      Intel IPU6: Move firmware binaries under ipu/
      Intel IPU3 ImgU: Move firmware file under intel/ipu

 WHENCE                                                   |  15 ++++++++-------
 intel/{ => ipu}/ipu6_fw.bin                              | Bin
 intel/{ => ipu}/ipu6ep_fw.bin                            | Bin
 intel/{ => ipu}/ipu6epadln_fw.bin                        | Bin
 intel/{ => ipu}/ipu6epmtl_fw.bin                         | Bin
 intel/{ => ipu}/ipu6se_fw.bin                            | Bin
 .../irci_irci_ecr-master_20161208_0213_20170112_1500.bin | Bin
 7 files changed, 8 insertions(+), 7 deletions(-)
 rename intel/{ => ipu}/ipu6_fw.bin (100%)
 rename intel/{ => ipu}/ipu6ep_fw.bin (100%)
 rename intel/{ => ipu}/ipu6epadln_fw.bin (100%)
 rename intel/{ => ipu}/ipu6epmtl_fw.bin (100%)
 rename intel/{ => ipu}/ipu6se_fw.bin (100%)
 rename intel/{ => ipu}/irci_irci_ecr-master_20161208_0213_20170112_1500.bin (100%)

-- 
Sakari Ailus

Re: [GIT PULL v2] Intel Image Processing Unit 6 firmware

[Hans de Goede]

Hi,

On 2/14/24 09:40, Sakari Ailus wrote:
> Hi folks,
> 
> This PR moves Intel IPU firmware files under ipu subdirectory for easier
> packaging. WHENCE is updated for IPU3 ImgU firmware links.
> 
> since v1:
> 
> - Rebase on the Gitlab repository main branch. The one in git.kernel.org
>   was not up to date. :-(
> 
> Please pull.

Just a quick note for the linux-firmware maintainers, no compat
symlinks are added for the ipu6 firmwares since the ipu6 driver
is not upstream yet. So we can just make the driver use the new
firmware paths before merging it upstream.

Regards,

Hans



> 
> 
> The following changes since commit 8acf0a98dbe1606cf696b0ee61bcce7eed5db80f:
> 
>   Merge branch 'robot/patch-10-1707787255' into 'main' (2024-02-13 01:31:56 +0000)
> 
> are available in the Git repository at:
> 
>   https://git.kernel.org/pub/scm/linux/kernel/git/sailus/linux-firmware.git tags/ipu6-2024-02-14-2
> 
> for you to fetch changes up to 08ab13d5d079c90dc21145710a2cc42326562aee:
> 
>   Intel IPU3 ImgU: Move firmware file under intel/ipu (2024-02-14 10:37:57 +0200)
> 
> ----------------------------------------------------------------
> Move IPU firmware under ipu
> 
> ----------------------------------------------------------------
> Sakari Ailus (2):
>       Intel IPU6: Move firmware binaries under ipu/
>       Intel IPU3 ImgU: Move firmware file under intel/ipu
> 
>  WHENCE                                                   |  15 ++++++++-------
>  intel/{ => ipu}/ipu6_fw.bin                              | Bin
>  intel/{ => ipu}/ipu6ep_fw.bin                            | Bin
>  intel/{ => ipu}/ipu6epadln_fw.bin                        | Bin
>  intel/{ => ipu}/ipu6epmtl_fw.bin                         | Bin
>  intel/{ => ipu}/ipu6se_fw.bin                            | Bin
>  .../irci_irci_ecr-master_20161208_0213_20170112_1500.bin | Bin
>  7 files changed, 8 insertions(+), 7 deletions(-)
>  rename intel/{ => ipu}/ipu6_fw.bin (100%)
>  rename intel/{ => ipu}/ipu6ep_fw.bin (100%)
>  rename intel/{ => ipu}/ipu6epadln_fw.bin (100%)
>  rename intel/{ => ipu}/ipu6epmtl_fw.bin (100%)
>  rename intel/{ => ipu}/ipu6se_fw.bin (100%)
>  rename intel/{ => ipu}/irci_irci_ecr-master_20161208_0213_20170112_1500.bin (100%)
> 

Re: [GIT PULL v2] Intel Image Processing Unit 6 firmware

[Bingbu Cao]

Hans And Juerg,

On 2/14/24 4:51 PM, Hans de Goede wrote:
> Hi,
> 
> On 2/14/24 09:40, Sakari Ailus wrote:
>> Hi folks,
>>
>> This PR moves Intel IPU firmware files under ipu subdirectory for easier
>> packaging. WHENCE is updated for IPU3 ImgU firmware links.
>>
>> since v1:
>>
>> - Rebase on the Gitlab repository main branch. The one in git.kernel.org
>>   was not up to date. :-(
>>
>> Please pull.
> 
> Just a quick note for the linux-firmware maintainers, no compat
> symlinks are added for the ipu6 firmwares since the ipu6 driver
> is not upstream yet. So we can just make the driver use the new
> firmware paths before merging it upstream.

We are planning to submit a change to add the compat symlinks for
IPU6 firmwares to support the downstream driver.

Is it fine for you?

> 
> Regards,
> 
> Hans
> 
> 
> 
>>
>>
>> The following changes since commit 8acf0a98dbe1606cf696b0ee61bcce7eed5db80f:
>>
>>   Merge branch 'robot/patch-10-1707787255' into 'main' (2024-02-13 01:31:56 +0000)
>>
>> are available in the Git repository at:
>>
>>   https://git.kernel.org/pub/scm/linux/kernel/git/sailus/linux-firmware.git tags/ipu6-2024-02-14-2
>>
>> for you to fetch changes up to 08ab13d5d079c90dc21145710a2cc42326562aee:
>>
>>   Intel IPU3 ImgU: Move firmware file under intel/ipu (2024-02-14 10:37:57 +0200)
>>
>> ----------------------------------------------------------------
>> Move IPU firmware under ipu
>>
>> ----------------------------------------------------------------
>> Sakari Ailus (2):
>>       Intel IPU6: Move firmware binaries under ipu/
>>       Intel IPU3 ImgU: Move firmware file under intel/ipu
>>
>>  WHENCE                                                   |  15 ++++++++-------
>>  intel/{ => ipu}/ipu6_fw.bin                              | Bin
>>  intel/{ => ipu}/ipu6ep_fw.bin                            | Bin
>>  intel/{ => ipu}/ipu6epadln_fw.bin                        | Bin
>>  intel/{ => ipu}/ipu6epmtl_fw.bin                         | Bin
>>  intel/{ => ipu}/ipu6se_fw.bin                            | Bin
>>  .../irci_irci_ecr-master_20161208_0213_20170112_1500.bin | Bin
>>  7 files changed, 8 insertions(+), 7 deletions(-)
>>  rename intel/{ => ipu}/ipu6_fw.bin (100%)
>>  rename intel/{ => ipu}/ipu6ep_fw.bin (100%)
>>  rename intel/{ => ipu}/ipu6epadln_fw.bin (100%)
>>  rename intel/{ => ipu}/ipu6epmtl_fw.bin (100%)
>>  rename intel/{ => ipu}/ipu6se_fw.bin (100%)
>>  rename intel/{ => ipu}/irci_irci_ecr-master_20161208_0213_20170112_1500.bin (100%)
>>
> 

-- 
Best regards,
Bingbu Cao

Re: [GIT PULL v2] Intel Image Processing Unit 6 firmware

[Hans de Goede]

Hi Bingbu,

On 4/12/24 8:08 AM, Bingbu Cao wrote:
> Hans And Juerg,
> 
> On 2/14/24 4:51 PM, Hans de Goede wrote:
>> Hi,
>>
>> On 2/14/24 09:40, Sakari Ailus wrote:
>>> Hi folks,
>>>
>>> This PR moves Intel IPU firmware files under ipu subdirectory for easier
>>> packaging. WHENCE is updated for IPU3 ImgU firmware links.
>>>
>>> since v1:
>>>
>>> - Rebase on the Gitlab repository main branch. The one in git.kernel.org
>>>   was not up to date. :-(
>>>
>>> Please pull.
>>
>> Just a quick note for the linux-firmware maintainers, no compat
>> symlinks are added for the ipu6 firmwares since the ipu6 driver
>> is not upstream yet. So we can just make the driver use the new
>> firmware paths before merging it upstream.
> 
> We are planning to submit a change to add the compat symlinks for
> IPU6 firmwares to support the downstream driver.
> 
> Is it fine for you?

IMHO it would be better to modify the downstream driver instead.

You can simply make the driver try the new path first and
then fall back to trying the old path if the firmware is
not found at the new path.

Regards,

Hans

Re: [GIT PULL v2] Intel Image Processing Unit 6 firmware

[Sakari Ailus]

Hi Hans,

On Fri, Apr 12, 2024 at 12:30:44PM +0200, Hans de Goede wrote:
> Hi Bingbu,
> 
> On 4/12/24 8:08 AM, Bingbu Cao wrote:
> > Hans And Juerg,
> > 
> > On 2/14/24 4:51 PM, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 2/14/24 09:40, Sakari Ailus wrote:
> >>> Hi folks,
> >>>
> >>> This PR moves Intel IPU firmware files under ipu subdirectory for easier
> >>> packaging. WHENCE is updated for IPU3 ImgU firmware links.
> >>>
> >>> since v1:
> >>>
> >>> - Rebase on the Gitlab repository main branch. The one in git.kernel.org
> >>>   was not up to date. :-(
> >>>
> >>> Please pull.
> >>
> >> Just a quick note for the linux-firmware maintainers, no compat
> >> symlinks are added for the ipu6 firmwares since the ipu6 driver
> >> is not upstream yet. So we can just make the driver use the new
> >> firmware paths before merging it upstream.
> > 
> > We are planning to submit a change to add the compat symlinks for
> > IPU6 firmwares to support the downstream driver.
> > 
> > Is it fine for you?
> 
> IMHO it would be better to modify the downstream driver instead.
> 
> You can simply make the driver try the new path first and
> then fall back to trying the old path if the firmware is
> not found at the new path.

Something similar was done for the IPU3 ImgU driver when the existing
driver already had users. It was in staging at that point but that doesn't
really even matter.

Adding the symlinks wouldn't affect the packaging benefits of the change.

Admittedly I don't have a strong opinion on the matter, this should be
fixable in the downstream driver (which actually was my first thought as
well).

-- 
Regards,

Sakari Ailus

Re: [GIT PULL v2] Intel Image Processing Unit 6 firmware

[Josh Boyer]

On Wed, Feb 14, 2024 at 3:40 AM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> Hi folks,
>
> This PR moves Intel IPU firmware files under ipu subdirectory for easier
> packaging. WHENCE is updated for IPU3 ImgU firmware links.
>
> since v1:
>
> - Rebase on the Gitlab repository main branch. The one in git.kernel.org
>   was not up to date. :-(

There was an issue with the machine doing syncing.  It's been
resolved.  Apologies for the inconvenience.

> Please pull.
>
>
> The following changes since commit 8acf0a98dbe1606cf696b0ee61bcce7eed5db80f:
>
>   Merge branch 'robot/patch-10-1707787255' into 'main' (2024-02-13 01:31:56 +0000)
>
> are available in the Git repository at:
>
>   https://git.kernel.org/pub/scm/linux/kernel/git/sailus/linux-firmware.git tags/ipu6-2024-02-14-2

Merged and pushed out.

https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/152

josh

>
> for you to fetch changes up to 08ab13d5d079c90dc21145710a2cc42326562aee:
>
>   Intel IPU3 ImgU: Move firmware file under intel/ipu (2024-02-14 10:37:57 +0200)
>
> ----------------------------------------------------------------
> Move IPU firmware under ipu
>
> ----------------------------------------------------------------
> Sakari Ailus (2):
>       Intel IPU6: Move firmware binaries under ipu/
>       Intel IPU3 ImgU: Move firmware file under intel/ipu
>
>  WHENCE                                                   |  15 ++++++++-------
>  intel/{ => ipu}/ipu6_fw.bin                              | Bin
>  intel/{ => ipu}/ipu6ep_fw.bin                            | Bin
>  intel/{ => ipu}/ipu6epadln_fw.bin                        | Bin
>  intel/{ => ipu}/ipu6epmtl_fw.bin                         | Bin
>  intel/{ => ipu}/ipu6se_fw.bin                            | Bin
>  .../irci_irci_ecr-master_20161208_0213_20170112_1500.bin | Bin
>  7 files changed, 8 insertions(+), 7 deletions(-)
>  rename intel/{ => ipu}/ipu6_fw.bin (100%)
>  rename intel/{ => ipu}/ipu6ep_fw.bin (100%)
>  rename intel/{ => ipu}/ipu6epadln_fw.bin (100%)
>  rename intel/{ => ipu}/ipu6epmtl_fw.bin (100%)
>  rename intel/{ => ipu}/ipu6se_fw.bin (100%)
>  rename intel/{ => ipu}/irci_irci_ecr-master_20161208_0213_20170112_1500.bin (100%)
>
> --
> Sakari Ailus

Re: [GIT PULL v2] Intel Image Processing Unit 6 firmware

[Sakari Ailus]

On Mon, Feb 19, 2024 at 07:50:10AM -0500, Josh Boyer wrote:
> On Wed, Feb 14, 2024 at 3:40 AM Sakari Ailus
> <sakari.ailus@linux.intel.com> wrote:
> >
> > Hi folks,
> >
> > This PR moves Intel IPU firmware files under ipu subdirectory for easier
> > packaging. WHENCE is updated for IPU3 ImgU firmware links.
> >
> > since v1:
> >
> > - Rebase on the Gitlab repository main branch. The one in git.kernel.org
> >   was not up to date. :-(
> 
> There was an issue with the machine doing syncing.  It's been
> resolved.  Apologies for the inconvenience.

Ack. No problem.

> 
> > Please pull.
> >
> >
> > The following changes since commit 8acf0a98dbe1606cf696b0ee61bcce7eed5db80f:
> >
> >   Merge branch 'robot/patch-10-1707787255' into 'main' (2024-02-13 01:31:56 +0000)
> >
> > are available in the Git repository at:
> >
> >   https://git.kernel.org/pub/scm/linux/kernel/git/sailus/linux-firmware.git tags/ipu6-2024-02-14-2
> 
> Merged and pushed out.
> 
> https://gitlab.com/kernel-firmware/linux-firmware/-/merge_requests/152

Thanks, Josh!

-- 
Sakari Ailus