From: Luka Gejak <luka.gejak@linux.dev>
To: linux-wireless@vger.kernel.org,
Leonard Lausen <leonard@lausen.nl>,
Ping-Ke Shih <pkshih@realtek.com>
Cc: leonard@lausen.nl, Shawn Lin <shawn.lin@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] wifi: rtw88: reduce RTL8822CS SDIO request overhead
Date: Sun, 15 Nov 2026 19:26:25 +0100 [thread overview]
Message-ID: <27B2AC6E-6293-4287-B966-986AF8C0CABE@linux.dev> (raw)
In-Reply-To: <20261115142330.359247-2-leonard@lausen.nl>
Hi Leonard,
On November 15, 2026 3:23:28 PM GMT+01:00, Leonard Lausen
<leonard@lausen.nl> wrote:
>Reduce SDIO request overhead by filtering hardware-handled control
>frames and combining adjacent TX-capacity reads.
>
>RTL8822CS on NanoPi M5, median TCP Mbit/s:
>
> Upload Download
> Neither patch 170.4 241.2
> Filtering only 258.2 263.3
> Combined register reads only 186.5 261.6
> Both patches 286.9 273.5
>
>Together the patches improved median upload by 68% and download by 13.4%.
>Upload and download were measured in separate sessions, with four
>20-second upload samples and four 30-second download samples per
>configuration. Testing used a shared Wi-Fi network, so throughput can
>vary.
>
>Runtime baseline: v7.4-rc2 plus the RX-bounds fix accepted in rtw-next
>(83ca360e85280) and the MMC voltage-switch fixes in linux-next
Series targeted for rtw-next should be based on rtw-next, unless there is
a good reason for doing otherwise.
>(67a97316a31a3, a3838c21e28e5). All variants use stock MMC host limits,
>198 MHz SDR104, performance governors and identical CPU placement:
>SDIO IRQ on CPU4, iperf client on CPU6, server on CPU7. Traffic crosses
>Wi-Fi/AP/Ethernet between two endpoints on the board.
>
>All 20 configured rtw88 modules built with W=1. Sanitized function models
>cover credit-read errors, fallback and buffer ownership. Module IDs,
>filter registers, traffic paths and kernel logs were checked. AP/monitor,
>suspend/resume and other-chip hardware remain untested.
>
>AI assistance: Codex inspected sources, developed the changes and
>messages,
>and automated validation. Prompts requested small optimizations measured
>individually and together, with explicit prerequisite and impact checks.
>
>Leonard Lausen (2):
> wifi: rtw88: 8822c: filter hardware-handled control frames on SDIO
> wifi: rtw88: sdio: combine free TX page register reads
>
> drivers/net/wireless/realtek/rtw88/reg.h | 4 ++
> drivers/net/wireless/realtek/rtw88/rtw8822c.c | 9 +++
> drivers/net/wireless/realtek/rtw88/sdio.c | 58 +++++++++++++++++--
> drivers/net/wireless/realtek/rtw88/sdio.h | 1 +
> 4 files changed, 68 insertions(+), 4 deletions(-)
>
>base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
Can you resend this properly, as v2, as resending singular patches is not
encouraged?
For the actual patches:
Read Documentation/process/coding-style.rst and
apply what you learn in there to all patches. Furthermore Assisted-by tag
is deprecated and should be removed, which you would have seen if you had
ran checkpatch on your patches. Address these and other style issues and I
will review v2, as I don't have time right now.
Best regards,
Luka Gejak
WARNING: multiple messages have this Message-ID (diff)
From: Luka Gejak <luka.gejak@linux.dev>
To: linux-wireless@vger.kernel.org,
Leonard Lausen <leonard@lausen.nl>,
Ping-Ke Shih <pkshih@realtek.com>
Cc: leonard@lausen.nl, Shawn Lin <shawn.lin@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] wifi: rtw88: reduce RTL8822CS SDIO request overhead
Date: Sun, 15 Nov 2026 19:26:25 +0100 [thread overview]
Message-ID: <27B2AC6E-6293-4287-B966-986AF8C0CABE@linux.dev> (raw)
In-Reply-To: <20261115142330.359247-2-leonard@lausen.nl>
Hi Leonard,
On November 15, 2026 3:23:28 PM GMT+01:00, Leonard Lausen
<leonard@lausen.nl> wrote:
>Reduce SDIO request overhead by filtering hardware-handled control
>frames and combining adjacent TX-capacity reads.
>
>RTL8822CS on NanoPi M5, median TCP Mbit/s:
>
> Upload Download
> Neither patch 170.4 241.2
> Filtering only 258.2 263.3
> Combined register reads only 186.5 261.6
> Both patches 286.9 273.5
>
>Together the patches improved median upload by 68% and download by 13.4%.
>Upload and download were measured in separate sessions, with four
>20-second upload samples and four 30-second download samples per
>configuration. Testing used a shared Wi-Fi network, so throughput can
>vary.
>
>Runtime baseline: v7.4-rc2 plus the RX-bounds fix accepted in rtw-next
>(83ca360e85280) and the MMC voltage-switch fixes in linux-next
Series targeted for rtw-next should be based on rtw-next, unless there is
a good reason for doing otherwise.
>(67a97316a31a3, a3838c21e28e5). All variants use stock MMC host limits,
>198 MHz SDR104, performance governors and identical CPU placement:
>SDIO IRQ on CPU4, iperf client on CPU6, server on CPU7. Traffic crosses
>Wi-Fi/AP/Ethernet between two endpoints on the board.
>
>All 20 configured rtw88 modules built with W=1. Sanitized function models
>cover credit-read errors, fallback and buffer ownership. Module IDs,
>filter registers, traffic paths and kernel logs were checked. AP/monitor,
>suspend/resume and other-chip hardware remain untested.
>
>AI assistance: Codex inspected sources, developed the changes and
>messages,
>and automated validation. Prompts requested small optimizations measured
>individually and together, with explicit prerequisite and impact checks.
>
>Leonard Lausen (2):
> wifi: rtw88: 8822c: filter hardware-handled control frames on SDIO
> wifi: rtw88: sdio: combine free TX page register reads
>
> drivers/net/wireless/realtek/rtw88/reg.h | 4 ++
> drivers/net/wireless/realtek/rtw88/rtw8822c.c | 9 +++
> drivers/net/wireless/realtek/rtw88/sdio.c | 58 +++++++++++++++++--
> drivers/net/wireless/realtek/rtw88/sdio.h | 1 +
> 4 files changed, 68 insertions(+), 4 deletions(-)
>
>base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
Can you resend this properly, as v2, as resending singular patches is not
encouraged?
For the actual patches:
Read Documentation/process/coding-style.rst and
apply what you learn in there to all patches. Furthermore Assisted-by tag
is deprecated and should be removed, which you would have seen if you had
ran checkpatch on your patches. Address these and other style issues and I
will review v2, as I don't have time right now.
Best regards,
Luka Gejak
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-11-15 18:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 14:23 [PATCH 0/2] wifi: rtw88: reduce RTL8822CS SDIO request overhead Leonard Lausen
2026-11-15 14:23 ` Leonard Lausen
2026-11-15 14:23 ` [PATCH 1/2] wifi: rtw88: 8822c: filter hardware-handled control frames on SDIO Leonard Lausen
2026-11-15 14:23 ` Leonard Lausen
2026-11-15 14:29 ` Leonard Lausen
2026-11-15 14:29 ` Leonard Lausen
2026-11-15 14:23 ` [PATCH 2/2] wifi: rtw88: sdio: combine free TX page register reads Leonard Lausen
2026-11-15 14:23 ` Leonard Lausen
2026-11-15 18:26 ` Luka Gejak [this message]
2026-11-15 18:26 ` [PATCH 0/2] wifi: rtw88: reduce RTL8822CS SDIO request overhead Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27B2AC6E-6293-4287-B966-986AF8C0CABE@linux.dev \
--to=luka.gejak@linux.dev \
--cc=heiko@sntech.de \
--cc=leonard@lausen.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.