All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Quentin Schulz <foss+kernel@0leil.net>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH] arm64: dts: rockchip: support camera module on Haikou Video Demo on PX30 Ringneck
Date: Mon, 09 Jun 2025 11:56:54 +0200	[thread overview]
Message-ID: <2806486.NG923GbCHz@phil> (raw)
In-Reply-To: <20250516-ringneck-haikou-video-demo-cam-v1-1-fff23160395f@cherry.de>

Hi Quentin,

Am Freitag, 16. Mai 2025, 19:26:10 Mitteleuropäische Sommerzeit schrieb Quentin Schulz:
> +&isp {
> +	status = "okay";
> +
> +	ports {
> +		port@0 {
> +			mipi_in_cam: endpoint@0 {
> +				reg = <0>;
> +				data-lanes = <1 2>;
> +				remote-endpoint = <&cam_out>;
> +			};
> +		};
> +	};
>  };

dtc is quite unhappy about this construct ;-) .

with a W=1 build option when compiling DTBs we end up with a number
of complaints about missing and/or unneeded address-cells/size-cells
or "only one endpoint, @0 not necessary".

I think it would make sense to give the isp port a phandle in the
px30.dtsi and reference that one here - similar to how the dsi-panel
works.




WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Quentin Schulz <foss+kernel@0leil.net>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Quentin Schulz <quentin.schulz@cherry.de>
Subject: Re: [PATCH] arm64: dts: rockchip: support camera module on Haikou Video Demo on PX30 Ringneck
Date: Mon, 09 Jun 2025 11:56:54 +0200	[thread overview]
Message-ID: <2806486.NG923GbCHz@phil> (raw)
In-Reply-To: <20250516-ringneck-haikou-video-demo-cam-v1-1-fff23160395f@cherry.de>

Hi Quentin,

Am Freitag, 16. Mai 2025, 19:26:10 Mitteleuropäische Sommerzeit schrieb Quentin Schulz:
> +&isp {
> +	status = "okay";
> +
> +	ports {
> +		port@0 {
> +			mipi_in_cam: endpoint@0 {
> +				reg = <0>;
> +				data-lanes = <1 2>;
> +				remote-endpoint = <&cam_out>;
> +			};
> +		};
> +	};
>  };

dtc is quite unhappy about this construct ;-) .

with a W=1 build option when compiling DTBs we end up with a number
of complaints about missing and/or unneeded address-cells/size-cells
or "only one endpoint, @0 not necessary".

I think it would make sense to give the isp port a phandle in the
px30.dtsi and reference that one here - similar to how the dsi-panel
works.



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-06-09 10:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16 17:26 [PATCH] arm64: dts: rockchip: support camera module on Haikou Video Demo on PX30 Ringneck Quentin Schulz
2025-05-16 17:26 ` Quentin Schulz
2025-06-09  9:56 ` Heiko Stuebner [this message]
2025-06-09  9:56   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2806486.NG923GbCHz@phil \
    --to=heiko@sntech.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=foss+kernel@0leil.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=quentin.schulz@cherry.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.