All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org, "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH] 9pfs: log warning if msize <= 8192
Date: Wed, 02 Sep 2020 16:08:48 +0200	[thread overview]
Message-ID: <2812056.Ea3xXQFrjv@silver> (raw)
In-Reply-To: <20200902134503.GJ403297@redhat.com>

On Mittwoch, 2. September 2020 15:45:03 CEST Daniel P. Berrangé wrote:
> To be clear, I'm not objecting to warning - just that the proposed warning
> doesn't give any useful information about what is considered to be a
> sensible alternative size, and nor does the commit message.
> 
> Just like to see the commit message provide the background info above,
> and ideally have the warning message at least give the user a suggestion
> that is in the sensible order of magnitude they should be looking at.
> 
> eg tell them to aim for 1 MB (or whatever value) as a starting point to
> tuning.

Yeah, I know, but the problem is I don't see how I would squeeze the relevant 
information into only one log message; and even "what's a good starting point" 
is already questionable.

For that reason my plan was:

	- logging this warning

	- describing the 'msize' issue in detail on the QEMU wiki (what's the 
	  point, how would you benchmark it)

So my idea was: user sees the message, "what is 'msize?'" -> Google "msize 
qemu" -> click 'QEMU wiki' -> read all the details.

But how about this: I put a QEMU wiki link directly into the log message?

P.S. I don't have a QEMU wiki account yet BTW, so if somebody could hook me 
up, very much appreciated!

Best regards,
Christian Schoenebeck




  reply	other threads:[~2020-09-02 14:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-02 11:22 [PATCH] 9pfs: log warning if msize <= 8192 Christian Schoenebeck
2020-09-02 12:25 ` Daniel P. Berrangé
2020-09-02 12:52   ` Christian Schoenebeck
2020-09-02 13:39     ` Greg Kurz
2020-09-02 13:45       ` Daniel P. Berrangé
2020-09-02 14:08         ` Christian Schoenebeck [this message]
2020-09-02 14:10           ` Daniel P. Berrangé
2020-09-02 16:03             ` Christian Schoenebeck
2020-09-02 16:08               ` Daniel P. Berrangé
2020-09-02 16:54               ` Greg Kurz
2020-09-03  8:20                 ` Christian Schoenebeck
2020-09-03  9:35                   ` Greg Kurz
2020-09-03 10:57                     ` Christian Schoenebeck
2020-09-02 13:58       ` Christian Schoenebeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2812056.Ea3xXQFrjv@silver \
    --to=qemu_oss@crudebyte.com \
    --cc=berrange@redhat.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.