All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Michael Turquette <mturquette@baylibre.com>, kishon@ti.com
Cc: sboyd@codeaurora.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	dianders@chromium.org, romain.perier@gmail.com, arnd@arndb.de
Subject: Re: [PATCH 5/8] clk: rockchip: fix usbphy-related clocks
Date: Sat, 05 Dec 2015 11:12:55 +0100	[thread overview]
Message-ID: <2813307.eVUP6EkfG2@diego> (raw)
In-Reply-To: <56622abb9f53f_650d3fc0582a72d85a@quark.notmuch>

Hi Mike

Am Freitag, 4. Dezember 2015, 16:07:23 schrieb Michael Turquette:
> Heiko Stuebner wrote:
> > The otgphy clocks really only drive the phy blocks. These in turn
> > contain plls that then generate the 480m clocks the clock controller
> > uses to supply some other clocks like uart0, gpu or the video-codec.
> > 
> > So fix this structure to actually respect that hirarchy and removed
> > that usb480m fixed-rate clock working as a placeholder till now, as
> > this wouldn't even work if the supplying phy gets turned off while
> > its pll-output gets used elsewhere.
> > 
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> Acked-by: Michael Turquette <mturquette@baylibre.com>

Thanks for Ack + Review, but it seems you found a slightly old version in your 
inbox :-)

So right new we have,

- [PATCH 5/8] clk: rockchip: fix usbphy-related clocks
Acked-by: Michael Turquette <mturquette@baylibre.com>
- [PATCH 6/8] ARM: dts: rockchip: add clock-cells for usb phy nodes
Reviewed-by: Michael Turquette <mturquette@baylibre.com>


which should translate nicely to the two equivalent patches in v3:
[PATCH v3 6/8] ARM: dts: rockchip: add clock-cells for usb phy nodes
[PATCH v3 7/8] clk: rockchip: fix usbphy-related clocks


but I guess Kishon, was also looking for an Ack on the usbphy-code actually 
exposing these clocks in
[PATCH v3 5/8] phy: rockchip-usb: expose the phy-internal PLLs


If you could also take a look at that patch, I would be glad :-)


Thanks
Heiko

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] clk: rockchip: fix usbphy-related clocks
Date: Sat, 05 Dec 2015 11:12:55 +0100	[thread overview]
Message-ID: <2813307.eVUP6EkfG2@diego> (raw)
In-Reply-To: <56622abb9f53f_650d3fc0582a72d85a@quark.notmuch>

Hi Mike

Am Freitag, 4. Dezember 2015, 16:07:23 schrieb Michael Turquette:
> Heiko Stuebner wrote:
> > The otgphy clocks really only drive the phy blocks. These in turn
> > contain plls that then generate the 480m clocks the clock controller
> > uses to supply some other clocks like uart0, gpu or the video-codec.
> > 
> > So fix this structure to actually respect that hirarchy and removed
> > that usb480m fixed-rate clock working as a placeholder till now, as
> > this wouldn't even work if the supplying phy gets turned off while
> > its pll-output gets used elsewhere.
> > 
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> Acked-by: Michael Turquette <mturquette@baylibre.com>

Thanks for Ack + Review, but it seems you found a slightly old version in your 
inbox :-)

So right new we have,

- [PATCH 5/8] clk: rockchip: fix usbphy-related clocks
Acked-by: Michael Turquette <mturquette@baylibre.com>
- [PATCH 6/8] ARM: dts: rockchip: add clock-cells for usb phy nodes
Reviewed-by: Michael Turquette <mturquette@baylibre.com>


which should translate nicely to the two equivalent patches in v3:
[PATCH v3 6/8] ARM: dts: rockchip: add clock-cells for usb phy nodes
[PATCH v3 7/8] clk: rockchip: fix usbphy-related clocks


but I guess Kishon, was also looking for an Ack on the usbphy-code actually 
exposing these clocks in
[PATCH v3 5/8] phy: rockchip-usb: expose the phy-internal PLLs


If you could also take a look at that patch, I would be glad :-)


Thanks
Heiko

  reply	other threads:[~2015-12-05 10:12 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-04 21:44 [PATCH 0/8] phy: rockchip-usb: correct pll handling and usb-uart Heiko Stuebner
2015-11-04 21:44 ` Heiko Stuebner
2015-11-04 21:44 ` [PATCH 1/8] phy: rockchip-usb: fix clock get-put mismatch Heiko Stuebner
2015-11-04 21:44   ` Heiko Stuebner
2015-11-04 23:34   ` Doug Anderson
2015-11-04 23:34     ` Doug Anderson
     [not found]   ` <1446673454-9529-2-git-send-email-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2015-11-13  6:28     ` Kishon Vijay Abraham I
2015-11-13  6:28       ` Kishon Vijay Abraham I
2015-11-13  6:28       ` Kishon Vijay Abraham I
2015-11-04 21:44 ` [PATCH 2/8] phy: rockchip-usb: introduce a common data-struct for the device Heiko Stuebner
2015-11-04 21:44   ` Heiko Stuebner
2015-11-04 23:46   ` Doug Anderson
2015-11-04 23:46     ` Doug Anderson
2015-11-04 23:55     ` Heiko Stuebner
2015-11-04 23:55       ` Heiko Stuebner
2015-11-04 21:44 ` [PATCH 3/8] phy: rockchip-usb: move per-phy init into a separate function Heiko Stuebner
2015-11-04 21:44   ` Heiko Stuebner
2015-11-04 23:53   ` Doug Anderson
2015-11-04 23:53     ` Doug Anderson
2015-11-04 21:44 ` [PATCH 5/8] clk: rockchip: fix usbphy-related clocks Heiko Stuebner
2015-11-04 21:44   ` Heiko Stuebner
     [not found]   ` <1446673454-9529-6-git-send-email-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2015-12-05  0:07     ` Michael Turquette
2015-12-05  0:07       ` Michael Turquette
2015-12-05  0:07       ` Michael Turquette
2015-12-05 10:12       ` Heiko Stübner [this message]
2015-12-05 10:12         ` Heiko Stübner
2015-11-04 21:44 ` [PATCH 6/8] ARM: dts: rockchip: add clock-cells for usb phy nodes Heiko Stuebner
2015-11-04 21:44   ` Heiko Stuebner
2015-11-04 21:44   ` Heiko Stuebner
2015-12-05  0:07   ` Michael Turquette
2015-12-05  0:07     ` Michael Turquette
2015-12-05  0:07     ` Michael Turquette
     [not found] ` <1446673454-9529-1-git-send-email-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2015-11-04 21:44   ` [PATCH 4/8] phy: rockchip-usb: expose the phy-internal PLLs Heiko Stuebner
2015-11-04 21:44     ` Heiko Stuebner
2015-11-04 21:44     ` Heiko Stuebner
     [not found]     ` <1446673454-9529-5-git-send-email-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2015-11-13  8:48       ` Kishon Vijay Abraham I
2015-11-13  8:48         ` Kishon Vijay Abraham I
2015-11-13  8:48         ` Kishon Vijay Abraham I
2015-11-04 21:44   ` [PATCH 7/8] ARM: dts: rockchip: assign usbphy480m_src to the new usbphy pll on veyron Heiko Stuebner
2015-11-04 21:44     ` Heiko Stuebner
2015-11-04 21:44     ` Heiko Stuebner
2015-11-04 21:44 ` [PATCH 8/8] phy: rockchip-usb: add handler for usb-uart functionality Heiko Stuebner
2015-11-04 21:44   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2813307.eVUP6EkfG2@diego \
    --to=heiko@sntech.de \
    --cc=arnd@arndb.de \
    --cc=dianders@chromium.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=romain.perier@gmail.com \
    --cc=sboyd@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.