From: Heiko Stuebner <heiko@sntech.de>
To: Tony Xie <tony.xie@rock-chips.com>
Cc: broonie@kernel.org, lee.jones@linaro.org, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, sboyd@kernel.org,
linux-clk@vger.kernel.org, linux-rtc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, chenjh@rock-chips.com,
xsf@rock-chips.com, zhangqing@rock-chips.com,
huangtao@rock-chips.com
Subject: Re: [PATCH v2 3/5] dt-bindings: mfd: rk808: Add binding informations for RK809 and RK817.
Date: Thu, 02 Aug 2018 13:16:18 +0200 [thread overview]
Message-ID: <2820701.ErqR8ge6r7@phil> (raw)
In-Reply-To: <1533023850-29004-4-git-send-email-tony.xie@rock-chips.com>
Hi Tony,
Am Dienstag, 31. Juli 2018, 09:57:28 CEST schrieb Tony Xie:
> Add device tree bindings documentation for Rockchip's RK809 & RK817 PMIC.
>
> Signed-off-by: Tony Xie <tony.xie@rock-chips.com>
I don't see the devicetree binding maintainers listed in the recipient
list, so adding them in the next iteration might increase your chances
to get an Ack on the binding.
scripts/get_maintainer.pl -f Documentation/devicetree/bindings lists
Rob Herring <robh+dt@kernel.org>
Mark Rutland <mark.rutland@arm.com>
as the main dt maintainers.
[...]
> @@ -99,6 +147,13 @@ number as described in RK818 datasheet.
> - HDMI_SWITCH
> - OTG_SWITCH
>
> +There are three pins needed to config, named "gpio_ts" "gpio_gt" "gpio_slp".
> + The gpio_gt and gpio_ts pins support the gpio function.
> + The gpio_slp pin is for controlling the pmic states, as below:
> + - reset
> + - power down
> + - sleep
> +
Is this common for all rk8xx pmics or just the two new ones?
As the paragraph above makes it sound like these are present on all
and I didn't find mention of them in the datasheets for previous pmics
I have.
Also to me it is not clear in what way these should be used and I didn't
find any mention of them at all in the rest of your series.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Tony Xie <tony.xie-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: linux-rtc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org,
alexandre.belloni-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org,
huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
sboyd-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
zhangqing-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
xsf-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
chenjh-TNX95d0MmH7DzftRWevZcw@public.gmane.org
Subject: Re: [PATCH v2 3/5] dt-bindings: mfd: rk808: Add binding informations for RK809 and RK817.
Date: Thu, 02 Aug 2018 13:16:18 +0200 [thread overview]
Message-ID: <2820701.ErqR8ge6r7@phil> (raw)
In-Reply-To: <1533023850-29004-4-git-send-email-tony.xie-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Hi Tony,
Am Dienstag, 31. Juli 2018, 09:57:28 CEST schrieb Tony Xie:
> Add device tree bindings documentation for Rockchip's RK809 & RK817 PMIC.
>
> Signed-off-by: Tony Xie <tony.xie-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
I don't see the devicetree binding maintainers listed in the recipient
list, so adding them in the next iteration might increase your chances
to get an Ack on the binding.
scripts/get_maintainer.pl -f Documentation/devicetree/bindings lists
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
as the main dt maintainers.
[...]
> @@ -99,6 +147,13 @@ number as described in RK818 datasheet.
> - HDMI_SWITCH
> - OTG_SWITCH
>
> +There are three pins needed to config, named "gpio_ts" "gpio_gt" "gpio_slp".
> + The gpio_gt and gpio_ts pins support the gpio function.
> + The gpio_slp pin is for controlling the pmic states, as below:
> + - reset
> + - power down
> + - sleep
> +
Is this common for all rk8xx pmics or just the two new ones?
As the paragraph above makes it sound like these are present on all
and I didn't find mention of them in the datasheets for previous pmics
I have.
Also to me it is not clear in what way these should be used and I didn't
find any mention of them at all in the rest of your series.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/5] dt-bindings: mfd: rk808: Add binding informations for RK809 and RK817.
Date: Thu, 02 Aug 2018 13:16:18 +0200 [thread overview]
Message-ID: <2820701.ErqR8ge6r7@phil> (raw)
In-Reply-To: <1533023850-29004-4-git-send-email-tony.xie@rock-chips.com>
Hi Tony,
Am Dienstag, 31. Juli 2018, 09:57:28 CEST schrieb Tony Xie:
> Add device tree bindings documentation for Rockchip's RK809 & RK817 PMIC.
>
> Signed-off-by: Tony Xie <tony.xie@rock-chips.com>
I don't see the devicetree binding maintainers listed in the recipient
list, so adding them in the next iteration might increase your chances
to get an Ack on the binding.
scripts/get_maintainer.pl -f Documentation/devicetree/bindings lists
Rob Herring <robh+dt@kernel.org>
Mark Rutland <mark.rutland@arm.com>
as the main dt maintainers.
[...]
> @@ -99,6 +147,13 @@ number as described in RK818 datasheet.
> - HDMI_SWITCH
> - OTG_SWITCH
>
> +There are three pins needed to config, named "gpio_ts" "gpio_gt" "gpio_slp".
> + The gpio_gt and gpio_ts pins support the gpio function.
> + The gpio_slp pin is for controlling the pmic states, as below:
> + - reset
> + - power down
> + - sleep
> +
Is this common for all rk8xx pmics or just the two new ones?
As the paragraph above makes it sound like these are present on all
and I didn't find mention of them in the datasheets for previous pmics
I have.
Also to me it is not clear in what way these should be used and I didn't
find any mention of them at all in the rest of your series.
Heiko
next prev parent reply other threads:[~2018-08-02 13:07 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 7:57 [PATCH v2 0/5] support a new type of PMIC，including two chips(rk817 and rk809) Tony Xie
2018-07-31 7:57 ` Tony Xie
2018-07-31 7:57 ` Tony Xie
2018-07-31 7:57 ` Tony Xie
2018-07-31 7:57 ` [PATCH v2 1/5] mfd: rk808: Add RK817 and RK809 support Tony Xie
2018-07-31 7:57 ` Tony Xie
2018-07-31 7:57 ` [PATCH v2 2/5] regulator: rk808: add RK809 and RK817 support Tony Xie
2018-07-31 7:57 ` Tony Xie
2018-08-01 9:25 ` Mark Brown
2018-08-01 9:25 ` Mark Brown
2018-08-01 9:25 ` Mark Brown
2018-07-31 7:57 ` [PATCH v2 3/5] dt-bindings: mfd: rk808: Add binding informations for RK809 and RK817 Tony Xie
2018-07-31 7:57 ` Tony Xie
2018-08-02 11:16 ` Heiko Stuebner [this message]
2018-08-02 11:16 ` Heiko Stuebner
2018-08-02 11:16 ` Heiko Stuebner
2018-07-31 7:57 ` [PATCH v2 4/5] RTC: RK808: add RK809 and RK817 support Tony Xie
2018-07-31 7:57 ` Tony Xie
2018-07-31 8:10 ` Alexandre Belloni
2018-07-31 8:10 ` Alexandre Belloni
2018-07-31 8:00 ` [PATCH v2 5/5] clk: " Tony Xie
2018-07-31 8:00 ` Tony Xie
2018-08-01 15:18 ` Stephen Boyd
2018-08-01 15:18 ` Stephen Boyd
2018-08-01 15:18 ` Stephen Boyd
2018-08-01 15:18 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2820701.ErqR8ge6r7@phil \
--to=heiko@sntech.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=chenjh@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=huangtao@rock-chips.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tony.xie@rock-chips.com \
--cc=xsf@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.