All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Paul Moore <pmoore@redhat.com>
Cc: Paul Osmialowski <p.osmialowsk@samsung.com>,
	linux-security-module@vger.kernel.org, linux-audit@redhat.com,
	selinux@tycho.nsa.gov
Subject: Re: auditing kdbus service names
Date: Thu, 13 Aug 2015 16:40:52 -0400	[thread overview]
Message-ID: <2836805.Af3VO2DWPn@x2> (raw)
In-Reply-To: <1988863.rx1nHfWkfd@sifl>

On Wednesday, August 12, 2015 10:48:10 PM Paul Moore wrote:
> On Wednesday, August 12, 2015 05:38:14 PM Steve Grubb wrote:
> > On Wednesday, August 12, 2015 08:40:34 AM Paul Moore wrote:
> > > Hello all,
> > > 
> > > I'm currently working on a set of LSM hooks for the new kdbus IPC
> > > mechanism
> > > and one of the things that I believe we will need to add is a new audit
> > > field for the kdbus service name (very similar to the old fashioned dbus
> > > service name).  I was thinking "kdbus_svc" for the field name, any
> > > objections?
> > 
> > What was used on the old dbus events?
> 
> The very generic "service" field name, see the "acquire_svc" example in the
> URL below.  I believe there is some value in picking a new field name since
> 1) the field name is too generic in my opinion and 2) kdbus != dbus.

In my book, they are the same. They are programs providing services on the 
bus. One thing I noticed in the dbus events is that there are a number of user 
controlled fields that are not escaped.

Call it kdbus_svc if you want, but log it untrusted.

Thanks,
-Steve

WARNING: multiple messages have this Message-ID (diff)
From: Steve Grubb <sgrubb@redhat.com>
To: Paul Moore <pmoore@redhat.com>
Cc: linux-audit@redhat.com,
	Paul Osmialowski <p.osmialowsk@samsung.com>,
	linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov
Subject: Re: auditing kdbus service names
Date: Thu, 13 Aug 2015 16:40:52 -0400	[thread overview]
Message-ID: <2836805.Af3VO2DWPn@x2> (raw)
In-Reply-To: <1988863.rx1nHfWkfd@sifl>

On Wednesday, August 12, 2015 10:48:10 PM Paul Moore wrote:
> On Wednesday, August 12, 2015 05:38:14 PM Steve Grubb wrote:
> > On Wednesday, August 12, 2015 08:40:34 AM Paul Moore wrote:
> > > Hello all,
> > > 
> > > I'm currently working on a set of LSM hooks for the new kdbus IPC
> > > mechanism
> > > and one of the things that I believe we will need to add is a new audit
> > > field for the kdbus service name (very similar to the old fashioned dbus
> > > service name).  I was thinking "kdbus_svc" for the field name, any
> > > objections?
> > 
> > What was used on the old dbus events?
> 
> The very generic "service" field name, see the "acquire_svc" example in the
> URL below.  I believe there is some value in picking a new field name since
> 1) the field name is too generic in my opinion and 2) kdbus != dbus.

In my book, they are the same. They are programs providing services on the 
bus. One thing I noticed in the dbus events is that there are a number of user 
controlled fields that are not escaped.

Call it kdbus_svc if you want, but log it untrusted.

Thanks,
-Steve

  reply	other threads:[~2015-08-13 20:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12 12:40 auditing kdbus service names Paul Moore
2015-08-12 21:38 ` Steve Grubb
2015-08-12 21:38   ` Steve Grubb
2015-08-13  2:48   ` Paul Moore
2015-08-13  2:48     ` Paul Moore
2015-08-13 20:40     ` Steve Grubb [this message]
2015-08-13 20:40       ` Steve Grubb
2015-10-01 22:32       ` Paul Moore
2015-10-01 22:32         ` Paul Moore
2015-08-18 15:15 ` Miroslav Grepl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2836805.Af3VO2DWPn@x2 \
    --to=sgrubb@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=p.osmialowsk@samsung.com \
    --cc=pmoore@redhat.com \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.