Re: [meta-oe][PATCH] librelp: fix function inline errors in debug build

["Yash Shinde" <yashinde145@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2181 bytes --]

> 
> 
> 
> Hi Yash,
> 
> 
> 
> 
> 
> 
> 
> First, if we're going to take this approach, you should revert my
> work-around as part of this commit:
> 
> 
> 
> commit ca10312c4c7e88d67f4b487ae9afcbfdf92898d6
> Author:     Randy MacLeod <Randy.MacLeod@...> ( Randy.MacLeod@... )
> Date: Wed Mar 1 19:24:27 2023
> 
> librelp: make inline errors be warnings in debug build
> ...
> 
> 

Will send a v2 if needed.

> 
> 
> 
> BUT...
> 
> 
> 
> The problem isn't so much that the code doesn't get in-lined when doing a
> debug build but
> that it fails to compile.  I think this is a compiler regressions since
> I was not able to reproduce the error when compiling natively using
> Ubuntu-22.04 (gcc-11.3) but
> was able to reproduce it using Fedora-37, gcc --version : gcc (GCC) 12.2.1
> 20221121 (Red Hat 12.2.1-4)
> 
> 
> 
> 
> 
> 
> 
> Does the change you made actually build with the two compiler versions
> above?
> 
> 

I tested the changes in LINCD sources which have GCC 12.2. I didn’t check the above mentioned version.

> 
> 
> 
> 
> Is there documentation that states that
> 
> static inline void
> 
> is not as portable as:
> 
> __attribute__((always_inline))
> static inline void
> 
> 
> 
> 
> 
> I suspect there is not but I'm not a compiler geek!
> 
> 

As you mentioned in https://github.com/rsyslog/librelp/issues/256#issue-1605905115 ( https://github.com/rsyslog/librelp/issues/256#:~:text=Oh%20and%20it%20only%20happens%20when%20using%20%2DOg%20not%20%2DO%5B0%2D3%5D ) , it happens only when complied without any optimization and as per https://gcc.gnu.org/onlinedocs/gcc/Inline.html ( https://gcc.gnu.org/onlinedocs/gcc/Inline.html#:~:text=GCC%20does%20not%20inline,const%20char)%20__attribute__((always_inline))%3B ) it’s mentioned that:

> 
> GCC does not inline any functions when not optimizing unless you specify
> the ‘always_inline’ attribute for the function, like this:
> /* Prototype.  */ inline void foo (const char)
> __attribute__((always_inline));
> 

Please let me know if we are on the same page.

> 
> 
> 
> ../Randy
> 
> 

Regards,

Yash

[-- Attachment #2: Type: text/html, Size: 2682 bytes --]