From: Max Schwarz <max.schwarz@online.de>
To: Chris Zhong <zyw@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org,
Heiko Stuebner <heiko@sntech.de>,
Wolfram Sang <wsa@the-dreams.de>,
dianders@chromium.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i2c-rk3x: move setup to the earlier subsys initcall
Date: Mon, 22 Sep 2014 18:20:20 +0200 [thread overview]
Message-ID: <2856441.ivW6yi69vh@xq-nb> (raw)
In-Reply-To: <7192455.FveG5nGWsJ@xq-nb>
Hi Chris,
> > +subsys_initcall(rk3x_i2c_init_driver);
> > +module_exit(rk3x_i2c_exit_driver);
>
> This means that the driver cannot be used as a loadable module any more,
> right?
>
> In that case, you should probably turn the tristate option in Kconfig into a
> bool.
I'm sorry, I see now that subsys_initcall() gets mapped to module_init() if
the driver is built as a loadable module. Everything is fine ;-)
Acked-By: Max Schwarz <max.schwarz@online.de>
Cheers,
Max
WARNING: multiple messages have this Message-ID (diff)
From: max.schwarz@online.de (Max Schwarz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] i2c-rk3x: move setup to the earlier subsys initcall
Date: Mon, 22 Sep 2014 18:20:20 +0200 [thread overview]
Message-ID: <2856441.ivW6yi69vh@xq-nb> (raw)
In-Reply-To: <7192455.FveG5nGWsJ@xq-nb>
Hi Chris,
> > +subsys_initcall(rk3x_i2c_init_driver);
> > +module_exit(rk3x_i2c_exit_driver);
>
> This means that the driver cannot be used as a loadable module any more,
> right?
>
> In that case, you should probably turn the tristate option in Kconfig into a
> bool.
I'm sorry, I see now that subsys_initcall() gets mapped to module_init() if
the driver is built as a loadable module. Everything is fine ;-)
Acked-By: Max Schwarz <max.schwarz@online.de>
Cheers,
Max
next prev parent reply other threads:[~2014-09-22 16:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 7:24 [PATCH] i2c-rk3x: move setup to the earlier subsys initcall Chris Zhong
2014-09-22 7:24 ` Chris Zhong
2014-09-22 7:24 ` Chris Zhong
[not found] ` <1411370675-27866-1-git-send-email-zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-09-22 16:05 ` Max Schwarz
2014-09-22 16:05 ` Max Schwarz
2014-09-22 16:05 ` Max Schwarz
2014-09-22 16:20 ` Max Schwarz [this message]
2014-09-22 16:20 ` Max Schwarz
2014-09-22 16:22 ` Doug Anderson
2014-09-22 16:22 ` Doug Anderson
2014-09-22 16:22 ` Doug Anderson
[not found] ` <CAD=FV=VUoK8SDng6O4-VVq8UZf88b3bSe-hQMht3R2nmYXqMFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-22 17:13 ` Wolfram Sang
2014-09-22 17:13 ` Wolfram Sang
2014-09-22 17:13 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2856441.ivW6yi69vh@xq-nb \
--to=max.schwarz@online.de \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=wsa@the-dreams.de \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.