From: "Heiko Stübner" <heiko@sntech.de>
To: Yuteng Zhong <zonyitoo@gmail.com>, Rob Herring <robh@kernel.org>
Cc: Peter Geis <pgwipeout@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
DHDAXCW <lasstp5011@gmail.com>
Subject: Re: [PATCH v3 1/2] arm64: dts: rockchip: Add RK3566 LubanCat 1
Date: Thu, 22 Dec 2022 20:10:00 +0100 [thread overview]
Message-ID: <2863440.ElGaqSPkdT@diego> (raw)
In-Reply-To: <20221222172504.GA1741501-robh@kernel.org>
Hi Rob,
Am Donnerstag, 22. Dezember 2022, 18:25:04 CET schrieb Rob Herring:
> On Wed, Dec 21, 2022 at 01:43:07PM +0800, Yuteng Zhong wrote:
> > LubanCat 1 is a Rockchip RK3566 SBC based
> > is developed by EmbedFire Electronics Co., Ltd.
> > Mini Linux Card Type Cheap Computer Development Board
> > It has the following characteristics:
> > - MicroSD card slot, onboard eMMC flash memory
> > - 1GbE Realtek RTL8211F Ethernet Transceiver
> > - 1 USB Type-C port (power and USB2.0 OTG)
> > - 1 USB 3.0 Host port
> > - 3 USB 2.0 Host ports
> > - 1 HDMI
> > - 1 infrared receiver
> > - 1 MIPI DSI
> > - 1 MIPI CSI
> > - 1 x 4-section headphone jack
> > - Mini PCIe socket (USB or PCIe)
> > - 1 SIM Card slot
> > - 1 SYS LED and 1 PWR LED
> > - 40-pin GPIO expansion header
> >
> > Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
> > Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
>
> DHDAXCW is a legal name?
>
> The person sending the patch email should be last.
We're on v7 already [0] and at least the Authorship + separate binding
issue got fixed meanwhile - haven't looked at the whitespace issue there yet.
Heiko
[0] https://lore.kernel.org/all/Y6MlrbGKiIVc6tXt@VM-66-53-centos/
> > ---
> >
> > Changed in V2:
> > - Remove RNG node
> > Changed in V3:
> > - Modify all node names
> >
> > ---
> > .../devicetree/bindings/arm/rockchip.yaml | 5 +
>
> Bindings should be separate patch.
>
> > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > .../boot/dts/rockchip/rk3566-lubancat-1.dts | 600 ++++++++++++++++++
>
> Fix all the whitespace errors checkpatch.pl complains about.
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Yuteng Zhong <zonyitoo@gmail.com>, Rob Herring <robh@kernel.org>
Cc: Peter Geis <pgwipeout@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
DHDAXCW <lasstp5011@gmail.com>
Subject: Re: [PATCH v3 1/2] arm64: dts: rockchip: Add RK3566 LubanCat 1
Date: Thu, 22 Dec 2022 20:10:00 +0100 [thread overview]
Message-ID: <2863440.ElGaqSPkdT@diego> (raw)
In-Reply-To: <20221222172504.GA1741501-robh@kernel.org>
Hi Rob,
Am Donnerstag, 22. Dezember 2022, 18:25:04 CET schrieb Rob Herring:
> On Wed, Dec 21, 2022 at 01:43:07PM +0800, Yuteng Zhong wrote:
> > LubanCat 1 is a Rockchip RK3566 SBC based
> > is developed by EmbedFire Electronics Co., Ltd.
> > Mini Linux Card Type Cheap Computer Development Board
> > It has the following characteristics:
> > - MicroSD card slot, onboard eMMC flash memory
> > - 1GbE Realtek RTL8211F Ethernet Transceiver
> > - 1 USB Type-C port (power and USB2.0 OTG)
> > - 1 USB 3.0 Host port
> > - 3 USB 2.0 Host ports
> > - 1 HDMI
> > - 1 infrared receiver
> > - 1 MIPI DSI
> > - 1 MIPI CSI
> > - 1 x 4-section headphone jack
> > - Mini PCIe socket (USB or PCIe)
> > - 1 SIM Card slot
> > - 1 SYS LED and 1 PWR LED
> > - 40-pin GPIO expansion header
> >
> > Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
> > Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
>
> DHDAXCW is a legal name?
>
> The person sending the patch email should be last.
We're on v7 already [0] and at least the Authorship + separate binding
issue got fixed meanwhile - haven't looked at the whitespace issue there yet.
Heiko
[0] https://lore.kernel.org/all/Y6MlrbGKiIVc6tXt@VM-66-53-centos/
> > ---
> >
> > Changed in V2:
> > - Remove RNG node
> > Changed in V3:
> > - Modify all node names
> >
> > ---
> > .../devicetree/bindings/arm/rockchip.yaml | 5 +
>
> Bindings should be separate patch.
>
> > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > .../boot/dts/rockchip/rk3566-lubancat-1.dts | 600 ++++++++++++++++++
>
> Fix all the whitespace errors checkpatch.pl complains about.
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Yuteng Zhong <zonyitoo@gmail.com>, Rob Herring <robh@kernel.org>
Cc: Peter Geis <pgwipeout@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
DHDAXCW <lasstp5011@gmail.com>
Subject: Re: [PATCH v3 1/2] arm64: dts: rockchip: Add RK3566 LubanCat 1
Date: Thu, 22 Dec 2022 20:10:00 +0100 [thread overview]
Message-ID: <2863440.ElGaqSPkdT@diego> (raw)
In-Reply-To: <20221222172504.GA1741501-robh@kernel.org>
Hi Rob,
Am Donnerstag, 22. Dezember 2022, 18:25:04 CET schrieb Rob Herring:
> On Wed, Dec 21, 2022 at 01:43:07PM +0800, Yuteng Zhong wrote:
> > LubanCat 1 is a Rockchip RK3566 SBC based
> > is developed by EmbedFire Electronics Co., Ltd.
> > Mini Linux Card Type Cheap Computer Development Board
> > It has the following characteristics:
> > - MicroSD card slot, onboard eMMC flash memory
> > - 1GbE Realtek RTL8211F Ethernet Transceiver
> > - 1 USB Type-C port (power and USB2.0 OTG)
> > - 1 USB 3.0 Host port
> > - 3 USB 2.0 Host ports
> > - 1 HDMI
> > - 1 infrared receiver
> > - 1 MIPI DSI
> > - 1 MIPI CSI
> > - 1 x 4-section headphone jack
> > - Mini PCIe socket (USB or PCIe)
> > - 1 SIM Card slot
> > - 1 SYS LED and 1 PWR LED
> > - 40-pin GPIO expansion header
> >
> > Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
> > Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
>
> DHDAXCW is a legal name?
>
> The person sending the patch email should be last.
We're on v7 already [0] and at least the Authorship + separate binding
issue got fixed meanwhile - haven't looked at the whitespace issue there yet.
Heiko
[0] https://lore.kernel.org/all/Y6MlrbGKiIVc6tXt@VM-66-53-centos/
> > ---
> >
> > Changed in V2:
> > - Remove RNG node
> > Changed in V3:
> > - Modify all node names
> >
> > ---
> > .../devicetree/bindings/arm/rockchip.yaml | 5 +
>
> Bindings should be separate patch.
>
> > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > .../boot/dts/rockchip/rk3566-lubancat-1.dts | 600 ++++++++++++++++++
>
> Fix all the whitespace errors checkpatch.pl complains about.
>
next prev parent reply other threads:[~2022-12-22 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 5:43 [PATCH v3 1/2] arm64: dts: rockchip: Add RK3566 LubanCat 1 Yuteng Zhong
2022-12-21 5:43 ` Yuteng Zhong
2022-12-21 5:43 ` Yuteng Zhong
2022-12-22 17:25 ` Rob Herring
2022-12-22 17:25 ` Rob Herring
2022-12-22 17:25 ` Rob Herring
2022-12-22 19:10 ` Heiko Stübner [this message]
2022-12-22 19:10 ` Heiko Stübner
2022-12-22 19:10 ` Heiko Stübner
2022-12-23 2:02 ` ty
2022-12-23 2:02 ` ty
2022-12-23 2:02 ` ty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2863440.ElGaqSPkdT@diego \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lasstp5011@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh@kernel.org \
--cc=zonyitoo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.