From: David Howells <dhowells@redhat.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: dhowells@redhat.com, akpm@linux-foundation.org,
torvalds@osdl.org, Ingo Molnar <mingo@elte.hu>,
Alexander van Heukelum <heukelum@fastmail.fm>,
"H. Peter Anvin" <hpa@linux.intel.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Partially revert patch that encloses asm-offset.h numbers in brackets
Date: Mon, 25 Oct 2010 15:54:25 +0100 [thread overview]
Message-ID: <28707.1288018465@redhat.com> (raw)
In-Reply-To: <4CC5B1A1020000780001EF7C@vpn.id2.novell.com>
Jan Beulich <JBeulich@novell.com> wrote:
> Isn't this a gas bug then? Anywhere you use a plain number you
> should also be permitted to use an expression.
Whoever defined the gas assembly syntax for binutils specified that (N) as an
operand defines an absolute address and N defines an immediate value.
However, prefixing an expression with a unary plus works for me, so adding
this into my patch:
- s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; \
+ s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 +(\2) /* \3 */:; \
Does that work for you?
David
next prev parent reply other threads:[~2010-10-25 14:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 14:02 [PATCH] Partially revert patch that encloses asm-offset.h numbers in brackets David Howells
2010-10-25 14:34 ` Jan Beulich
2010-10-25 14:34 ` Jan Beulich
2010-10-25 14:43 ` Ingo Molnar
2010-10-25 14:54 ` David Howells [this message]
2010-10-25 15:05 ` Jan Beulich
2010-10-25 15:05 ` Jan Beulich
2010-10-25 15:17 ` Linus Torvalds
2010-10-25 15:29 ` Jan Beulich
2010-10-25 15:29 ` Jan Beulich
2010-10-25 15:50 ` H. Peter Anvin
2010-10-25 15:59 ` David Howells
2010-10-25 17:51 ` H. Peter Anvin
2010-10-25 16:16 ` Linus Torvalds
2010-10-25 16:37 ` H. Peter Anvin
2010-10-26 10:53 ` Maciej W. Rozycki
2010-10-26 16:33 ` H. Peter Anvin
2010-10-26 17:34 ` Maciej W. Rozycki
2010-10-31 15:29 ` Alexander van Heukelum
2010-11-02 8:30 ` Ming Lei
2010-11-02 10:19 ` Alexander van Heukelum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28707.1288018465@redhat.com \
--to=dhowells@redhat.com \
--cc=JBeulich@novell.com \
--cc=akpm@linux-foundation.org \
--cc=heukelum@fastmail.fm \
--cc=hpa@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.