All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jan Beulich <JBeulich@novell.com>,
	Alexander van Heukelum <heukelum@fastmail.fm>,
	Ingo Molnar <mingo@elte.hu>,
	akpm@linux-foundation.org, "H. Peter Anvin" <hpa@linux.intel.com>,
	David Howells <dhowells@redhat.com>,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Partially revert patch that encloses asm-offset.h numbers in brackets
Date: Mon, 25 Oct 2010 08:50:32 -0700	[thread overview]
Message-ID: <4CC5A748.6050903@zytor.com> (raw)
In-Reply-To: <AANLkTi=mpKRQgZp5zCoCsBtkuWHrpkOq2Zch-OOGu4CC@mail.gmail.com>

On 10/25/2010 08:17 AM, Linus Torvalds wrote:
> 
> How about just removing the idiotic workaround entirely, and then on
> x86 passing "-traditional" to cpp for asm input so that it doesn't add
> spaces in argument expansion? Make the workaround more targeted to the
> actual problem, rather than working around it in some unrelated
> thing..
> 

We already tried using -traditional, it didn't help the gas braindamage
and it caused severe problems with header files (since -traditional
removes the support for #x and x ## y).  Bringing it back won't help.

As such, the only options I can really think about overriding the sed
expression for x86 or just saying gcc 2.16.90 or later is required...

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

  parent reply	other threads:[~2010-10-25 15:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-25 14:02 [PATCH] Partially revert patch that encloses asm-offset.h numbers in brackets David Howells
2010-10-25 14:34 ` Jan Beulich
2010-10-25 14:34   ` Jan Beulich
2010-10-25 14:43   ` Ingo Molnar
2010-10-25 14:54   ` David Howells
2010-10-25 15:05     ` Jan Beulich
2010-10-25 15:05       ` Jan Beulich
2010-10-25 15:17       ` Linus Torvalds
2010-10-25 15:29         ` Jan Beulich
2010-10-25 15:29           ` Jan Beulich
2010-10-25 15:50         ` H. Peter Anvin [this message]
2010-10-25 15:59           ` David Howells
2010-10-25 17:51             ` H. Peter Anvin
2010-10-25 16:16           ` Linus Torvalds
2010-10-25 16:37             ` H. Peter Anvin
2010-10-26 10:53               ` Maciej W. Rozycki
2010-10-26 16:33                 ` H. Peter Anvin
2010-10-26 17:34                   ` Maciej W. Rozycki
2010-10-31 15:29       ` Alexander van Heukelum
2010-11-02  8:30         ` Ming Lei
2010-11-02 10:19           ` Alexander van Heukelum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CC5A748.6050903@zytor.com \
    --to=hpa@zytor.com \
    --cc=JBeulich@novell.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=heukelum@fastmail.fm \
    --cc=hpa@linux.intel.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.