* [PATCH v2] video: fbdev: matroxfb: use designated initializers @ 2017-01-03 23:24 ` Kees Cook 0 siblings, 0 replies; 4+ messages in thread From: Kees Cook @ 2017-01-03 23:24 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Sudip Mukherjee, Tomi Valkeinen, linux-fbdev, linux-kernel Prepare to mark sensitive kernel structures for randomization by making sure they're using designated initializers. These were identified during allyesconfig builds of x86, arm, and arm64, with most initializer fixes extracted from grsecurity. Signed-off-by: Kees Cook <keescook@chromium.org> --- drivers/video/fbdev/matrox/matroxfb_DAC1064.c | 10 ++++++++-- drivers/video/fbdev/matrox/matroxfb_Ti3026.c | 5 ++++- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c b/drivers/video/fbdev/matrox/matroxfb_DAC1064.c index a01147fdf270..b380a393cbc3 100644 --- a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c +++ b/drivers/video/fbdev/matrox/matroxfb_DAC1064.c @@ -1088,14 +1088,20 @@ static void MGAG100_restore(struct matrox_fb_info *minfo) #ifdef CONFIG_FB_MATROX_MYSTIQUE struct matrox_switch matrox_mystique = { - MGA1064_preinit, MGA1064_reset, MGA1064_init, MGA1064_restore, + .preinit = MGA1064_preinit, + .reset = MGA1064_reset, + .init = MGA1064_init, + .restore = MGA1064_restore, }; EXPORT_SYMBOL(matrox_mystique); #endif #ifdef CONFIG_FB_MATROX_G struct matrox_switch matrox_G100 = { - MGAG100_preinit, MGAG100_reset, MGAG100_init, MGAG100_restore, + .preinit = MGAG100_preinit, + .reset = MGAG100_reset, + .init = MGAG100_init, + .restore = MGAG100_restore, }; EXPORT_SYMBOL(matrox_G100); #endif diff --git a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c index 68fa037d8cbc..9ff9be85759e 100644 --- a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c +++ b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c @@ -738,7 +738,10 @@ static int Ti3026_preinit(struct matrox_fb_info *minfo) } struct matrox_switch matrox_millennium = { - Ti3026_preinit, Ti3026_reset, Ti3026_init, Ti3026_restore + .preinit = Ti3026_preinit, + .reset = Ti3026_reset, + .init = Ti3026_init, + .restore = Ti3026_restore }; EXPORT_SYMBOL(matrox_millennium); #endif -- 2.7.4 -- Kees Cook Nexus Security ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] video: fbdev: matroxfb: use designated initializers @ 2017-01-03 23:24 ` Kees Cook 0 siblings, 0 replies; 4+ messages in thread From: Kees Cook @ 2017-01-03 23:24 UTC (permalink / raw) To: Bartlomiej Zolnierkiewicz Cc: Sudip Mukherjee, Tomi Valkeinen, linux-fbdev, linux-kernel Prepare to mark sensitive kernel structures for randomization by making sure they're using designated initializers. These were identified during allyesconfig builds of x86, arm, and arm64, with most initializer fixes extracted from grsecurity. Signed-off-by: Kees Cook <keescook@chromium.org> --- drivers/video/fbdev/matrox/matroxfb_DAC1064.c | 10 ++++++++-- drivers/video/fbdev/matrox/matroxfb_Ti3026.c | 5 ++++- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c b/drivers/video/fbdev/matrox/matroxfb_DAC1064.c index a01147fdf270..b380a393cbc3 100644 --- a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c +++ b/drivers/video/fbdev/matrox/matroxfb_DAC1064.c @@ -1088,14 +1088,20 @@ static void MGAG100_restore(struct matrox_fb_info *minfo) #ifdef CONFIG_FB_MATROX_MYSTIQUE struct matrox_switch matrox_mystique = { - MGA1064_preinit, MGA1064_reset, MGA1064_init, MGA1064_restore, + .preinit = MGA1064_preinit, + .reset = MGA1064_reset, + .init = MGA1064_init, + .restore = MGA1064_restore, }; EXPORT_SYMBOL(matrox_mystique); #endif #ifdef CONFIG_FB_MATROX_G struct matrox_switch matrox_G100 = { - MGAG100_preinit, MGAG100_reset, MGAG100_init, MGAG100_restore, + .preinit = MGAG100_preinit, + .reset = MGAG100_reset, + .init = MGAG100_init, + .restore = MGAG100_restore, }; EXPORT_SYMBOL(matrox_G100); #endif diff --git a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c index 68fa037d8cbc..9ff9be85759e 100644 --- a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c +++ b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c @@ -738,7 +738,10 @@ static int Ti3026_preinit(struct matrox_fb_info *minfo) } struct matrox_switch matrox_millennium = { - Ti3026_preinit, Ti3026_reset, Ti3026_init, Ti3026_restore + .preinit = Ti3026_preinit, + .reset = Ti3026_reset, + .init = Ti3026_init, + .restore = Ti3026_restore }; EXPORT_SYMBOL(matrox_millennium); #endif -- 2.7.4 -- Kees Cook Nexus Security ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] video: fbdev: matroxfb: use designated initializers 2017-01-03 23:24 ` Kees Cook @ 2017-01-11 12:54 ` Bartlomiej Zolnierkiewicz -1 siblings, 0 replies; 4+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-01-11 12:54 UTC (permalink / raw) To: Kees Cook; +Cc: Sudip Mukherjee, Tomi Valkeinen, linux-fbdev, linux-kernel Hi, On Tuesday, January 03, 2017 03:24:33 PM Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees Cook <keescook@chromium.org> Thanks, queued for 4.11. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/matrox/matroxfb_DAC1064.c | 10 ++++++++-- > drivers/video/fbdev/matrox/matroxfb_Ti3026.c | 5 ++++- > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c b/drivers/video/fbdev/matrox/matroxfb_DAC1064.c > index a01147fdf270..b380a393cbc3 100644 > --- a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c > +++ b/drivers/video/fbdev/matrox/matroxfb_DAC1064.c > @@ -1088,14 +1088,20 @@ static void MGAG100_restore(struct matrox_fb_info *minfo) > > #ifdef CONFIG_FB_MATROX_MYSTIQUE > struct matrox_switch matrox_mystique = { > - MGA1064_preinit, MGA1064_reset, MGA1064_init, MGA1064_restore, > + .preinit = MGA1064_preinit, > + .reset = MGA1064_reset, > + .init = MGA1064_init, > + .restore = MGA1064_restore, > }; > EXPORT_SYMBOL(matrox_mystique); > #endif > > #ifdef CONFIG_FB_MATROX_G > struct matrox_switch matrox_G100 = { > - MGAG100_preinit, MGAG100_reset, MGAG100_init, MGAG100_restore, > + .preinit = MGAG100_preinit, > + .reset = MGAG100_reset, > + .init = MGAG100_init, > + .restore = MGAG100_restore, > }; > EXPORT_SYMBOL(matrox_G100); > #endif > diff --git a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > index 68fa037d8cbc..9ff9be85759e 100644 > --- a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > +++ b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > @@ -738,7 +738,10 @@ static int Ti3026_preinit(struct matrox_fb_info *minfo) > } > > struct matrox_switch matrox_millennium = { > - Ti3026_preinit, Ti3026_reset, Ti3026_init, Ti3026_restore > + .preinit = Ti3026_preinit, > + .reset = Ti3026_reset, > + .init = Ti3026_init, > + .restore = Ti3026_restore > }; > EXPORT_SYMBOL(matrox_millennium); > #endif ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] video: fbdev: matroxfb: use designated initializers @ 2017-01-11 12:54 ` Bartlomiej Zolnierkiewicz 0 siblings, 0 replies; 4+ messages in thread From: Bartlomiej Zolnierkiewicz @ 2017-01-11 12:54 UTC (permalink / raw) To: Kees Cook; +Cc: Sudip Mukherjee, Tomi Valkeinen, linux-fbdev, linux-kernel Hi, On Tuesday, January 03, 2017 03:24:33 PM Kees Cook wrote: > Prepare to mark sensitive kernel structures for randomization by making > sure they're using designated initializers. These were identified during > allyesconfig builds of x86, arm, and arm64, with most initializer fixes > extracted from grsecurity. > > Signed-off-by: Kees Cook <keescook@chromium.org> Thanks, queued for 4.11. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/matrox/matroxfb_DAC1064.c | 10 ++++++++-- > drivers/video/fbdev/matrox/matroxfb_Ti3026.c | 5 ++++- > 2 files changed, 12 insertions(+), 3 deletions(-) > > diff --git a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c b/drivers/video/fbdev/matrox/matroxfb_DAC1064.c > index a01147fdf270..b380a393cbc3 100644 > --- a/drivers/video/fbdev/matrox/matroxfb_DAC1064.c > +++ b/drivers/video/fbdev/matrox/matroxfb_DAC1064.c > @@ -1088,14 +1088,20 @@ static void MGAG100_restore(struct matrox_fb_info *minfo) > > #ifdef CONFIG_FB_MATROX_MYSTIQUE > struct matrox_switch matrox_mystique = { > - MGA1064_preinit, MGA1064_reset, MGA1064_init, MGA1064_restore, > + .preinit = MGA1064_preinit, > + .reset = MGA1064_reset, > + .init = MGA1064_init, > + .restore = MGA1064_restore, > }; > EXPORT_SYMBOL(matrox_mystique); > #endif > > #ifdef CONFIG_FB_MATROX_G > struct matrox_switch matrox_G100 = { > - MGAG100_preinit, MGAG100_reset, MGAG100_init, MGAG100_restore, > + .preinit = MGAG100_preinit, > + .reset = MGAG100_reset, > + .init = MGAG100_init, > + .restore = MGAG100_restore, > }; > EXPORT_SYMBOL(matrox_G100); > #endif > diff --git a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > index 68fa037d8cbc..9ff9be85759e 100644 > --- a/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > +++ b/drivers/video/fbdev/matrox/matroxfb_Ti3026.c > @@ -738,7 +738,10 @@ static int Ti3026_preinit(struct matrox_fb_info *minfo) > } > > struct matrox_switch matrox_millennium = { > - Ti3026_preinit, Ti3026_reset, Ti3026_init, Ti3026_restore > + .preinit = Ti3026_preinit, > + .reset = Ti3026_reset, > + .init = Ti3026_init, > + .restore = Ti3026_restore > }; > EXPORT_SYMBOL(matrox_millennium); > #endif ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-11 12:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20170111125453epcas5p3b7a3a3aecbeac551a9d99e26d1024ccc@epcas5p3.samsung.com>
2017-01-03 23:24 ` [PATCH v2] video: fbdev: matroxfb: use designated initializers Kees Cook
2017-01-03 23:24 ` Kees Cook
2017-01-11 12:54 ` Bartlomiej Zolnierkiewicz
2017-01-11 12:54 ` Bartlomiej Zolnierkiewicz
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.