* [PATCH] ARM: dts: exynos4x12-pinctrl: Correct pin configuration of SD 4
@ 2013-02-11 10:21 ` Shirish S
0 siblings, 0 replies; 6+ messages in thread
From: Shirish S @ 2013-02-11 10:21 UTC (permalink / raw)
To: t.figa, kgene.kim; +Cc: linux-samsung-soc, linux-arm-kernel, Shirish S
This patch corrects the pin function value of sd4_bus8 from 3
to 4.
This is verified on origen board for testing eMMC on
dw_mci controller.
Signed-off-by: Shirish S <s.shirish@samsung.com>
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
index 8e6115a..099cec7 100644
--- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
@@ -661,7 +661,7 @@
sd4_bus8: sd4-bus-width8 {
samsung,pins = "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-6";
- samsung,pin-function = <3>;
+ samsung,pin-function = <4>;
samsung,pin-pud = <4>;
samsung,pin-drv = <3>;
};
--
1.8.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: exynos4x12-pinctrl: Correct pin configuration of SD 4
@ 2013-02-11 10:21 ` Shirish S
0 siblings, 0 replies; 6+ messages in thread
From: Shirish S @ 2013-02-11 10:21 UTC (permalink / raw)
To: linux-arm-kernel
This patch corrects the pin function value of sd4_bus8 from 3
to 4.
This is verified on origen board for testing eMMC on
dw_mci controller.
Signed-off-by: Shirish S <s.shirish@samsung.com>
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
index 8e6115a..099cec7 100644
--- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
+++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
@@ -661,7 +661,7 @@
sd4_bus8: sd4-bus-width8 {
samsung,pins = "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-6";
- samsung,pin-function = <3>;
+ samsung,pin-function = <4>;
samsung,pin-pud = <4>;
samsung,pin-drv = <3>;
};
--
1.8.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: exynos4x12-pinctrl: Correct pin configuration of SD 4
2013-02-11 10:21 ` Shirish S
@ 2013-02-11 10:26 ` Tomasz Figa
-1 siblings, 0 replies; 6+ messages in thread
From: Tomasz Figa @ 2013-02-11 10:26 UTC (permalink / raw)
To: Shirish S; +Cc: kgene.kim, linux-samsung-soc, linux-arm-kernel
On Monday 11 of February 2013 05:21:13 Shirish S wrote:
> This patch corrects the pin function value of sd4_bus8 from 3
> to 4.
> This is verified on origen board for testing eMMC on
> dw_mci controller.
>
> Signed-off-by: Shirish S <s.shirish@samsung.com>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
> arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi index 8e6115a..099cec7
> 100644
> --- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> @@ -661,7 +661,7 @@
>
> sd4_bus8: sd4-bus-width8 {
> samsung,pins = "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-6";
> - samsung,pin-function = <3>;
> + samsung,pin-function = <4>;
> samsung,pin-pud = <4>;
> samsung,pin-drv = <3>;
> };
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: exynos4x12-pinctrl: Correct pin configuration of SD 4
@ 2013-02-11 10:26 ` Tomasz Figa
0 siblings, 0 replies; 6+ messages in thread
From: Tomasz Figa @ 2013-02-11 10:26 UTC (permalink / raw)
To: linux-arm-kernel
On Monday 11 of February 2013 05:21:13 Shirish S wrote:
> This patch corrects the pin function value of sd4_bus8 from 3
> to 4.
> This is verified on origen board for testing eMMC on
> dw_mci controller.
>
> Signed-off-by: Shirish S <s.shirish@samsung.com>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
> arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi index 8e6115a..099cec7
> 100644
> --- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> @@ -661,7 +661,7 @@
>
> sd4_bus8: sd4-bus-width8 {
> samsung,pins = "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-6";
> - samsung,pin-function = <3>;
> + samsung,pin-function = <4>;
> samsung,pin-pud = <4>;
> samsung,pin-drv = <3>;
> };
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards,
--
Tomasz Figa
Samsung Poland R&D Center
SW Solution Development, Linux Platform
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH] ARM: dts: exynos4x12-pinctrl: Correct pin configuration of SD 4
2013-02-11 10:26 ` Tomasz Figa
@ 2013-02-12 18:49 ` Kukjin Kim
-1 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-02-12 18:49 UTC (permalink / raw)
To: 'Tomasz Figa', 'Shirish S'
Cc: linux-samsung-soc, linux-arm-kernel
Tomasz Figa wrote:
>
> On Monday 11 of February 2013 05:21:13 Shirish S wrote:
> > This patch corrects the pin function value of sd4_bus8 from 3
> > to 4.
> > This is verified on origen board for testing eMMC on
> > dw_mci controller.
> >
> > Signed-off-by: Shirish S <s.shirish@samsung.com>
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> > ---
> > arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> > b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi index 8e6115a..099cec7
> > 100644
> > --- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> > +++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> > @@ -661,7 +661,7 @@
> >
> > sd4_bus8: sd4-bus-width8 {
> > samsung,pins = "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-
> 6";
> > - samsung,pin-function = <3>;
> > + samsung,pin-function = <4>;
> > samsung,pin-pud = <4>;
> > samsung,pin-drv = <3>;
> > };
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>
Applied into next/fixes-samsung for v3.9 because this is not a critical bug
fix.
BTW, I'd preferred to use 'ARM: dts: .... for exynos4x12-pinctrl' in subject
because if we use the title like "ARM: dts: exynos4x12-pinctrl: ...", the
main description should be moved back and head of subject is a bit long. So
sometimes we cannot understand the title in the e-mail box before
checking/opening the patch. See below.
Shirish S [PATCH] ARM: dts: exynos4x12-pinctrl: Correct pin...
Mon/2/11/2013 ...
Shirish S [PATCH] ARM: dts: Correct pin configuration of SD...
Mon/2/11/2013 ...
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: exynos4x12-pinctrl: Correct pin configuration of SD 4
@ 2013-02-12 18:49 ` Kukjin Kim
0 siblings, 0 replies; 6+ messages in thread
From: Kukjin Kim @ 2013-02-12 18:49 UTC (permalink / raw)
To: linux-arm-kernel
Tomasz Figa wrote:
>
> On Monday 11 of February 2013 05:21:13 Shirish S wrote:
> > This patch corrects the pin function value of sd4_bus8 from 3
> > to 4.
> > This is verified on origen board for testing eMMC on
> > dw_mci controller.
> >
> > Signed-off-by: Shirish S <s.shirish@samsung.com>
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> > ---
> > arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> > b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi index 8e6115a..099cec7
> > 100644
> > --- a/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> > +++ b/arch/arm/boot/dts/exynos4x12-pinctrl.dtsi
> > @@ -661,7 +661,7 @@
> >
> > sd4_bus8: sd4-bus-width8 {
> > samsung,pins = "gpk1-3", "gpk1-4", "gpk1-5", "gpk1-
> 6";
> > - samsung,pin-function = <3>;
> > + samsung,pin-function = <4>;
> > samsung,pin-pud = <4>;
> > samsung,pin-drv = <3>;
> > };
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>
Applied into next/fixes-samsung for v3.9 because this is not a critical bug
fix.
BTW, I'd preferred to use 'ARM: dts: .... for exynos4x12-pinctrl' in subject
because if we use the title like "ARM: dts: exynos4x12-pinctrl: ...", the
main description should be moved back and head of subject is a bit long. So
sometimes we cannot understand the title in the e-mail box before
checking/opening the patch. See below.
Shirish S [PATCH] ARM: dts: exynos4x12-pinctrl: Correct pin...
Mon/2/11/2013 ...
Shirish S [PATCH] ARM: dts: Correct pin configuration of SD...
Mon/2/11/2013 ...
Thanks.
- Kukjin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-12 18:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-11 10:21 [PATCH] ARM: dts: exynos4x12-pinctrl: Correct pin configuration of SD 4 Shirish S
2013-02-11 10:21 ` Shirish S
2013-02-11 10:26 ` Tomasz Figa
2013-02-11 10:26 ` Tomasz Figa
2013-02-12 18:49 ` Kukjin Kim
2013-02-12 18:49 ` Kukjin Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.