From: Tomasz Figa <t.figa@samsung.com>
To: Kukjin Kim <kgene@kernel.org>
Cc: "'Heiko Stübner'" <heiko@sntech.de>,
mturquette@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
"'Thomas Abraham'" <thomas.abraham@linaro.org>,
"'Russell King'" <linux@arm.linux.org.uk>
Subject: Re: [PATCH v2 6/6] ARM: S3C24XX: Convert s3c2416 and s3c2443 to common clock framework
Date: Wed, 24 Jul 2013 16:01:18 +0200 [thread overview]
Message-ID: <2889437.fCIi7koiPh@amdc1227> (raw)
In-Reply-To: <0ee601ce886d$abb6a690$0323f3b0$@org>
On Wednesday 24 of July 2013 21:59:45 Kukjin Kim wrote:
> Tomasz Figa wrote:
>
> [...]
>
> > > > + timer@51000000 {
> > > > + clocks = <&clocks PCLK_PWM>;
> > >
> > > + clocks = <&clock PCLK_PWM>;
> > >
> > > And I'm not sure using definition PCLK_PWM is better here...
> >
> > Care to explain your doubts about it? I think this is fine.
>
> I mean I don't know why someone use a hard value(number) and someone use
> the definition...
Since preprocessor support for dts files was introduced, definitions are
preferred, wherever possible to specify constants.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/6] ARM: S3C24XX: Convert s3c2416 and s3c2443 to common clock framework
Date: Wed, 24 Jul 2013 16:01:18 +0200 [thread overview]
Message-ID: <2889437.fCIi7koiPh@amdc1227> (raw)
In-Reply-To: <0ee601ce886d$abb6a690$0323f3b0$@org>
On Wednesday 24 of July 2013 21:59:45 Kukjin Kim wrote:
> Tomasz Figa wrote:
>
> [...]
>
> > > > + timer at 51000000 {
> > > > + clocks = <&clocks PCLK_PWM>;
> > >
> > > + clocks = <&clock PCLK_PWM>;
> > >
> > > And I'm not sure using definition PCLK_PWM is better here...
> >
> > Care to explain your doubts about it? I think this is fine.
>
> I mean I don't know why someone use a hard value(number) and someone use
> the definition...
Since preprocessor support for dts files was introduced, definitions are
preferred, wherever possible to specify constants.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-07-24 14:01 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 22:57 [PATCH v2 0/6] Convert S3C2416 ad S3C2443 to common clock framework Heiko Stübner
2013-07-09 22:57 ` Heiko Stübner
2013-07-09 22:57 ` [PATCH v2 1/6] clk: samsung: move common plls registration into separate function Heiko Stübner
2013-07-09 22:57 ` Heiko Stübner
2013-07-10 16:59 ` Yadwinder Singh Brar
2013-07-10 16:59 ` Yadwinder Singh Brar
2013-07-11 7:46 ` Tomasz Figa
2013-07-11 7:46 ` Tomasz Figa
2013-07-11 8:52 ` Heiko Stübner
2013-07-11 8:52 ` Heiko Stübner
2013-08-02 21:35 ` Mike Turquette
2013-08-02 21:35 ` Mike Turquette
2013-07-09 22:58 ` [PATCH v2 2/6] clk: samsung: fix error handling in pll register functions Heiko Stübner
2013-07-09 22:58 ` Heiko Stübner
2013-07-11 7:50 ` Tomasz Figa
2013-07-11 7:50 ` Tomasz Figa
2013-07-09 22:59 ` [PATCH v2 3/6] clk: samsung: add plls used in s3c2416 and s3c2443 Heiko Stübner
2013-07-09 22:59 ` Heiko Stübner
2013-07-11 8:16 ` Tomasz Figa
2013-07-11 8:16 ` Tomasz Figa
2013-07-11 8:50 ` Heiko Stübner
2013-07-11 8:50 ` Heiko Stübner
2013-07-11 9:25 ` Tomasz Figa
2013-07-11 9:25 ` Tomasz Figa
2013-07-09 22:59 ` [PATCH v2 4/6] ARM: S3C24XX: enable legacy clock code only when SAMSUNG_CLOCK selected Heiko Stübner
2013-07-09 22:59 ` Heiko Stübner
2013-07-09 23:00 ` [PATCH v2 5/6] clk: samsung: add clock-driver for s3c2416, s3c2443 and s3c2450 Heiko Stübner
2013-07-09 23:00 ` Heiko Stübner
2013-07-11 9:13 ` Tomasz Figa
2013-07-11 9:13 ` Tomasz Figa
2013-07-09 23:00 ` [PATCH v2 6/6] ARM: S3C24XX: Convert s3c2416 and s3c2443 to common clock framework Heiko Stübner
2013-07-09 23:00 ` Heiko Stübner
2013-07-16 7:09 ` Kukjin Kim
2013-07-16 7:09 ` Kukjin Kim
2013-07-22 17:07 ` Tomasz Figa
2013-07-22 17:07 ` Tomasz Figa
2013-07-24 12:59 ` Kukjin Kim
2013-07-24 12:59 ` Kukjin Kim
2013-07-24 14:01 ` Tomasz Figa [this message]
2013-07-24 14:01 ` Tomasz Figa
2013-08-05 17:03 ` Kukjin Kim
2013-08-05 17:03 ` Kukjin Kim
2013-07-10 8:47 ` [PATCH v2 0/6] Convert S3C2416 ad S3C2443 " Thomas Abraham
2013-07-10 8:47 ` Thomas Abraham
2013-08-05 17:05 ` Kukjin Kim
2013-08-05 17:05 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2889437.fCIi7koiPh@amdc1227 \
--to=t.figa@samsung.com \
--cc=heiko@sntech.de \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@linaro.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.