From: Heiko Stuebner <heiko@sntech.de>
To: Quentin Schulz <foss+kernel@0leil.net>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, jay.xu@rock-chips.com,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
foss+kernel@0leil.net,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: rockchip: add pinmux_ops.gpio_set_direction callback
Date: Fri, 23 Sep 2022 20:14:48 +0200 [thread overview]
Message-ID: <2890748.BddDVKsqQX@phil> (raw)
In-Reply-To: <20220923145141.3463754-2-foss+kernel@0leil.net>
Am Freitag, 23. September 2022, 16:51:40 CEST schrieb Quentin Schulz:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> Before the split of gpio and pinctrl sections in their own driver,
> rockchip_set_mux was called in pinmux_ops.gpio_set_direction for
> configuring a pin in its GPIO function.
>
> This is essential for cases where pinctrl is "bypassed" by gpio
> consumers otherwise the GPIO function is not configured for the pin and
> it does not work. Such was the case for the sysfs/libgpiod userspace
> GPIO handling.
>
> Let's re-implement the pinmux_ops.gpio_set_direction callback so that
> the gpio subsystem can request from the pinctrl driver to put the pin in
> its GPIO function.
>
> Fixes: 9ce9a02039de ("pinctrl/rockchip: drop the gpio related codes")
> Cc: stable@vger.kernel.org
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Quentin Schulz <foss+kernel@0leil.net>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, jay.xu@rock-chips.com,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
foss+kernel@0leil.net,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: rockchip: add pinmux_ops.gpio_set_direction callback
Date: Fri, 23 Sep 2022 20:14:48 +0200 [thread overview]
Message-ID: <2890748.BddDVKsqQX@phil> (raw)
In-Reply-To: <20220923145141.3463754-2-foss+kernel@0leil.net>
Am Freitag, 23. September 2022, 16:51:40 CEST schrieb Quentin Schulz:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> Before the split of gpio and pinctrl sections in their own driver,
> rockchip_set_mux was called in pinmux_ops.gpio_set_direction for
> configuring a pin in its GPIO function.
>
> This is essential for cases where pinctrl is "bypassed" by gpio
> consumers otherwise the GPIO function is not configured for the pin and
> it does not work. Such was the case for the sysfs/libgpiod userspace
> GPIO handling.
>
> Let's re-implement the pinmux_ops.gpio_set_direction callback so that
> the gpio subsystem can request from the pinctrl driver to put the pin in
> its GPIO function.
>
> Fixes: 9ce9a02039de ("pinctrl/rockchip: drop the gpio related codes")
> Cc: stable@vger.kernel.org
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Quentin Schulz <foss+kernel@0leil.net>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, jay.xu@rock-chips.com,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
foss+kernel@0leil.net,
Quentin Schulz <quentin.schulz@theobroma-systems.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: rockchip: add pinmux_ops.gpio_set_direction callback
Date: Fri, 23 Sep 2022 20:14:48 +0200 [thread overview]
Message-ID: <2890748.BddDVKsqQX@phil> (raw)
In-Reply-To: <20220923145141.3463754-2-foss+kernel@0leil.net>
Am Freitag, 23. September 2022, 16:51:40 CEST schrieb Quentin Schulz:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> Before the split of gpio and pinctrl sections in their own driver,
> rockchip_set_mux was called in pinmux_ops.gpio_set_direction for
> configuring a pin in its GPIO function.
>
> This is essential for cases where pinctrl is "bypassed" by gpio
> consumers otherwise the GPIO function is not configured for the pin and
> it does not work. Such was the case for the sysfs/libgpiod userspace
> GPIO handling.
>
> Let's re-implement the pinmux_ops.gpio_set_direction callback so that
> the gpio subsystem can request from the pinctrl driver to put the pin in
> its GPIO function.
>
> Fixes: 9ce9a02039de ("pinctrl/rockchip: drop the gpio related codes")
> Cc: stable@vger.kernel.org
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-23 18:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 14:51 [PATCH 0/2] fix gpio-sysfs/libgpiod for rockchip Quentin Schulz
2022-09-23 14:51 ` Quentin Schulz
2022-09-23 14:51 ` Quentin Schulz
2022-09-23 14:51 ` [PATCH 1/2] pinctrl: rockchip: add pinmux_ops.gpio_set_direction callback Quentin Schulz
2022-09-23 14:51 ` Quentin Schulz
2022-09-23 14:51 ` Quentin Schulz
2022-09-23 18:14 ` Heiko Stuebner [this message]
2022-09-23 18:14 ` Heiko Stuebner
2022-09-23 18:14 ` Heiko Stuebner
2022-09-23 14:51 ` [PATCH 2/2] gpio: rockchip: request GPIO mux to pinctrl when setting direction Quentin Schulz
2022-09-23 14:51 ` Quentin Schulz
2022-09-23 14:51 ` Quentin Schulz
2022-09-23 18:41 ` Heiko Stuebner
2022-09-23 18:41 ` Heiko Stuebner
2022-09-23 18:41 ` Heiko Stuebner
2022-09-28 16:33 ` kernel test robot
2022-09-28 16:33 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2890748.BddDVKsqQX@phil \
--to=heiko@sntech.de \
--cc=brgl@bgdev.pl \
--cc=foss+kernel@0leil.net \
--cc=jay.xu@rock-chips.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.