From: Casey Schaufler <casey@schaufler-ca.com>
To: David Howells <dhowells@redhat.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Daniel J Walsh <dwalsh@redhat.com>
Cc: dhowells@redhat.com, casey@schaufler-ca.com,
viro@ftp.linux.org.uk, hch@infradead.org,
Trond.Myklebust@netapp.com, linux-kernel@vger.kernel.org,
selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org
Subject: Re: [PATCH 4/7] KEYS: Add keyctl function to get a security label
Date: Wed, 5 Dec 2007 17:40:15 -0800 (PST) [thread overview]
Message-ID: <289732.78389.qm@web36613.mail.mud.yahoo.com> (raw)
In-Reply-To: <25702.1196904505@redhat.com>
--- David Howells <dhowells@redhat.com> wrote:
> Stephen Smalley <sds@tycho.nsa.gov> wrote:
>
> > inode_getsecurity and getprocattr directly return the strings.
> > Admittedly, the whole interface could be cleaned up and made far more
> > consistent, but I don't think he necessarily has to go through the
> > getsecid + secid_to_secctx sequence if he only wants the secctx.
>
> It's what Daniel Walsh wanted.
Name dropper. And we don't have a convention, really. So go ahead
with key_getsecurity or key_getsecctx, as you choose. At some point
we should either change inode_getsecurity to inode_getsecctx or
secid_to_secctx to secid_to_security. Not the problem of the day.
Casey Schaufler
casey@schaufler-ca.com
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
WARNING: multiple messages have this Message-ID (diff)
From: Casey Schaufler <casey@schaufler-ca.com>
To: David Howells <dhowells@redhat.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Daniel J Walsh <dwalsh@redhat.com>
Cc: dhowells@redhat.com, casey@schaufler-ca.com,
viro@ftp.linux.org.uk, hch@infradead.org,
Trond.Myklebust@netapp.com, linux-kernel@vger.kernel.org,
selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org
Subject: Re: [PATCH 4/7] KEYS: Add keyctl function to get a security label
Date: Wed, 5 Dec 2007 17:40:15 -0800 (PST) [thread overview]
Message-ID: <289732.78389.qm@web36613.mail.mud.yahoo.com> (raw)
In-Reply-To: <25702.1196904505@redhat.com>
--- David Howells <dhowells@redhat.com> wrote:
> Stephen Smalley <sds@tycho.nsa.gov> wrote:
>
> > inode_getsecurity and getprocattr directly return the strings.
> > Admittedly, the whole interface could be cleaned up and made far more
> > consistent, but I don't think he necessarily has to go through the
> > getsecid + secid_to_secctx sequence if he only wants the secctx.
>
> It's what Daniel Walsh wanted.
Name dropper. And we don't have a convention, really. So go ahead
with key_getsecurity or key_getsecctx, as you choose. At some point
we should either change inode_getsecurity to inode_getsecctx or
secid_to_secctx to secid_to_security. Not the problem of the day.
Casey Schaufler
casey@schaufler-ca.com
next prev parent reply other threads:[~2007-12-06 1:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-05 19:37 [PATCH 0/7] Permit filesystem local caching David Howells
2007-12-05 19:37 ` David Howells
2007-12-05 19:37 ` [PATCH 1/7] KEYS: Increase the payload size when instantiating a key David Howells
2007-12-05 19:37 ` David Howells
2007-12-05 19:37 ` [PATCH 2/7] KEYS: Check starting keyring as part of search David Howells
2007-12-05 19:37 ` David Howells
2007-12-05 19:37 ` [PATCH 3/7] KEYS: Allow the callout data to be passed as a blob rather than a string David Howells
2007-12-05 19:37 ` David Howells
2007-12-05 19:37 ` [PATCH 4/7] KEYS: Add keyctl function to get a security label David Howells
2007-12-05 19:37 ` David Howells
2007-12-05 20:12 ` Casey Schaufler
2007-12-05 20:12 ` Casey Schaufler
2007-12-05 20:38 ` Stephen Smalley
2007-12-05 20:38 ` Stephen Smalley
2007-12-06 1:28 ` David Howells
2007-12-06 1:28 ` David Howells
2007-12-06 1:40 ` Casey Schaufler [this message]
2007-12-06 1:40 ` Casey Schaufler
2007-12-05 19:37 ` [PATCH 5/7] Security: Change current->fs[ug]id to current_fs[ug]id() David Howells
2007-12-05 19:37 ` David Howells
2007-12-07 17:44 ` Serge E. Hallyn
2007-12-07 17:44 ` Serge E. Hallyn
2007-12-08 0:53 ` David Howells
2007-12-08 0:53 ` David Howells
2007-12-05 19:37 ` [PATCH 6/7] SECURITY: Separate task security context from task_struct David Howells
2007-12-05 19:37 ` [PATCH 7/7] SECURITY: De-embed task security record from task and use refcounting David Howells
2007-12-05 19:37 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=289732.78389.qm@web36613.mail.mud.yahoo.com \
--to=casey@schaufler-ca.com \
--cc=Trond.Myklebust@netapp.com \
--cc=dhowells@redhat.com \
--cc=dwalsh@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.