All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Vinod Koul <vkoul@kernel.org>, Shawn Lin <shawn.lin@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org,
	linux-phy@lists.infradead.org,
	Neil Armstrong <neil.armstrong@linaro.org>,
	linux-kernel@vger.kernel.org,
	Shawn Lin <shawn.lin@rock-chips.com>
Subject: Re: [PATCH v2] phy: rockchip: naneng-combphy: Consolidate SSC configuration
Date: Tue, 10 Mar 2026 09:40:11 +0100	[thread overview]
Message-ID: <2899531.BEx9A2HvPv@phil> (raw)
In-Reply-To: <1772696450-139583-1-git-send-email-shawn.lin@rock-chips.com>

Am Donnerstag, 5. März 2026, 08:40:50 Mitteleuropäische Normalzeit schrieb Shawn Lin:
> The PCIe SSC configuration for the RK3588 and RK3576 SoCs required
> additional tuning which is missing. When adding these same SSC
> configurations for both of these two SoCs, as well as upcoming
> platforms, it's obvious the SSC setup code was largely duplicated
> across the platform-specific configuration functions. This becomes
> harder to maintain as more platforms are added.
> 
> So extract the common SSC logic into a shared helper function,
> rk_combphy_common_cfg_ssc(). This cleans up the per-platform drivers
> and centralizes the standard configuration as possible.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>


Reviewed-by: Heiko Stuebner <heiko@sntech.de>



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Vinod Koul <vkoul@kernel.org>, Shawn Lin <shawn.lin@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org,
	linux-phy@lists.infradead.org,
	Neil Armstrong <neil.armstrong@linaro.org>,
	linux-kernel@vger.kernel.org,
	Shawn Lin <shawn.lin@rock-chips.com>
Subject: Re: [PATCH v2] phy: rockchip: naneng-combphy: Consolidate SSC configuration
Date: Tue, 10 Mar 2026 09:40:11 +0100	[thread overview]
Message-ID: <2899531.BEx9A2HvPv@phil> (raw)
In-Reply-To: <1772696450-139583-1-git-send-email-shawn.lin@rock-chips.com>

Am Donnerstag, 5. März 2026, 08:40:50 Mitteleuropäische Normalzeit schrieb Shawn Lin:
> The PCIe SSC configuration for the RK3588 and RK3576 SoCs required
> additional tuning which is missing. When adding these same SSC
> configurations for both of these two SoCs, as well as upcoming
> platforms, it's obvious the SSC setup code was largely duplicated
> across the platform-specific configuration functions. This becomes
> harder to maintain as more platforms are added.
> 
> So extract the common SSC logic into a shared helper function,
> rk_combphy_common_cfg_ssc(). This cleans up the per-platform drivers
> and centralizes the standard configuration as possible.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>


Reviewed-by: Heiko Stuebner <heiko@sntech.de>



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Vinod Koul <vkoul@kernel.org>, Shawn Lin <shawn.lin@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org,
	linux-phy@lists.infradead.org,
	Neil Armstrong <neil.armstrong@linaro.org>,
	linux-kernel@vger.kernel.org,
	Shawn Lin <shawn.lin@rock-chips.com>
Subject: Re: [PATCH v2] phy: rockchip: naneng-combphy: Consolidate SSC configuration
Date: Tue, 10 Mar 2026 09:40:11 +0100	[thread overview]
Message-ID: <2899531.BEx9A2HvPv@phil> (raw)
In-Reply-To: <1772696450-139583-1-git-send-email-shawn.lin@rock-chips.com>

Am Donnerstag, 5. März 2026, 08:40:50 Mitteleuropäische Normalzeit schrieb Shawn Lin:
> The PCIe SSC configuration for the RK3588 and RK3576 SoCs required
> additional tuning which is missing. When adding these same SSC
> configurations for both of these two SoCs, as well as upcoming
> platforms, it's obvious the SSC setup code was largely duplicated
> across the platform-specific configuration functions. This becomes
> harder to maintain as more platforms are added.
> 
> So extract the common SSC logic into a shared helper function,
> rk_combphy_common_cfg_ssc(). This cleans up the per-platform drivers
> and centralizes the standard configuration as possible.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>


Reviewed-by: Heiko Stuebner <heiko@sntech.de>



  parent reply	other threads:[~2026-03-10  8:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-05  7:40 [PATCH v2] phy: rockchip: naneng-combphy: Consolidate SSC configuration Shawn Lin
2026-03-05  7:40 ` Shawn Lin
2026-03-05  7:40 ` Shawn Lin
2026-03-06 10:38 ` Neil Armstrong
2026-03-06 10:38   ` Neil Armstrong
2026-03-06 10:38   ` Neil Armstrong
2026-03-10  8:40 ` Heiko Stuebner [this message]
2026-03-10  8:40   ` Heiko Stuebner
2026-03-10  8:40   ` Heiko Stuebner
2026-03-25  7:11 ` Shawn Lin
2026-03-25  7:11   ` Shawn Lin
2026-03-25  7:11   ` Shawn Lin
2026-04-08  2:53   ` Shawn Lin
2026-04-08  2:53     ` Shawn Lin
2026-04-08  2:53     ` Shawn Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2899531.BEx9A2HvPv@phil \
    --to=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=neil.armstrong@linaro.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.