All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vijay Balakrishna <vijayb@linux.microsoft.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
	catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: f.fainelli@gmail.com
Subject: Re: [PATCH v2 resend 3/3] arm64: mm: Cleanup useless parameters in zone_sizes_init()
Date: Fri, 1 Apr 2022 10:05:16 -0700	[thread overview]
Message-ID: <28b9ca3e-83d8-ea4b-1f27-d23c2d29424f@linux.microsoft.com> (raw)
In-Reply-To: <20220331074055.125824-4-wangkefeng.wang@huawei.com>



On 3/31/2022 12:40 AM, Kefeng Wang wrote:
> Directly use max_pfn for max and no one use min, kill them.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Looks good.  Reference to dma32_phys_limit in zone_sizes_init() depends 
on what you do with my comment [1].

[1] 
https://lore.kernel.org/all/69c1e722-33ea-95cf-de84-aed3022cb042@linux.microsoft.com/

Reviewed-by: Vijay Balakrishna <vijayb@linux.microsoft.com>

> ---
>   arch/arm64/mm/init.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 0aafa9181607..80e9ff37b697 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -181,7 +181,7 @@ static phys_addr_t __init max_zone_phys(unsigned int zone_bits)
>   	return min(zone_mask, memblock_end_of_DRAM() - 1) + 1;
>   }
>   
> -static void __init zone_sizes_init(unsigned long min, unsigned long max)
> +static void __init zone_sizes_init(void)
>   {
>   	unsigned long max_zone_pfns[MAX_NR_ZONES]  = {0};
>   #ifdef CONFIG_ZONE_DMA
> @@ -199,7 +199,7 @@ static void __init zone_sizes_init(unsigned long min, unsigned long max)
>   #ifdef CONFIG_ZONE_DMA32
>   	max_zone_pfns[ZONE_DMA32] = PFN_DOWN(dma32_phys_limit);
>   #endif
> -	max_zone_pfns[ZONE_NORMAL] = max;
> +	max_zone_pfns[ZONE_NORMAL] = max_pfn;
>   
>   	free_area_init(max_zone_pfns);
>   }
> @@ -401,7 +401,7 @@ void __init bootmem_init(void)
>   	 * done after the fixed reservations
>   	 */
>   	sparse_init();
> -	zone_sizes_init(min, max);
> +	zone_sizes_init();
>   
>   	/*
>   	 * Reserve the CMA area after arm64_dma_phys_limit was initialised.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Vijay Balakrishna <vijayb@linux.microsoft.com>
To: Kefeng Wang <wangkefeng.wang@huawei.com>,
	catalin.marinas@arm.com, will@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: f.fainelli@gmail.com
Subject: Re: [PATCH v2 resend 3/3] arm64: mm: Cleanup useless parameters in zone_sizes_init()
Date: Fri, 1 Apr 2022 10:05:16 -0700	[thread overview]
Message-ID: <28b9ca3e-83d8-ea4b-1f27-d23c2d29424f@linux.microsoft.com> (raw)
In-Reply-To: <20220331074055.125824-4-wangkefeng.wang@huawei.com>



On 3/31/2022 12:40 AM, Kefeng Wang wrote:
> Directly use max_pfn for max and no one use min, kill them.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>

Looks good.  Reference to dma32_phys_limit in zone_sizes_init() depends 
on what you do with my comment [1].

[1] 
https://lore.kernel.org/all/69c1e722-33ea-95cf-de84-aed3022cb042@linux.microsoft.com/

Reviewed-by: Vijay Balakrishna <vijayb@linux.microsoft.com>

> ---
>   arch/arm64/mm/init.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 0aafa9181607..80e9ff37b697 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -181,7 +181,7 @@ static phys_addr_t __init max_zone_phys(unsigned int zone_bits)
>   	return min(zone_mask, memblock_end_of_DRAM() - 1) + 1;
>   }
>   
> -static void __init zone_sizes_init(unsigned long min, unsigned long max)
> +static void __init zone_sizes_init(void)
>   {
>   	unsigned long max_zone_pfns[MAX_NR_ZONES]  = {0};
>   #ifdef CONFIG_ZONE_DMA
> @@ -199,7 +199,7 @@ static void __init zone_sizes_init(unsigned long min, unsigned long max)
>   #ifdef CONFIG_ZONE_DMA32
>   	max_zone_pfns[ZONE_DMA32] = PFN_DOWN(dma32_phys_limit);
>   #endif
> -	max_zone_pfns[ZONE_NORMAL] = max;
> +	max_zone_pfns[ZONE_NORMAL] = max_pfn;
>   
>   	free_area_init(max_zone_pfns);
>   }
> @@ -401,7 +401,7 @@ void __init bootmem_init(void)
>   	 * done after the fixed reservations
>   	 */
>   	sparse_init();
> -	zone_sizes_init(min, max);
> +	zone_sizes_init();
>   
>   	/*
>   	 * Reserve the CMA area after arm64_dma_phys_limit was initialised.

  reply	other threads:[~2022-04-01 17:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31  7:40 [PATCH v2 resend 0/3] arm64: mm: Do not defer reserve_crashkernel() Kefeng Wang
2022-03-31  7:40 ` Kefeng Wang
2022-03-31  7:40 ` [PATCH v2 resend 1/3] arm64: mm: Do not defer reserve_crashkernel() if only ZONE_DMA32 Kefeng Wang
2022-03-31  7:40   ` Kefeng Wang
2022-04-01 15:59   ` Vijay Balakrishna
2022-04-01 15:59     ` Vijay Balakrishna
2022-03-31  7:40 ` [PATCH v2 resend 2/3] arm64: mm: Don't defer reserve_crashkernel() with dma_force_32bit Kefeng Wang
2022-03-31  7:40   ` Kefeng Wang
2022-03-31 16:14   ` kernel test robot
2022-03-31 16:14     ` kernel test robot
2022-04-01  5:17     ` Kefeng Wang
2022-04-01  5:17       ` Kefeng Wang
2022-04-01  5:17       ` Kefeng Wang
2022-04-01 22:09   ` Vijay Balakrishna
2022-04-01 22:09     ` Vijay Balakrishna
2022-04-11  8:28     ` Kefeng Wang
2022-04-11  8:28       ` Kefeng Wang
2022-03-31  7:40 ` [PATCH v2 resend 3/3] arm64: mm: Cleanup useless parameters in zone_sizes_init() Kefeng Wang
2022-03-31  7:40   ` Kefeng Wang
2022-04-01 17:05   ` Vijay Balakrishna [this message]
2022-04-01 17:05     ` Vijay Balakrishna
2022-04-11  8:22     ` Kefeng Wang
2022-04-11  8:22       ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28b9ca3e-83d8-ea4b-1f27-d23c2d29424f@linux.microsoft.com \
    --to=vijayb@linux.microsoft.com \
    --cc=catalin.marinas@arm.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.