Re: [PATCH 0/3] arm64: dts: rockchip: Add Radxa ROCK 5B+ and rebase Radxa ROCK 5B

[Dragan Simic <dsimic@manjaro.org>]

Hello Naoki,

On 2024-12-25 11:09, FUKAUMI Naoki wrote:
> On 12/25/24 17:32, Alexey Charkov wrote:
>> On Wed, Dec 25, 2024 at 12:22 PM FUKAUMI Naoki <naoki@radxa.com> 
>> wrote:
>>> 
>>> The Radxa ROCK 5B+ is an upgraded version of the Radxa ROCK 5B.
>>> 
>>> This patch series introduces a shared .dtsi that can be used on the
>>> new Radxa ROCK 5B+, the existing Radxa ROCK 5B, and the upcoming 
>>> Radxa
>>> ROCK 5T.
>>> 
>>> This patch series includes "arm64: dts: rockchip: Add USB-C support 
>>> to
>>> ROCK 5B" by Sebastian Reichel[1].
>>> 
>>> [1] 
>>> https://patchwork.kernel.org/project/linux-rockchip/patch/20241210163615.120594-1-sebastian.reichel@collabora.com/
>>> 
>>> FUKAUMI Naoki (3):
>>>    dt-bindings: arm: rockchip: Add Radxa ROCK 5B+
>>>    arm64: dts: rockchip: Add Radxa ROCK 5B+
>>>    arm64: dts: rockchip: Convert Radxa ROCK 5B to use shared .dtsi
>> 
>> This one doesn't look equivalent to the existing ROCK 5B device tree
>> after your changes (I've noticed in particular that fan cooling levels
>> are different - but that's just the part I remember well since I
>> modified it earlier, there might be more differences).
> 
> Thanks for pointing!
> 
>> Would you mind rearranging the patches so that the split of ROCK 5B
>> dts into a common .dtsi and per-board .dts additions could be made
>> one-to-one equivalent without functional changes, and then add ROCK
>> 5B+ and any other required changes on top of that?
> 
> My priority goal is to add support for ROCK 5B+ and 5T. This time, I
> will not make any changes to ROCK 5B so as not to break it. Therefore,
> I will drop PATCH 3/3.
> 
> (I would like to make changes to ROCK 5B at some point.)

I see, but I think that just dropping the patch 3/3 wouldn't be the
best possible option.  That way you'd end up with a "dangling" dtsi
file, used by just one board dts file, which is a bit suboptimal.

I'd suggest that you actually do it the right way, so to speak, by
actually converting the ROCK 5B dts file to use the shared dtsi file
in a way that makes the transition more obvious and, as a result,
easier to review, as already suggested above.

As another option, I'm going to ask Radxa for a sample ROCK 5B+ board
soon, for my Rockchip SoC binning project, and if I actually get it,
I could take over this series, to help you that way with getting the
patch series in better shape.

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip