[PATCH] xmm7modem: disabling reporting of intermediate results for CGDATA

[PATCH] xmm7modem: disabling reporting of intermediate results for CGDATA

[Antara Borwankar]

[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]

Setting <connect_flag> in AT+XDATACHANNEL set command to 0. This will
disable intermediate result reporting of "CONNECT" and "NO CARRIER"
on control channel.

This resolves the issue of getting failure response for offline-modem
since "NO CARRIER" is received as result of AT+CFUN operation instead
of "OK".
---
 drivers/ifxmodem/gprs-context.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ifxmodem/gprs-context.c b/drivers/ifxmodem/gprs-context.c
index 2de6b4f..7bacb73 100644
--- a/drivers/ifxmodem/gprs-context.c
+++ b/drivers/ifxmodem/gprs-context.c
@@ -406,7 +406,7 @@ static void cgcontrdp_cb(gboolean ok, GAtResult *result, gpointer user_data)
 	interface = ofono_gprs_context_get_interface(gc);
 	datapath = get_datapath(modem, interface);
 
-	snprintf(buf, sizeof(buf), "AT+XDATACHANNEL=1,1,\"%s\",\"%s\",2,%u",
+	snprintf(buf, sizeof(buf), "AT+XDATACHANNEL=1,1,\"%s\",\"%s\",0,%u",
 			ctrlpath, datapath, gcd->active_context);
 	g_at_chat_send(gcd->chat, buf, none_prefix, NULL, NULL, NULL);
 	snprintf(buf, sizeof(buf), "AT+CGDATA=\"M-RAW_IP\",%u",
-- 
1.9.1

Re: [PATCH] xmm7modem: disabling reporting of intermediate results for CGDATA

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 540 bytes --]

Hi Antara,

On 06/20/2019 07:07 AM, Antara Borwankar wrote:
> Setting <connect_flag> in AT+XDATACHANNEL set command to 0. This will
> disable intermediate result reporting of "CONNECT" and "NO CARRIER"
> on control channel.
> 
> This resolves the issue of getting failure response for offline-modem
> since "NO CARRIER" is received as result of AT+CFUN operation instead
> of "OK".
> ---
>   drivers/ifxmodem/gprs-context.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 

Applied, thanks.

Regards,
-Denis