From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac
Date: Fri, 01 Jul 2016 11:46:04 +0200 [thread overview]
Message-ID: <29091648.CIZSyGWL7u@wuerfel> (raw)
In-Reply-To: <1467327554-22074-7-git-send-email-jon.mason@broadcom.com>
On Thursday, June 30, 2016 6:59:13 PM CEST Jon Mason wrote:
> +
> +Required properties:
> + - compatible: "brcm,bgmac-nsp"
> + - reg: Address and length of the GMAC registers,
> + Address and length of the GMAC IDM registers
> + - reg-names: Names of the registers. Must have both "gmac_base" and
> + "idm_base"
> + - interrupts: Interrupt number
> +
"brcm,bgmac-nsp" sounds a bit too general. As I understand, this is a family
of SoCs that might not all have the exact same implementation of this
ethernet device, as we can see from the long lookup table in bgmac_probe().
Please document the specific product numbers here that are publically
known already. Having the driver match just on "brcm,bgmac-nsp" as a fallback
is fine, so you can document that one as required for all users.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Jon Mason <jon.mason@broadcom.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, f.fainelli@gmail.com,
Scott Branden <sbranden@broadcom.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
hauke@hauke-m.de, zajec5@gmail.com, linux-kernel@vger.kernel.org,
Ray Jui <rjui@broadcom.com>, Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
Kumar Gala <galak@codeaurora.org>,
netdev@vger.kernel.org, davem@davemloft.net,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac
Date: Fri, 01 Jul 2016 11:46:04 +0200 [thread overview]
Message-ID: <29091648.CIZSyGWL7u@wuerfel> (raw)
In-Reply-To: <1467327554-22074-7-git-send-email-jon.mason@broadcom.com>
On Thursday, June 30, 2016 6:59:13 PM CEST Jon Mason wrote:
> +
> +Required properties:
> + - compatible: "brcm,bgmac-nsp"
> + - reg: Address and length of the GMAC registers,
> + Address and length of the GMAC IDM registers
> + - reg-names: Names of the registers. Must have both "gmac_base" and
> + "idm_base"
> + - interrupts: Interrupt number
> +
"brcm,bgmac-nsp" sounds a bit too general. As I understand, this is a family
of SoCs that might not all have the exact same implementation of this
ethernet device, as we can see from the long lookup table in bgmac_probe().
Please document the specific product numbers here that are publically
known already. Having the driver match just on "brcm,bgmac-nsp" as a fallback
is fine, so you can document that one as required for all users.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Jon Mason <jon.mason@broadcom.com>
Cc: zajec5@gmail.com, davem@davemloft.net, f.fainelli@gmail.com,
hauke@hauke-m.de, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac
Date: Fri, 01 Jul 2016 11:46:04 +0200 [thread overview]
Message-ID: <29091648.CIZSyGWL7u@wuerfel> (raw)
In-Reply-To: <1467327554-22074-7-git-send-email-jon.mason@broadcom.com>
On Thursday, June 30, 2016 6:59:13 PM CEST Jon Mason wrote:
> +
> +Required properties:
> + - compatible: "brcm,bgmac-nsp"
> + - reg: Address and length of the GMAC registers,
> + Address and length of the GMAC IDM registers
> + - reg-names: Names of the registers. Must have both "gmac_base" and
> + "idm_base"
> + - interrupts: Interrupt number
> +
"brcm,bgmac-nsp" sounds a bit too general. As I understand, this is a family
of SoCs that might not all have the exact same implementation of this
ethernet device, as we can see from the long lookup table in bgmac_probe().
Please document the specific product numbers here that are publically
known already. Having the driver match just on "brcm,bgmac-nsp" as a fallback
is fine, so you can document that one as required for all users.
Arnd
next prev parent reply other threads:[~2016-07-01 9:46 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-30 22:59 [PATCH 0/7] net: ethernet: bgmac: Add platform device support Jon Mason
2016-06-30 22:59 ` Jon Mason
2016-06-30 22:59 ` Jon Mason
2016-06-30 22:59 ` [PATCH 1/7] net: ethernet: bgmac: change bgmac_* prints to dev_* prints Jon Mason
2016-06-30 22:59 ` Jon Mason
2016-06-30 22:59 ` [PATCH 2/7] net: ethernet: bgmac: add dma_dev pointer Jon Mason
2016-06-30 22:59 ` Jon Mason
2016-06-30 22:59 ` Jon Mason
2016-06-30 22:59 ` [PATCH 3/7] net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file Jon Mason
2016-06-30 22:59 ` Jon Mason
2016-06-30 22:59 ` [PATCH 4/7] net: ethernet: bgmac: convert to feature flags Jon Mason
2016-06-30 22:59 ` Jon Mason
2016-06-30 22:59 ` [PATCH 5/7] net: ethernet: bgmac: Add platform device support Jon Mason
2016-06-30 22:59 ` Jon Mason
2016-06-30 22:59 ` Jon Mason
2016-06-30 23:26 ` Florian Fainelli
2016-06-30 23:26 ` Florian Fainelli
2016-06-30 23:26 ` Florian Fainelli
2016-06-30 22:59 ` [PATCH 6/7] dt-bindings: net: bgmac: add bindings documentation for bgmac Jon Mason
2016-06-30 22:59 ` Jon Mason
2016-07-01 2:56 ` Rob Herring
2016-07-01 2:56 ` Rob Herring
2016-07-01 14:29 ` Jon Mason
2016-07-01 14:29 ` Jon Mason
2016-07-01 9:46 ` Arnd Bergmann [this message]
2016-07-01 9:46 ` Arnd Bergmann
2016-07-01 9:46 ` Arnd Bergmann
2016-07-01 15:17 ` Jon Mason
2016-07-01 15:17 ` Jon Mason
2016-07-01 15:17 ` Jon Mason
2016-07-01 15:42 ` Arnd Bergmann
2016-07-01 15:42 ` Arnd Bergmann
2016-07-01 15:42 ` Arnd Bergmann
2016-07-04 16:34 ` Ray Jui
2016-07-04 16:34 ` Ray Jui
2016-07-04 16:34 ` Ray Jui
2016-07-05 13:37 ` Arnd Bergmann
2016-07-05 13:37 ` Arnd Bergmann
2016-07-05 23:18 ` Jon Mason
2016-07-05 23:18 ` Jon Mason
2016-07-06 7:34 ` Arnd Bergmann
2016-07-06 7:34 ` Arnd Bergmann
2016-07-06 7:34 ` Arnd Bergmann
2016-07-07 22:42 ` Jon Mason
2016-07-07 22:42 ` Jon Mason
2016-06-30 22:59 ` [PATCH 7/7] ARM: dts: NSP: Add bgmac entries Jon Mason
2016-06-30 22:59 ` Jon Mason
2016-07-01 9:49 ` [PATCH 0/7] net: ethernet: bgmac: Add platform device support Arnd Bergmann
2016-07-01 9:49 ` Arnd Bergmann
2016-07-01 9:49 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29091648.CIZSyGWL7u@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.