From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: devicetree@vger.kernel.org, daniel.thompson@linaro.org,
tony.luck@intel.com, manivannan.sadhasivam@linaro.org,
keescook@chromium.org, robh@kernel.org, linus.walleij@linaro.org,
anton@enomsg.org, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
ccross@android.com, frowand.list@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv5] drivers/amba: add reset control to amba bus probe
Date: Wed, 28 Aug 2019 09:46:45 -0400 [thread overview]
Message-ID: <292438.1567000005@turing-police> (raw)
In-Reply-To: <46bcf493-9dd6-bf5b-089a-be158739a13f@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 520 bytes --]
On Wed, 28 Aug 2019 08:34:20 -0500, Dinh Nguyen said:
> > Does this DTRT for both old and new U-Boots? My naive reading of
> > this patch
>
> What is a DTRT?
Do The Right Thing, sorry...
> > says on an old U-Boot, we end up attempting to bring it out of
> > reset even though they had already been brought out.
> >
>
> If the peripheral is already out of reset, de-asserting the reset has
> no affect.
OK, thanks. There's been hardware where doing that sort of thing twice will
confuse the device and cause issues.
[-- Attachment #1.2: Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, linux@armlinux.org.uk, frowand.list@gmail.com,
keescook@chromium.org, anton@enomsg.org, ccross@android.com,
tony.luck@intel.com, daniel.thompson@linaro.org,
linus.walleij@linaro.org, manivannan.sadhasivam@linaro.org,
linux-arm-kernel@lists.infradead.org, p.zabel@pengutronix.de
Subject: Re: [PATCHv5] drivers/amba: add reset control to amba bus probe
Date: Wed, 28 Aug 2019 09:46:45 -0400 [thread overview]
Message-ID: <292438.1567000005@turing-police> (raw)
In-Reply-To: <46bcf493-9dd6-bf5b-089a-be158739a13f@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
On Wed, 28 Aug 2019 08:34:20 -0500, Dinh Nguyen said:
> > Does this DTRT for both old and new U-Boots? My naive reading of
> > this patch
>
> What is a DTRT?
Do The Right Thing, sorry...
> > says on an old U-Boot, we end up attempting to bring it out of
> > reset even though they had already been brought out.
> >
>
> If the peripheral is already out of reset, de-asserting the reset has
> no affect.
OK, thanks. There's been hardware where doing that sort of thing twice will
confuse the device and cause issues.
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-08-28 13:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 15:42 [PATCHv5] drivers/amba: add reset control to amba bus probe Dinh Nguyen
2019-08-26 15:42 ` Dinh Nguyen
2019-08-26 15:51 ` Philipp Zabel
2019-08-26 15:51 ` Philipp Zabel
2019-08-27 19:25 ` Valdis Klētnieks
2019-08-27 19:25 ` Valdis Klētnieks
2019-08-28 13:34 ` Dinh Nguyen
2019-08-28 13:34 ` Dinh Nguyen
2019-08-28 13:46 ` Valdis Klētnieks [this message]
2019-08-28 13:46 ` Valdis Klētnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=292438.1567000005@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=frowand.list@gmail.com \
--cc=keescook@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=manivannan.sadhasivam@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.