From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: "Morten Brørup" <mb@smartsharesystems.com>,
dev@dpdk.org, bruce.richardson@intel.com,
andremue@linux.microsoft.com, roretzla@linux.microsoft.com
Subject: Re: [PATCH] devtools: forbid use of compiler pragmas
Date: Mon, 21 Jul 2025 15:26:13 +0200 [thread overview]
Message-ID: <2928176.88bMQJbFj6@thomas> (raw)
In-Reply-To: <CAJFAV8z-E7MMdx=W3XVp98=wffDtSd=7X3QyG=vfFV4L+=u-UQ@mail.gmail.com>
30/01/2025 09:52, David Marchand:
> On Thu, Jan 30, 2025 at 9:45 AM Morten Brørup <mb@smartsharesystems.com> wrote:
> >
> > > From: David Marchand [mailto:david.marchand@redhat.com]
> > > Sent: Thursday, 30 January 2025 09.38
> > >
> > > Using pragma must be prevented to avoid breaking builds with other
> > > compilers.
> > > Let EAL use them (like for abstraction macros).
> >
> > You are only allowing them in rte_common.h.
> > Do we need them elsewhere in EAL?
> > Not that I think so, but the patch description could be interpreted that way.
>
> Ah yes, I forgot to update description afterwards.
> I can update when applying.
>
> >
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > ---
> >
> > Good idea!
> >
> > Acked-by: Morten Brørup <mb@smartsharesystems.com>
Applied with updated commit log, thanks.
next prev parent reply other threads:[~2025-07-21 13:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 8:37 [PATCH] devtools: forbid use of compiler pragmas David Marchand
2025-01-30 8:45 ` Morten Brørup
2025-01-30 8:52 ` David Marchand
2025-07-21 13:26 ` Thomas Monjalon [this message]
2025-02-04 15:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2928176.88bMQJbFj6@thomas \
--to=thomas@monjalon.net \
--cc=andremue@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.