All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com,
	andremue@linux.microsoft.com, roretzla@linux.microsoft.com
Subject: Re: [PATCH] devtools: forbid use of compiler pragmas
Date: Tue, 04 Feb 2025 16:59:28 +0100	[thread overview]
Message-ID: <8281045.JRmrKFJ9eK@thomas> (raw)
In-Reply-To: <20250130083741.3258965-1-david.marchand@redhat.com>

30/01/2025 09:37, David Marchand:
> Using pragma must be prevented to avoid breaking builds with other
> compilers.
> Let EAL use them (like for abstraction macros).
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> +	# forbid use of #pragma
> +	awk -v FOLDERS='lib drivers app examples' \
> +		-v SKIP_FILES='lib/eal/include/rte_common.h' \
> +		-v EXPRESSIONS='(#pragma|_Pragma)' \
> +		-v RET_ON_FAIL=1 \
> +		-v MESSAGE='Using compilers pragma is not allowed' \
> +		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
> +		"$1" || res=1

Acked-by: Thomas Monjalon <thomas@monjalon.net>



      parent reply	other threads:[~2025-02-04 15:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-30  8:37 [PATCH] devtools: forbid use of compiler pragmas David Marchand
2025-01-30  8:45 ` Morten Brørup
2025-01-30  8:52   ` David Marchand
2025-07-21 13:26     ` Thomas Monjalon
2025-02-04 15:59 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8281045.JRmrKFJ9eK@thomas \
    --to=thomas@monjalon.net \
    --cc=andremue@linux.microsoft.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.