[PATCH] c_can: Set reserved bit in IFx_MASK2 to set 1 on write

[PATCH] c_can: Set reserved bit in IFx_MASK2 to set 1 on write

[Alexander Stein]

Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
 drivers/net/can/c_can/c_can.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
index 30646d6..2f9dedd2 100644
--- a/drivers/net/can/c_can/c_can.c
+++ b/drivers/net/can/c_can/c_can.c
@@ -495,8 +495,12 @@ static void c_can_setup_receive_object(struct net_device *dev,
 
 	priv->write_reg(priv, C_CAN_IFACE(MASK1_REG, iface),
 			IFX_WRITE_LOW_16BIT(mask));
+
+	/* According to C_CAN documentation, the reserved bit
+	 * in IFx_MASK2 register is fixed 1
+	 */
 	priv->write_reg(priv, C_CAN_IFACE(MASK2_REG, iface),
-			IFX_WRITE_HIGH_16BIT(mask));
+			IFX_WRITE_HIGH_16BIT(mask) | BIT(13));
 
 	priv->write_reg(priv, C_CAN_IFACE(ARB1_REG, iface),
 			IFX_WRITE_LOW_16BIT(id));
-- 
1.7.8.6

Re: [PATCH] c_can: Set reserved bit in IFx_MASK2 to set 1 on write

[Alexander Stein]

Ping

On Thursday 13 December 2012 10:06:10, Alexander Stein wrote:
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
>  drivers/net/can/c_can/c_can.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
> index 30646d6..2f9dedd2 100644
> --- a/drivers/net/can/c_can/c_can.c
> +++ b/drivers/net/can/c_can/c_can.c
> @@ -495,8 +495,12 @@ static void c_can_setup_receive_object(struct net_device *dev,
>  
>  	priv->write_reg(priv, C_CAN_IFACE(MASK1_REG, iface),
>  			IFX_WRITE_LOW_16BIT(mask));
> +
> +	/* According to C_CAN documentation, the reserved bit
> +	 * in IFx_MASK2 register is fixed 1
> +	 */
>  	priv->write_reg(priv, C_CAN_IFACE(MASK2_REG, iface),
> -			IFX_WRITE_HIGH_16BIT(mask));
> +			IFX_WRITE_HIGH_16BIT(mask) | BIT(13));
>  
>  	priv->write_reg(priv, C_CAN_IFACE(ARB1_REG, iface),
>  			IFX_WRITE_LOW_16BIT(id));
> 

Re: [PATCH] c_can: Set reserved bit in IFx_MASK2 to set 1 on write

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

On 01/31/2013 12:18 PM, Alexander Stein wrote:
> Ping

Thanks.

I've added stable on Cc, copied the comment from the code to the patch
description, tweaked the subject and send a pull request to David.

regards, Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]