From: Nish Aravamudan <nish.aravamudan@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/char/selection.c: replace direct assignment
Date: Wed, 04 May 2005 16:33:25 +0000 [thread overview]
Message-ID: <29495f1d0505040933696e9616@mail.gmail.com> (raw)
In-Reply-To: <20050504100438.GW8647@rhum.iomeda.fr>
On 5/4/05, Christophe Lucas <clucas@rotomalug.org> wrote:
> description:
> Use set_current_state() instead of direct assignment of
> current->state.
Usually, when you are setting the state to TASK_RUNNING, you don't
want to use set_current_state(), but __set_current_state(). The best
bet is to see if you can't convert the wait-queue usage in that
function to prepare_to_wait()/finish_wait().
Good luck,
Nish
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-05-04 16:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-04 10:04 [KJ] [PATCH] drivers/char/selection.c: replace direct assignment Christophe Lucas
2005-05-04 16:33 ` Nish Aravamudan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29495f1d0505040933696e9616@mail.gmail.com \
--to=nish.aravamudan@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.