[KJ] [PATCH] drivers/char/selection.c: replace direct assignment

[KJ] [PATCH] drivers/char/selection.c: replace direct assignment

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

description:
Use set_current_state() instead of direct assignment of
current->state.

Signed-off-by: Christophe Lucas <clucas@rotomalug.org>

[-- Attachment #2: linux-2.6.12-rc3_drivers_char_selection.c.patch --]
[-- Type: text/plain, Size: 444 bytes --]

diff -urpNX dontdiff a/drivers/char/selection.c b/drivers/char/selection.c
--- a/drivers/char/selection.c	2005-04-21 02:03:13.000000000 +0200
+++ b/drivers/char/selection.c	2005-04-29 10:07:47.000000000 +0200
@@ -299,7 +299,7 @@ int paste_selection(struct tty_struct *t
 		pasted += count;
 	}
 	remove_wait_queue(&vc->paste_wait, &wait);
-	current->state = TASK_RUNNING;
+	set_current_state(TASK_RUNNING);
 
 	tty_ldisc_deref(ld);
 	return 0;

[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] drivers/char/selection.c: replace direct assignment

[Nish Aravamudan]

On 5/4/05, Christophe Lucas <clucas@rotomalug.org> wrote:
> description:
> Use set_current_state() instead of direct assignment of
> current->state.

Usually, when you are setting the state to TASK_RUNNING, you don't
want to use set_current_state(), but __set_current_state(). The best
bet is to see if you can't convert the wait-queue usage in that
function to prepare_to_wait()/finish_wait().

Good luck,
Nish

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors