All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Alexander Kochetkov <al.kochet@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Caesar Wang <wxt@rock-chips.com>,
	Huang Tao <huangtao@rock-chips.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Subject: Re: [PATCH v4 9/9] clocksource/drivers/rockchip_timer: implement clocksource timer
Date: Mon, 23 Jan 2017 18:09:41 +0100	[thread overview]
Message-ID: <2966820.3ediQCxqSR@diego> (raw)
In-Reply-To: <1480436092-10728-10-git-send-email-al.kochet@gmail.com>

Am Dienstag, 29. November 2016, 19:14:52 CET schrieb Alexander Kochetkov:
> The clock supplying the arm-global-timer on the rk3188 is coming from the
> the cpu clock itself and thus changes its rate everytime cpufreq adjusts
> the cpu frequency making this timer unsuitable as a stable clocksource
> and sched clock.
> 
> The rk3188, rk3288 and following socs share a separate timer block already
> handled by the rockchip-timer driver. Therefore adapt this driver to also
> be able to act as clocksource and sched clock on rk3188.
> 
> In order to test clocksource you can run following commands and check
> how much time it take in real. On rk3188 it take about ~45 seconds.
> 
>     cpufreq-set -f 1.6GHZ
>     date; sleep 60; date
> 
> In order to use the patch you need to declare two timers in the dts
> file. The first timer will be initialized as clockevent provider
> and the second one as clocksource. The clockevent must be from
> alive subsystem as it used as backup for the local timers at sleep
> time.
> 
> The patch does not break compatibility with older device tree files.
> The older device tree files contain only one timer. The timer
> will be initialized as clockevent, as expected.
> 
> rk3288 (and probably anything newer) is irrelevant to this patch,
> as it has the arch timer interface. This patch may be usefull
> for Cortex-A9/A5 based parts.
> 
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>

[...]

> @@ -120,13 +161,46 @@ static irqreturn_t rk_timer_interrupt(int irq, void
> *dev_id) return IRQ_HANDLED;
>  }
> 
> +static cycle_t rk_timer_clocksource_read(struct clocksource *cs)
^^
../drivers/clocksource/rockchip_timer.c:164:8: error: unknown type name ‘cycle_t’
 static cycle_t rk_timer_clocksource_read(struct clocksource *cs)

looks like something in clocksources changed since november

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 9/9] clocksource/drivers/rockchip_timer: implement clocksource timer
Date: Mon, 23 Jan 2017 18:09:41 +0100	[thread overview]
Message-ID: <2966820.3ediQCxqSR@diego> (raw)
In-Reply-To: <1480436092-10728-10-git-send-email-al.kochet@gmail.com>

Am Dienstag, 29. November 2016, 19:14:52 CET schrieb Alexander Kochetkov:
> The clock supplying the arm-global-timer on the rk3188 is coming from the
> the cpu clock itself and thus changes its rate everytime cpufreq adjusts
> the cpu frequency making this timer unsuitable as a stable clocksource
> and sched clock.
> 
> The rk3188, rk3288 and following socs share a separate timer block already
> handled by the rockchip-timer driver. Therefore adapt this driver to also
> be able to act as clocksource and sched clock on rk3188.
> 
> In order to test clocksource you can run following commands and check
> how much time it take in real. On rk3188 it take about ~45 seconds.
> 
>     cpufreq-set -f 1.6GHZ
>     date; sleep 60; date
> 
> In order to use the patch you need to declare two timers in the dts
> file. The first timer will be initialized as clockevent provider
> and the second one as clocksource. The clockevent must be from
> alive subsystem as it used as backup for the local timers at sleep
> time.
> 
> The patch does not break compatibility with older device tree files.
> The older device tree files contain only one timer. The timer
> will be initialized as clockevent, as expected.
> 
> rk3288 (and probably anything newer) is irrelevant to this patch,
> as it has the arch timer interface. This patch may be usefull
> for Cortex-A9/A5 based parts.
> 
> Signed-off-by: Alexander Kochetkov <al.kochet@gmail.com>

[...]

> @@ -120,13 +161,46 @@ static irqreturn_t rk_timer_interrupt(int irq, void
> *dev_id) return IRQ_HANDLED;
>  }
> 
> +static cycle_t rk_timer_clocksource_read(struct clocksource *cs)
^^
../drivers/clocksource/rockchip_timer.c:164:8: error: unknown type name ?cycle_t?
 static cycle_t rk_timer_clocksource_read(struct clocksource *cs)

looks like something in clocksources changed since november

  reply	other threads:[~2017-01-23 17:09 UTC|newest]

Thread overview: 147+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-28 14:31 [PATCHv2 00/11] Implement clocksource for rockchip SoC using rockchip timer Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` Alexander Kochetkov
2016-11-28 14:31 ` [PATCHv2 03/11] ARM: dts: rockchip: update compatible property for rk3229 timer Alexander Kochetkov
2016-11-28 14:31   ` Alexander Kochetkov
     [not found] ` <1480343486-25539-1-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-28 14:31   ` [PATCHv2 01/11] dt-bindings: clarify compatible property for rockchip timers Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31   ` [PATCHv2 02/11] ARM: dts: rockchip: update compatible property for rk3228 timer Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31   ` [PATCHv2 04/11] ARM: dts: rockchip: add timer entries to rk3188 dtsi Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31   ` [PATCHv2 05/11] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31   ` [PATCHv2 06/11] clocksource/drivers/rockchip_timer: low level routines take rk_timer as parameter Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31   ` [PATCHv2 07/11] clocksource/drivers/rockchip_timer: drop unused rk_base() and rk_ctrl() Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31   ` [PATCHv2 09/11] clocksource/drivers/rockchip_timer: implement loading 64bit value into timer Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31   ` [PATCHv2 10/11] clocksource/drivers/rockchip_timer: implement reading 64bit value from timer Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31   ` [PATCHv2 11/11] clocksource/drivers/rockchip_timer: implement clocksource timer Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-28 14:31     ` Alexander Kochetkov
2016-11-29 13:45   ` [PATCH v3 00/13] Implement clocksource for rockchip SoC using rockchip timer Alexander Kochetkov
2016-11-29 13:45     ` Alexander Kochetkov
2016-11-29 13:45     ` Alexander Kochetkov
2016-11-29 13:45     ` [PATCH v3 07/13] clocksource/drivers/rockchip_timer: low level routines take rk_timer as parameter Alexander Kochetkov
2016-11-29 13:45       ` Alexander Kochetkov
     [not found]     ` <1480427118-5126-1-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-29 13:45       ` [PATCH v3 01/13] dt-bindings: clarify compatible property for rockchip timers Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45       ` [PATCH v3 02/13] ARM: dts: rockchip: update compatible property for rk3228 timer Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45       ` [PATCH v3 03/13] ARM: dts: rockchip: update compatible property for rk3229 timer Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45       ` [PATCH v3 04/13] ARM: dts: rockchip: add timer entries to rk3188 dtsi Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45       ` [PATCH v3 05/13] ARM: dts: rockchip: disable arm-global-timer for rk3188 Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45       ` [PATCH v3 06/13] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45       ` [PATCH v3 08/13] clocksource/drivers/rockchip_timer: drop unused rk_base() and rk_ctrl() Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
     [not found]         ` <1480427118-5126-9-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-29 15:03           ` Heiko Stübner
2016-11-29 15:03             ` Heiko Stübner
2016-11-29 15:03             ` Heiko Stübner
2016-11-29 13:45       ` [PATCH v3 09/13] clocksource/drivers/rockchip_timer: move TIMER_INT_UNMASK out of rk_timer_enable() Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45       ` [PATCH v3 10/13] clocksource/drivers/rockchip_timer: implement loading 64bit value into timer Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45       ` [PATCH v3 11/13] clocksource/drivers/rockchip_timer: implement reading 64bit value from timer Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45       ` [PATCH v3 12/13] clocksource/drivers/rockchip_timer: implement clocksource timer Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45       ` [PATCH v3 13/13] clocksource/drivers/rockchip_timer: Prevent ftrace recursion Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
2016-11-29 13:45         ` Alexander Kochetkov
     [not found]         ` <1480427118-5126-14-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-29 15:01           ` Heiko Stübner
2016-11-29 15:01             ` Heiko Stübner
2016-11-29 15:01             ` Heiko Stübner
2016-11-29 15:36             ` Alexander Kochetkov
2016-11-29 15:36               ` Alexander Kochetkov
2016-11-29 15:36               ` Alexander Kochetkov
2016-11-29 16:14   ` [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer Alexander Kochetkov
2016-11-29 16:14     ` Alexander Kochetkov
2016-11-29 16:14     ` Alexander Kochetkov
2016-11-29 16:14     ` [PATCH v4 1/9] dt-bindings: clarify compatible property for rockchip timers Alexander Kochetkov
2016-11-29 16:14       ` Alexander Kochetkov
2016-11-29 16:14       ` Alexander Kochetkov
     [not found]       ` <1480436092-10728-2-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-05 22:22         ` Rob Herring
2016-12-05 22:22           ` Rob Herring
2016-12-05 22:22           ` Rob Herring
2016-11-29 16:14     ` [PATCH v4 2/9] ARM: dts: rockchip: update compatible property for rk3228 timer Alexander Kochetkov
2016-11-29 16:14       ` Alexander Kochetkov
     [not found]       ` <1480436092-10728-3-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-23 15:40         ` Daniel Lezcano
2017-01-23 15:40           ` Daniel Lezcano
2017-01-23 15:40           ` Daniel Lezcano
2017-01-23 16:12           ` Heiko Stübner
2017-01-23 16:12             ` Heiko Stübner
2017-01-23 16:12             ` Heiko Stübner
2017-01-23 16:13           ` Alexander Kochetkov
2017-01-23 16:13             ` Alexander Kochetkov
2017-01-23 16:13             ` Alexander Kochetkov
2016-11-29 16:14     ` [PATCH v4 6/9] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device Alexander Kochetkov
2016-11-29 16:14       ` Alexander Kochetkov
2017-01-23 16:26       ` Daniel Lezcano
2017-01-23 16:26         ` Daniel Lezcano
2017-01-23 16:45         ` Alexander Kochetkov
2017-01-23 16:45           ` Alexander Kochetkov
2016-11-29 16:14     ` [PATCH v4 7/9] clocksource/drivers/rockchip_timer: low level routines take rk_timer as parameter Alexander Kochetkov
2016-11-29 16:14       ` Alexander Kochetkov
2016-11-29 16:14     ` [PATCH v4 8/9] clocksource/drivers/rockchip_timer: move TIMER_INT_UNMASK out of rk_timer_enable() Alexander Kochetkov
2016-11-29 16:14       ` Alexander Kochetkov
2016-11-29 16:14     ` [PATCH v4 9/9] clocksource/drivers/rockchip_timer: implement clocksource timer Alexander Kochetkov
2016-11-29 16:14       ` Alexander Kochetkov
2017-01-23 17:09       ` Heiko Stübner [this message]
2017-01-23 17:09         ` Heiko Stübner
     [not found]     ` <1480436092-10728-1-git-send-email-al.kochet-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-11-29 16:14       ` [PATCH v4 3/9] ARM: dts: rockchip: update compatible property for rk3229 timer Alexander Kochetkov
2016-11-29 16:14         ` Alexander Kochetkov
2016-11-29 16:14         ` Alexander Kochetkov
2016-11-29 16:14       ` [PATCH v4 4/9] ARM: dts: rockchip: add timer entries to rk3188 SoC Alexander Kochetkov
2016-11-29 16:14         ` Alexander Kochetkov
2016-11-29 16:14         ` Alexander Kochetkov
2016-11-29 16:14       ` [PATCH v4 5/9] ARM: dts: rockchip: disable arm-global-timer for rk3188 Alexander Kochetkov
2016-11-29 16:14         ` Alexander Kochetkov
2016-11-29 16:14         ` Alexander Kochetkov
2017-01-23 16:14         ` Heiko Stübner
2017-01-23 16:14           ` Heiko Stübner
2016-12-21 14:21       ` [PATCH v4 0/9] Implement clocksource for rockchip SoC using rockchip timer Alexander Kochetkov
2016-12-21 14:21         ` Alexander Kochetkov
2016-12-21 14:21         ` Alexander Kochetkov
     [not found]         ` <E6DD9335-0D2D-47CB-8098-5F96C2E08139-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-01-23 14:47           ` Daniel Lezcano
2017-01-23 14:47             ` Daniel Lezcano
2017-01-23 14:47             ` Daniel Lezcano
2017-01-23 17:12             ` Heiko Stübner
2017-01-23 17:12               ` Heiko Stübner
2017-01-23 17:24               ` Alexander Kochetkov
2017-01-23 17:24                 ` Alexander Kochetkov
2017-01-23 17:24                 ` Alexander Kochetkov
2017-01-23 17:57                 ` Daniel Lezcano
2017-01-23 17:57                   ` Daniel Lezcano
2017-01-26 11:08                   ` Alexander Kochetkov
2017-01-26 11:08                     ` Alexander Kochetkov
2017-01-26 11:08                     ` Alexander Kochetkov
2017-01-26 13:19                     ` Daniel Lezcano
2017-01-26 13:19                       ` Daniel Lezcano
2016-11-28 14:31 ` [PATCHv2 08/11] clocksource/drivers/rockchip_timer: move TIMER_INT_UNMASK out of rk_timer_enable() Alexander Kochetkov
2016-11-28 14:31   ` Alexander Kochetkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2966820.3ediQCxqSR@diego \
    --to=heiko@sntech.de \
    --cc=al.kochet@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=huangtao@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wxt@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.