From: David Howells <dhowells@redhat.com>
To: linux-security-module@vger.kernel.org
Subject: Re: [PATCH] KEYS: prevent creating a different user's keyrings
Date: Tue, 19 Sep 2017 16:05:20 +0000 [thread overview]
Message-ID: <29684.1505837120@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170918183703.114134-1-ebiggers3@gmail.com>
Eric Biggers <ebiggers3@gmail.com> wrote:
> Fix it by marking user and user session keyrings with a flag
> KEY_FLAG_UID_KEYRING. Then, when searching for a user or user session
> keyring by name, skip all keyrings that don't have the flag set.
I wonder if it's better just to reject attempts to manually create/join
keyrings of such names. PAM uses the implicit creation method of specifying
the 'macro' key IDs for these keyrings.
David
WARNING: multiple messages have this Message-ID (diff)
From: dhowells@redhat.com (David Howells)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] KEYS: prevent creating a different user's keyrings
Date: Tue, 19 Sep 2017 17:05:20 +0100 [thread overview]
Message-ID: <29684.1505837120@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170918183703.114134-1-ebiggers3@gmail.com>
Eric Biggers <ebiggers3@gmail.com> wrote:
> Fix it by marking user and user session keyrings with a flag
> KEY_FLAG_UID_KEYRING. Then, when searching for a user or user session
> keyring by name, skip all keyrings that don't have the flag set.
I wonder if it's better just to reject attempts to manually create/join
keyrings of such names. PAM uses the implicit creation method of specifying
the 'macro' key IDs for these keyrings.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Eric Biggers <ebiggers3@gmail.com>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
Michael Halcrow <mhalcrow@google.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] KEYS: prevent creating a different user's keyrings
Date: Tue, 19 Sep 2017 17:05:20 +0100 [thread overview]
Message-ID: <29684.1505837120@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170918183703.114134-1-ebiggers3@gmail.com>
Eric Biggers <ebiggers3@gmail.com> wrote:
> Fix it by marking user and user session keyrings with a flag
> KEY_FLAG_UID_KEYRING. Then, when searching for a user or user session
> keyring by name, skip all keyrings that don't have the flag set.
I wonder if it's better just to reject attempts to manually create/join
keyrings of such names. PAM uses the implicit creation method of specifying
the 'macro' key IDs for these keyrings.
David
next prev parent reply other threads:[~2017-09-19 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 18:37 [PATCH] KEYS: prevent creating a different user's keyrings Eric Biggers
2017-09-18 18:37 ` Eric Biggers
2017-09-18 18:37 ` Eric Biggers
2017-09-19 16:05 ` David Howells [this message]
2017-09-19 16:05 ` David Howells
2017-09-19 16:05 ` David Howells
2017-09-21 22:00 ` Eric Biggers
2017-09-21 22:00 ` Eric Biggers
2017-09-21 22:00 ` Eric Biggers
2017-09-25 11:54 ` David Howells
2017-09-25 11:54 ` David Howells
2017-09-25 11:54 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29684.1505837120@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.