From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: dev@dpdk.org, bruce.richardson@intel.com, olivier.matz@6wind.com
Subject: Re: [PATCH v4 0/5] lpm allocation fixes
Date: Tue, 22 Mar 2016 17:14:58 +0100 [thread overview]
Message-ID: <2983189.UJ094KPj7K@xps13> (raw)
In-Reply-To: <1458569175-8742-1-git-send-email-christian.ehrhardt@canonical.com>
2016-03-21 15:06, Christian Ehrhardt:
> Poking a bit on autotest revealed a few shortcomings in the lpm allocation path.
> Thanks to the feedback to the first revision of the patches here v2.
> Also Oliver Matz spotted similar issues and made me aware - thanks!
> Integrating them revealed even more use after free / leak issues.
>
> *updates in v4*
> - re-removing the { } on single line ifs accidentially droped in v3
> - adding the ack of Oliver Matz
>
> *updates in v3*
> - lpm create/free path for v20 and v1604 got the same fixes that were
> already identified for lpm6 before
>
> *updates in v2*
> - lpm/lpm6 patches split
> - following dpdk coding guidelines regarding single line if's
> - adding singed-off and acked-bys gathered so far
> - combine all three related patches in one series
>
> Christian Ehrhardt (5):
> lpm6: fix use after free of lpm in rte_lpm6_create
> lpm6: fix missing free of rules_tbl and lpm
> lpm: fix missing free of lpm
> lpm: fix use after free of lpm in rte_lpm_create*
> lpm: fix missing free of rules_tbl and lpm in rte_lpm_free*
Applied, thanks
prev parent reply other threads:[~2016-03-22 16:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 12:33 [PATCH 0/3] lpm allocation fixes - v2 Christian Ehrhardt
2016-03-16 12:33 ` [PATCH 1/3] lpm6: fix use after free of lpm in rte_lpm6_create Christian Ehrhardt
2016-03-16 12:33 ` [PATCH 2/3] lpm6: fix missing free of rules_tbl and lpm Christian Ehrhardt
2016-03-16 12:33 ` [PATCH 3/3] lpm: fix missing free of lpm Christian Ehrhardt
2016-03-16 13:14 ` Olivier MATZ
2016-03-16 13:34 ` Christian Ehrhardt
2016-03-21 14:06 ` [PATCH v4 0/5] lpm allocation fixes Christian Ehrhardt
2016-03-21 14:06 ` [PATCH v4 1/5] lpm6: fix use after free of lpm in rte_lpm6_create Christian Ehrhardt
2016-03-21 14:06 ` [PATCH v4 2/5] lpm6: fix missing free of rules_tbl and lpm Christian Ehrhardt
2016-03-21 14:06 ` [PATCH v4 3/5] lpm: fix missing free of lpm Christian Ehrhardt
2016-03-21 14:06 ` [PATCH v4 4/5] lpm: fix use after free of lpm in rte_lpm_create* Christian Ehrhardt
2016-03-21 14:06 ` [PATCH v4 5/5] lpm: fix missing free of rules_tbl and lpm in rte_lpm_free* Christian Ehrhardt
2016-03-22 16:14 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2983189.UJ094KPj7K@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.