* [PATCH] arm64: dts: rockchip: Improve gmac phy setup for QNAP-TS433
@ 2025-03-18 18:45 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2025-03-18 18:45 UTC (permalink / raw)
To: Heiko Stuebner, Andrew Lunn
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-arm-kernel, linux-rockchip
Instead of relying on the MDIO broadcast address (0) talk to the phy on
its configured address. Also add the phy reset gpio which was found by
Heiko inspecting the U-Boot vendor source code. He is still trying to
recover.
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
.../arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
index 7bd32d230ad2..411f8ac7994b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
@@ -481,9 +481,14 @@ eeprom@56 {
};
&mdio0 {
- rgmii_phy0: ethernet-phy@0 {
+ rgmii_phy0: ethernet-phy@3 {
+ /* Motorcomm YT8521 phy */
compatible = "ethernet-phy-ieee802.3-c22";
- reg = <0x0>;
+ reg = <0x3>;
+ pinctrl-0 = <ð_phy0_reset_pin>;
+ pinctrl-names = "default";
+ reset-assert-us = <10000>;
+ reset-gpios = <&gpio0 RK_PC6 GPIO_ACTIVE_LOW>;
};
};
@@ -556,6 +561,12 @@ &pcie3x2 {
};
&pinctrl {
+ gmac0 {
+ eth_phy0_reset_pin: eth-phy0-reset-pin {
+ rockchip,pins = <0 RK_PC6 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+
keys {
copy_button_pin: copy-button-pin {
rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_up>;
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
--
2.47.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] arm64: dts: rockchip: Improve gmac phy setup for QNAP-TS433
@ 2025-03-18 18:45 ` Uwe Kleine-König
0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2025-03-18 18:45 UTC (permalink / raw)
To: Heiko Stuebner, Andrew Lunn
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-arm-kernel, linux-rockchip
Instead of relying on the MDIO broadcast address (0) talk to the phy on
its configured address. Also add the phy reset gpio which was found by
Heiko inspecting the U-Boot vendor source code. He is still trying to
recover.
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
---
.../arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
index 7bd32d230ad2..411f8ac7994b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
@@ -481,9 +481,14 @@ eeprom@56 {
};
&mdio0 {
- rgmii_phy0: ethernet-phy@0 {
+ rgmii_phy0: ethernet-phy@3 {
+ /* Motorcomm YT8521 phy */
compatible = "ethernet-phy-ieee802.3-c22";
- reg = <0x0>;
+ reg = <0x3>;
+ pinctrl-0 = <ð_phy0_reset_pin>;
+ pinctrl-names = "default";
+ reset-assert-us = <10000>;
+ reset-gpios = <&gpio0 RK_PC6 GPIO_ACTIVE_LOW>;
};
};
@@ -556,6 +561,12 @@ &pcie3x2 {
};
&pinctrl {
+ gmac0 {
+ eth_phy0_reset_pin: eth-phy0-reset-pin {
+ rockchip,pins = <0 RK_PC6 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+
keys {
copy_button_pin: copy-button-pin {
rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_up>;
base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
--
2.47.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Improve gmac phy setup for QNAP-TS433
2025-03-18 18:45 ` Uwe Kleine-König
@ 2025-03-18 19:40 ` Heiko Stübner
-1 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2025-03-18 19:40 UTC (permalink / raw)
To: Andrew Lunn, Uwe Kleine-König
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-arm-kernel, linux-rockchip
Hey Uwe,
Am Dienstag, 18. März 2025, 19:45:49 MEZ schrieb Uwe Kleine-König:
> Instead of relying on the MDIO broadcast address (0) talk to the phy on
> its configured address. Also add the phy reset gpio which was found by
> Heiko inspecting the U-Boot vendor source code. He is still trying to
> recover.
I believe these want to be two separate changes ... as indicated by
the "Also ..." in the commit message:
- reset-gpio addition
- mdio address change
and I guess both could possibly have a
Fixes: 9da1c0327d58 ("arm64: dts: rockchip: Add basic support for QNAP TS-433")
Heiko
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
> .../arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
> index 7bd32d230ad2..411f8ac7994b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
> @@ -481,9 +481,14 @@ eeprom@56 {
> };
>
> &mdio0 {
> - rgmii_phy0: ethernet-phy@0 {
> + rgmii_phy0: ethernet-phy@3 {
> + /* Motorcomm YT8521 phy */
> compatible = "ethernet-phy-ieee802.3-c22";
> - reg = <0x0>;
> + reg = <0x3>;
> + pinctrl-0 = <ð_phy0_reset_pin>;
> + pinctrl-names = "default";
> + reset-assert-us = <10000>;
> + reset-gpios = <&gpio0 RK_PC6 GPIO_ACTIVE_LOW>;
> };
> };
>
> @@ -556,6 +561,12 @@ &pcie3x2 {
> };
>
> &pinctrl {
> + gmac0 {
> + eth_phy0_reset_pin: eth-phy0-reset-pin {
> + rockchip,pins = <0 RK_PC6 RK_FUNC_GPIO &pcfg_pull_up>;
> + };
> + };
> +
> keys {
> copy_button_pin: copy-button-pin {
> rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_up>;
>
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: rockchip: Improve gmac phy setup for QNAP-TS433
@ 2025-03-18 19:40 ` Heiko Stübner
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stübner @ 2025-03-18 19:40 UTC (permalink / raw)
To: Andrew Lunn, Uwe Kleine-König
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-arm-kernel, linux-rockchip
Hey Uwe,
Am Dienstag, 18. März 2025, 19:45:49 MEZ schrieb Uwe Kleine-König:
> Instead of relying on the MDIO broadcast address (0) talk to the phy on
> its configured address. Also add the phy reset gpio which was found by
> Heiko inspecting the U-Boot vendor source code. He is still trying to
> recover.
I believe these want to be two separate changes ... as indicated by
the "Also ..." in the commit message:
- reset-gpio addition
- mdio address change
and I guess both could possibly have a
Fixes: 9da1c0327d58 ("arm64: dts: rockchip: Add basic support for QNAP TS-433")
Heiko
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
> .../arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 15 +++++++++++++--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
> index 7bd32d230ad2..411f8ac7994b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts
> @@ -481,9 +481,14 @@ eeprom@56 {
> };
>
> &mdio0 {
> - rgmii_phy0: ethernet-phy@0 {
> + rgmii_phy0: ethernet-phy@3 {
> + /* Motorcomm YT8521 phy */
> compatible = "ethernet-phy-ieee802.3-c22";
> - reg = <0x0>;
> + reg = <0x3>;
> + pinctrl-0 = <ð_phy0_reset_pin>;
> + pinctrl-names = "default";
> + reset-assert-us = <10000>;
> + reset-gpios = <&gpio0 RK_PC6 GPIO_ACTIVE_LOW>;
> };
> };
>
> @@ -556,6 +561,12 @@ &pcie3x2 {
> };
>
> &pinctrl {
> + gmac0 {
> + eth_phy0_reset_pin: eth-phy0-reset-pin {
> + rockchip,pins = <0 RK_PC6 RK_FUNC_GPIO &pcfg_pull_up>;
> + };
> + };
> +
> keys {
> copy_button_pin: copy-button-pin {
> rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_up>;
>
> base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-18 19:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-18 18:45 [PATCH] arm64: dts: rockchip: Improve gmac phy setup for QNAP-TS433 Uwe Kleine-König
2025-03-18 18:45 ` Uwe Kleine-König
2025-03-18 19:40 ` Heiko Stübner
2025-03-18 19:40 ` Heiko Stübner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.