All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: dhowells@redhat.com, akpm@linux-foundation.org, gregkh@suse.de,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used
Date: Wed, 30 Sep 2009 11:20:00 +0100	[thread overview]
Message-ID: <29895.1254306000@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.01.0909290909280.6996@localhost.localdomain>

Linus Torvalds <torvalds@linux-foundation.org> wrote:

> So I do wonder whether the right thing to do would not be to simple remove 
> the whole pty_ops_bsd code entirely. Or maybe mode the trivial TIOCSPTLCK 
> into the generic tty ioctl handling, and just make it test for 
> "driver->subtype == PTY_TYPE_MASTER" - and at least get rid of this subtle 
> thing that was broken for over a year without anybody noticing..

Also, does it matter if someone issues TIOCGPTN on a legacy pty master?  There
is a number in tty->index that can be returned.  If it can, then
pty_bsd_ioctl() can be merged with pty_unix98_ioctl(), and possibly both
ioctls can be given to the generic tty ioctl handling with the condition that
driver->subtype == PTY_TYPE_MASTER.

David

  parent reply	other threads:[~2009-09-30 10:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-28 13:53 [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used David Howells
2009-09-28 14:16 ` Alan Cox
2009-09-28 14:55   ` David Howells
2009-09-28 15:25     ` Alan Cox
2009-09-28 14:55   ` Linus Torvalds
2009-09-29 15:55     ` David Howells
2009-09-29 16:23       ` Linus Torvalds
2009-09-29 16:38         ` Linus Torvalds
2009-09-29 18:40           ` David Howells
2009-09-29 22:39             ` Alan Cox
2009-09-30 10:20         ` David Howells [this message]
2009-09-30 11:28           ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29895.1254306000@redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.