From: David Howells <dhowells@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: dhowells@redhat.com, torvalds@osdl.org,
akpm@linux-foundation.org, gregkh@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used
Date: Mon, 28 Sep 2009 15:55:44 +0100 [thread overview]
Message-ID: <7306.1254149744@redhat.com> (raw)
In-Reply-To: <20090928151628.62955233@lxorguk.ukuu.org.uk>
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > Possibly legacy_pty_init() should be passing this to tty_set_operations()
> > rather than pty_ops.
>
> It should indeed, otherwise the BSD pty locking ioctl fails.
In that case, what should be using pty_ops? If CONFIG_LEGACY_PTYS=n, then I
see:
drivers/char/pty.c:314: warning: unused variable `pty_ops'
David
next prev parent reply other threads:[~2009-09-28 14:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-28 13:53 [PATCH] Remove pty_ops_bsd and pty_bsd_ioctl() as they're not used David Howells
2009-09-28 14:16 ` Alan Cox
2009-09-28 14:55 ` David Howells [this message]
2009-09-28 15:25 ` Alan Cox
2009-09-28 14:55 ` Linus Torvalds
2009-09-29 15:55 ` David Howells
2009-09-29 16:23 ` Linus Torvalds
2009-09-29 16:38 ` Linus Torvalds
2009-09-29 18:40 ` David Howells
2009-09-29 22:39 ` Alan Cox
2009-09-30 10:20 ` David Howells
2009-09-30 11:28 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7306.1254149744@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.