From: "Heiko Stübner" <heiko@sntech.de>
To: linux-kernel@vger.kernel.org, Shimrra Shai <shimrrashai@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org,
robh@kernel.org, Shimrra Shai <shimrrashai@gmail.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: rockchip: Add Firefly ITX-3588J board
Date: Fri, 10 Jan 2025 00:03:08 +0100 [thread overview]
Message-ID: <2999810.o0KrE1Onz3@diego> (raw)
In-Reply-To: <20241216214152.58387-2-shimrrashai@gmail.com>
Am Montag, 16. Dezember 2024, 22:41:51 CET schrieb Shimrra Shai:
> Document board compatible bindings.
>
> Signed-off-by: Shimrra Shai <shimrrashai@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 753199a12..fc7ee86e2 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -167,6 +167,13 @@ properties:
> - const: engicam,px30-core
> - const: rockchip,px30
>
> + - description: Firefly Core-3588J-based boards
> + items:
> + - enum:
> + - firefly,itx-3588j
> + - const: firefly,core-3588j
> + - const: rockchip,rk3588
> +
> - description: Firefly Core-PX30-JD4 on MB-JD4-PX30 baseboard
> items:
> - const: firefly,px30-jd4-core-mb
>
In v3 [0] the board dt-binding got an
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
so Krzysztof already noted, please carry those forward into new versions.
[0] https://lore.kernel.org/linux-arm-kernel/x7y24y3bkbj5fzx5pdprjr5umg6egxsy2xscfbj3xgzgzubvdk@ppncjiqoekk7/
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: linux-kernel@vger.kernel.org, Shimrra Shai <shimrrashai@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org,
robh@kernel.org, Shimrra Shai <shimrrashai@gmail.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: rockchip: Add Firefly ITX-3588J board
Date: Fri, 10 Jan 2025 00:03:08 +0100 [thread overview]
Message-ID: <2999810.o0KrE1Onz3@diego> (raw)
In-Reply-To: <20241216214152.58387-2-shimrrashai@gmail.com>
Am Montag, 16. Dezember 2024, 22:41:51 CET schrieb Shimrra Shai:
> Document board compatible bindings.
>
> Signed-off-by: Shimrra Shai <shimrrashai@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 753199a12..fc7ee86e2 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -167,6 +167,13 @@ properties:
> - const: engicam,px30-core
> - const: rockchip,px30
>
> + - description: Firefly Core-3588J-based boards
> + items:
> + - enum:
> + - firefly,itx-3588j
> + - const: firefly,core-3588j
> + - const: rockchip,rk3588
> +
> - description: Firefly Core-PX30-JD4 on MB-JD4-PX30 baseboard
> items:
> - const: firefly,px30-jd4-core-mb
>
In v3 [0] the board dt-binding got an
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
so Krzysztof already noted, please carry those forward into new versions.
[0] https://lore.kernel.org/linux-arm-kernel/x7y24y3bkbj5fzx5pdprjr5umg6egxsy2xscfbj3xgzgzubvdk@ppncjiqoekk7/
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-01-09 23:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 21:41 [PATCH v4 0/2] arm64: dts: rockchip: Add Firefly ITX-3588J Board Shimrra Shai
2024-12-16 21:41 ` Shimrra Shai
2024-12-16 21:41 ` [PATCH v4 1/2] dt-bindings: arm: rockchip: Add Firefly ITX-3588J board Shimrra Shai
2024-12-16 21:41 ` Shimrra Shai
2024-12-17 6:01 ` Krzysztof Kozlowski
2024-12-17 6:01 ` Krzysztof Kozlowski
2025-01-09 23:03 ` Heiko Stübner [this message]
2025-01-09 23:03 ` Heiko Stübner
2024-12-16 21:41 ` [PATCH v4 2/2] arm64: dts: rockchip: add DTs for Firefly ITX-3588J and its Core-3588J SoM Shimrra Shai
2024-12-16 21:41 ` Shimrra Shai
2025-01-09 23:15 ` [PATCH v4 0/2] arm64: dts: rockchip: Add Firefly ITX-3588J Board Heiko Stuebner
2025-01-09 23:15 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2999810.o0KrE1Onz3@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
--cc=shimrrashai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.