From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: broonie@kernel.org, yung-chuan.liao@linux.intel.com,
vkoul@kernel.org, lgirdwood@gmail.com,
peter.ujfalusi@linux.intel.com, shumingf@realtek.com,
linux-sound@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH 6/7] ASoC: SDCA: Device boot into the system suspend process
Date: Sat, 20 Dec 2025 12:36:28 +0100 [thread overview]
Message-ID: <29a84319-39ff-4d45-a10a-1662985106b6@linux.dev> (raw)
In-Reply-To: <aTqyJe7t9cq1UUya@opensource.cirrus.com>
On 12/11/25 12:59, Charles Keepax wrote:
> On Tue, Dec 09, 2025 at 12:18:09PM +0000, Pierre-Louis Bossart wrote:
>> On 11/25/25 15:21, Charles Keepax wrote:
>>> + /*
>>> + * FDL has to run from the system resume handler, at which point
>>> + * pm_runtime isn't yet active.
>>> + */
>>
>> aren't there cases where FDL also needs to run in a pm_runtime
>> resume case?
>
> Potentially, depends if someone builds a system that does that.
>
>> My understanding of FDL is that the host would *always* check
>> if the device lost context and if firmware is required then the
>> download takes place. I am not sure why we need the assumption
>> that firmware is *only* required for system resume?
>
> Mostly because it seems that is pretty standard for PC systems,
> to only drop rails on hibernate.
>
> But the primary issue I have is the "check if the device lost
> context" part. I don't see a good way to implement that under
> SDCA. If we figure out a good way to do that then most of my
> objections to allowing the firmware download on runtime resume
> go away.
Wondering if the 'Needs_Initialization' bit could be used but not only initialization writes but firmware as well?
it could be device-specific, but IIRC that was one way to check if context was lost or not.
And there are other bits that tell you if the function was reset, see Function_has_been_reset in the Function_Status control.
next prev parent reply other threads:[~2025-12-20 11:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 15:21 [PATCH 0/7] SDCA jack and system suspend fixups Charles Keepax
2025-11-25 15:21 ` [PATCH 1/7] ASoC: SDCA: Factor out jack handling into new c file Charles Keepax
2025-12-09 12:00 ` Pierre-Louis Bossart
2025-12-10 16:31 ` Charles Keepax
2025-12-20 11:22 ` Pierre-Louis Bossart
2025-11-25 15:21 ` [PATCH 2/7] ASoC: SDCA: Add ability to connect SDCA jacks to ASoC jacks Charles Keepax
2025-11-25 15:21 ` [PATCH 3/7] ASoC: SDCA: Add ASoC jack hookup in class driver Charles Keepax
2025-11-25 15:21 ` [PATCH 4/7] ASoC: SDCA: Add SDCA IRQ enable/disable helpers Charles Keepax
2025-12-09 12:03 ` Pierre-Louis Bossart
2025-11-25 15:21 ` [PATCH 5/7] ASoC: SDCA: Add basic system suspend support Charles Keepax
2025-12-09 12:11 ` Pierre-Louis Bossart
2025-12-10 14:43 ` Charles Keepax
2025-12-10 16:48 ` Charles Keepax
2025-12-11 10:33 ` Vinod Koul
2025-12-11 11:28 ` Charles Keepax
2025-12-20 11:31 ` Pierre-Louis Bossart
2025-11-25 15:21 ` [PATCH 6/7] ASoC: SDCA: Device boot into the system suspend process Charles Keepax
2025-12-09 12:18 ` Pierre-Louis Bossart
2025-12-11 11:59 ` Charles Keepax
2025-12-20 11:36 ` Pierre-Louis Bossart [this message]
2025-11-25 15:21 ` [PATCH 7/7] ASoC: SDCA: Add lock to serialise the Function initialisation Charles Keepax
2025-12-09 12:20 ` Pierre-Louis Bossart
2025-12-10 15:27 ` Charles Keepax
2025-12-11 10:26 ` Richard Fitzgerald
2025-12-20 11:21 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29a84319-39ff-4d45-a10a-1662985106b6@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=shumingf@realtek.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.