Re: [PATCH 6/7] ASoC: SDCA: Device boot into the system suspend process

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

On 11/25/25 15:21, Charles Keepax wrote:
> When system suspending the device may be powered off, this means all
> state will be lost and the firmware may need to be re-downloaded. Add
> the necessary calls to bring the device back up. This also requires that
> that the FDL (firmware download) IRQ handler is modified to allow it to
> run before runtime PM has been fully restored.

Sounds good indeed.

>  		sdca_irq_enable(drv->function, drv->core->irq_info, true);
> +
> +		ret = sdca_fdl_sync(drv->dev, drv->function, drv->core->irq_info);
> +		if (ret)
> +			goto err;
> +
>  		sdca_irq_enable(drv->function, drv->core->irq_info, false);

This answers to my comment on the previous patch but you could make it easier on the reviewer with a better description of what the next patches add.

>  
> +		ret = regmap_write(drv->regmap, reg, 0xFF);
> +		if (ret < 0) {
> +			dev_err(drv->dev, "failed to clear function status: %d\n", ret);
> +			goto err;
> +		}
> +

> +	/*
> +	 * FDL has to run from the system resume handler, at which point
> +	 * pm_runtime isn't yet active.
> +	 */

aren't there cases where FDL also needs to run in a pm_runtime resume case?
My understanding of FDL is that the host would *always* check if the device lost context and if firmware is required then the download takes place. I am not sure why we need the assumption that firmware is *only* required for system resume?