Re: [PATCH v2 2/9] util/grub-editenv: add fs_envblk open helper

[Avnish Chouhan <avnish@linux.ibm.com>]

On 2025-10-02 11:14, Michael Chang wrote:
> Hi Avnish,
> 
> Sorry for the late reply. Please check my comments below:
> 
> On Wed, Sep 17, 2025 at 04:13:21PM +0530, Avnish Chouhan wrote:
>> On 2025-09-15 14:39, grub-devel-request@gnu.org wrote:
>> > Message: 3
>> > Date: Mon, 15 Sep 2025 17:08:41 +0800
>> > From: Michael Chang <mchang@suse.com>
>> > To: The development of GNU GRUB <grub-devel@gnu.org>
>> > Cc: Neal Gompa <ngompa13@gmail.com>,	Marta Lewandowska
>> > 	<mlewando@redhat.com>
>> > Subject: [PATCH v2 2/9] util/grub-editenv: add fs_envblk open helper
>> > Message-ID: <20250915090848.131937-3-mchang@suse.com>
>> >
>> > This patch adds the logic to locate and open an environment block that
>> > is stored in a reserved area on the device. It introduces the function
>> > fs_envblk_open together with helper routines to read the block pointed
>> > to by the env_block variable, and to create the block on disk when it
>> > does not yet exist. When a block is created, the code records its
>> > location inside the file based envblk by setting env_block in block list
>> > syntax of offset plus size in sectors.
>> >
>> > The env_block variable acts as a link from the file envblk to the raw
>> > disk region so that later runs of grub editenv can follow it and access
>> > the external block. The helper is exposed through a small ops table
>> > attached to fs_envblk so that later patches can call
>> > fs_envblk->ops->open without touching core code again. At this stage
>> > variables are still stored in the file envblk and no redirection has
>> > been applied.
>> >
>> > Signed-off-by: Michael Chang <mchang@suse.com>

Reviewed-by: Avnish Chouhan <avnish@linux.ibm.com>

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel